Donovan Daniels
21facdd638
[PostSets] require post_ids[] for adding/removing posts
2024-01-04 14:24:45 -06:00
Donovan Daniels
330fb7cb8b
[DMails] Return no content in api instead of redirecting ( #575 )
...
* [DMails] Return no content in api instead of redirecting
* Expand `fmt`, remove explicit 204
2024-01-04 17:53:16 +01:00
Earlopain
be9fca4198
Merge pull request #577 from DonovanDMC/forum-topics-mark-as-read-json
...
[ForumTopics] Return no content instead of redirecting when marking all as read
2024-01-03 15:57:49 +01:00
Earlopain
95003d2014
Merge pull request #578 from DonovanDMC/fix-uploads-parent_id-search
...
[Uploads] Fix parent_id search
2024-01-03 15:56:34 +01:00
Earlopain
ea53b3d925
Merge pull request #579 from DonovanDMC/cub-is-dead
...
[Uploader] Remove cub from contentious examples
2024-01-03 15:56:18 +01:00
Donovan Daniels
8b3b7c7051
[Uploader] Remove cub from contentious examples
2023-12-28 22:10:12 -06:00
Donovan Daniels
bce86389b0
[Uploads] Fix parent_id search
2023-12-22 19:13:52 -06:00
Donovan Daniels
7e9c4eaa90
[ForumTopics] Return no content instead of redirecting when marking all as read
2023-12-20 23:19:13 -06:00
Donovan Daniels
53cea71422
[PostSets] Render expected error when post_ids[] is missing
2023-12-20 22:46:27 -06:00
Earlopain
acae76a907
[Dmails] Change http verb from post to put for marking as read
...
That's what mark_all_as_read should have been from the start and
what I should have put mark_as_read to as well
2023-12-18 20:03:38 +01:00
Earlopain
4106787487
[Gems] Remove explicit dependecy on resolv
...
It's a default gem and as such not needed there
2023-12-17 20:28:10 +01:00
Earlopain
c66e7c1f34
[Uploads] Allow underscore in whitelist entry
2023-12-17 20:16:58 +01:00
Earlopain
d4f72baf5f
[Comments] Disable the button on submit
...
Should hopefully do something against the constant double-submits
2023-12-17 20:11:59 +01:00
Earlopain
18f8f99730
[Dmails] Don't mark as read on show for API requests
2023-12-17 20:08:44 +01:00
Earlopain
f477141c63
[Dmails] Add route to mark single dmail read
2023-12-17 20:06:10 +01:00
Earlopain
16014a438f
[Dmails] Partially enable api
...
Basically everything except sending
2023-12-17 19:55:13 +01:00
Earlopain
50f5e3e77c
[Dmails] Put everything behind being member
...
See ef1db967f7
2023-12-11 15:30:00 +01:00
Earlopain
acd1981773
[Forum] Add confirmation to unsticky and unlock
2023-12-08 17:00:50 +01:00
Earlopain
89acdd77a4
Merge pull request #566 from DonovanDMC/vote-management-links
...
[VoteManager]: Make links work
2023-12-08 16:55:50 +01:00
Earlopain
1322efc8cf
Merge pull request #565 from DonovanDMC/aibur-approval-confirmation
...
[TagRelationships]: Add approval confirmation
2023-12-08 16:54:56 +01:00
Donovan Daniels
d046c03ce0
[VoteManager]: Make links work
2023-12-07 08:32:23 -06:00
Donovan Daniels
7f3b403383
[TagRelationships]: Add approval confirmation
2023-12-07 08:27:06 -06:00
Earlopain
76a9b601b3
[Rubocop] Regenerate todo
...
1004 files inspected, 5443 offenses detected, 5197 offenses autocorrectable
2023-12-04 20:57:56 +01:00
Earlopain
d9bfd29b48
[Uploads] Fix missing paren in error message
2023-12-04 20:56:53 +01:00
Donovan Daniels
74007f2e30
[Blips] Add Updater & Tests/Move modactions to callbacks ( #540 )
...
* [Blips] Add `updater_id` & update notice
* [Blips] Move modaction generation logic into rails callbacks
* [Tests] Add blip tests
* Move update notice to right place
* Assert amount of difference
* Rebase oopsie
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 20:56:14 +01:00
Donovan Daniels
fd5b491694
[UserWarnable] Fix warning_user_id never being set ( #541 )
...
* [UserWarnable] fix `warning_user_id` never being set
I know `update` & `update_columns` function differently, but I feel the difference isn't needed
* [UserWarnable] Add inline user and timestamp
* lint
* Move warning info into partial
Also removes the user/timestamp as that is redundant for now
* Fix unmarking
* Tweak fixer script
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 20:19:49 +01:00
Donovan Daniels
6eaf435002
Bring ForumPost ModAction trigger in line with Comments ( #542 )
...
* [Tests] Add hide & delete modaction tests to comments and forum posts
* [ForumPosts] Remove user id check on destroy
* [ForumPosts] Don't create edit modaction on hide
* Assert correct amount of ModActions is created
Especially important when it previously created 2 instead of 1 for hiding
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 19:41:29 +01:00
Earlopain
8bec207580
[Bans] Add edit link to secondary links
2023-12-04 19:17:04 +01:00
Donovan Daniels
b330a5f579
[ModActions] Ban Update Mod Action ( #539 )
...
* [ModActions] Ban Update Mod Action
* Add back accidentally removed newline
* Log expiration for user_ban_update ModAction
The duration in days makes sense on creation but it falls apart when updating
For this to correctly work the duration needs to be persisted as well
which it isn't at the moment.
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 19:09:35 +01:00
Donovan Daniels
10e9304f17
[ForumPosts] Check for existence of topic & category ( #524 )
...
* [ForumPosts] Check for existence of topic & category
* [Tests] Add invalid topic category_id test
* Tweak how it is getting validated
If the category doesn't exist there's not point in doing anything further
* Move response assert before the other one
Should always be that way. If the response doesn't have the expected format
the assert will for sure fail and produce a confusing error message
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 18:03:11 +01:00
Earlopain
0958724683
Merge pull request #561 from mm12/ApproverRelatedLinks
...
Add links for approvers in Post/Related
2023-12-04 17:29:58 +01:00
Earlopain
018203230f
Merge pull request #564 from DonovanDMC/user-name-change-request-visibility
...
[UserNameChangeRequests] Allow moderators to view requestss
2023-12-04 17:21:49 +01:00
Earlopain
9e024ff792
[Docker] Bump node to latest LTS
2023-12-04 17:16:20 +01:00
Donovan Daniels
7ef19a8947
[UserNameChangeRequests] Allow moderators to view any request
2023-12-03 20:06:06 -06:00
Earlopain
50bfe9f3a3
[Posts] Add more colors to the mode menu
...
Choosen arbitrarily
2023-12-03 19:03:09 +01:00
Earlopain
c62f36e107
[JS/Gems] Bump packages/gems
2023-12-03 16:21:30 +01:00
Earlopain
b68fcd8148
[Admin] Fix editing email validation
2023-12-03 15:53:33 +01:00
Earlopain
6bb4c272cc
[Gems] Bump rubocop
2023-12-03 15:36:37 +01:00
Catt0s
07b959b1cd
Update _related.html.erb
2023-11-25 14:26:01 -06:00
Earlopain
3fe3c85cb6
[Forum] Avoid a bunch of queries for votable posts
...
There were always at least 3, or 4 if you didn't vote yourself yet.
Now it's always just 1.
2023-11-14 22:40:12 +01:00
Earlopain
22ad22da16
[Cleanup] Order user has_many relations
2023-11-14 21:20:33 +01:00
Earlopain
9b8344d943
[Wiki] Only validate title if it changed
...
See b08d5e6970 (commitcomment-132379723)
2023-11-13 16:55:40 +01:00
Earlopain
c00466a8cf
[Blacklist] Allow user:!123 syntax to filter users
...
Makes it consistent with the search syntax of the same form
2023-11-12 21:04:57 +01:00
Earlopain
57d5d58ad7
[Users] Inform about currently invalid names
...
Number only names especially interfere with the search syntax
2023-11-12 21:04:51 +01:00
Earlopain
b08d5e6970
[Wiki] Ensure titles follow tag name restrictions
2023-11-12 19:31:03 +01:00
Earlopain
edf67da445
[Blacklist] Fix filtering users with "-" in their name
...
The regex was too lax. There's no reason to not just match everything
2023-11-12 19:24:14 +01:00
Earlopain
b1a46cbfcf
[PostReplacements] Changes to approvals
...
* Get rid of the two approval buttons, just give a single one.
* Penalize automatically, unless the uploader is the replacer
* Hide the penalize state for non-approvers
2023-11-12 12:43:03 +01:00
Earlopain
f8098721ec
[Misc] Remove memoist gem dependency
...
The author has passed away and some functionality is broken with recent
ruby versions already. We only use a subset of it, so it's easy to replace.
Some places:
* Didn't even use it
* Used it but the method was already cached through memcached
* Just don't need it
Some places I question if it is needed but I'll just leave them there
since I don't want to benchmark
2023-11-08 22:21:11 +01:00
Earlopain
e4ce4f312f
[PostVersions] Remove code for handling nil posts
...
The post_id column is not nullable
2023-11-08 22:11:46 +01:00
Earlopain
3373dd51de
[PostVersions] Organize api only methods
...
Remove memoization, they are only called once
Remove the two with_fields methods as they are unused
2023-11-08 20:13:53 +01:00
