edshot99/eBooru
1
0
Fork 0
forked from e621ng/e621ng
Code Issues 11 Releases 1 Activity

[Forum] Avoid a bunch of queries for votable posts

Browse Source 
There were always at least 3, or 4 if you didn't vote yourself yet.
Now it's always just 1.
This commit is contained in:
Earlopain 2023-11-14 22:40:12 +01:00
parent 22ad22da16
commit 3fe3c85cb6
No known key found for this signature in database
GPG Key ID: 48860312319ADF61
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/views/forum_post_votes/_list.html.erb
View File

@ -3,14 +3,17 @@
# forum_post
%>
<% votes.by(CurrentUser.user.id).each do |vote| %>
<% own_vote = votes.find { |vote| vote.creator == CurrentUser.user } %>
<% other_votes = votes.reject { |vote| vote.creator == CurrentUser.user } %>
<% if own_vote %>
<%= render "forum_post_votes/vote", vote: own_vote, forum_post: forum_post %>
<% end %>
<% other_votes.each do |vote| %>
<%= render "forum_post_votes/vote", vote: vote, forum_post: forum_post %>
<% end %>
<% votes.excluding_user(CurrentUser.user.id).each do |vote| %>
<%= render "forum_post_votes/vote", vote: vote, forum_post: forum_post %>
<% end %>
<% if forum_post.tag_change_request&.is_pending? && !votes.by(CurrentUser.user.id).exists? %>
<%= render "forum_post_votes/add_vote", vote: votes.by(CurrentUser.user.id).first, forum_post: forum_post %>
<% if forum_post.tag_change_request&.is_pending? && !own_vote %>
<%= render "forum_post_votes/add_vote", forum_post: forum_post %>
<% end %>