Earlopain
bd87b4b29c
[PostVersions] Fix the obsolete class being applied to the link
2024-02-28 17:45:23 +01:00
Earlopain
17b99821e3
[Posts] Fix searches for huge ids erroring
...
This is because they can exceed Integer.MAX_VALUE on the opensearch side
2024-02-28 17:25:54 +01:00
Earlopain
7c03dddc56
[Pools] Fix exception on the ordering page
...
Broken through 0381653e80
2024-02-27 18:37:22 +01:00
Earlopain
a3a508c92c
[Takedowns] Fix vericode for frozen string literals
...
Will add some tests later
2024-02-27 17:32:34 +01:00
Earlopain
2c41373304
[Forum] Fix text for failed aliases/implications
2024-02-27 17:22:53 +01:00
Earlopain
45fd9d52a8
[RuboCop] Disallow logging in tests
...
Don't want these committed
2024-02-27 16:18:01 +01:00
Earlopain
4acddd5941
[Admin] Allow searching by exception class
2024-02-27 15:52:38 +01:00
Earlopain
2d7e507555
[Posts] Show an icon for non-matches urls
2024-02-27 15:48:52 +01:00
Earlopain
dbd5f8399b
[Artists] Add favicon to disabled urls
2024-02-26 19:14:49 +01:00
Earlopain
e1a2c8697e
[Posts] Improve source favicon display on mobile
...
Makes them somewhat fit to the font instead of being left at 16px
2024-02-26 19:09:45 +01:00
Earlopain
a816ee3b34
[BURs] Don't use tag_string_diff for tag nuking
...
This doesn't have the same issue as mass updates, but
it doesn't hurt to change this away from tag_string_diff as well
Aliases/Implications still do this but considering this has been the case
for 4 years now I don't believe this to be a problem
2024-02-26 16:56:20 +01:00
Earlopain
ca56ef3529
[BURs] Fix mass updates when the tag has been aliased away
...
Resolving aliases here is not great. Just mass update nothing in these cases, that's much safer.
Using tag_string_diff also wasn't a very bright idea, this too can result in both tags being removed
2024-02-26 16:48:25 +01:00
Earlopain
e0b52c13af
[PostVersions] Fix display of unchanged locked tags
...
2352bf54f6 (r139054663)
2024-02-26 12:48:58 +01:00
Cinder
e1e4b94a50
[Misc] External link favicons (now without a spritesheet) ( #610 )
...
* [Misc] Add favicons to some external links
* RuboCop changes from master
* Use packs for favicon images
This works better with caching.
If the file changes, the url changes
* Add favicons to an artists domain list
* Fix aliases
The lookup is done by strings, the keys were symbols
* Add old deviantart cdn alias
* Guard against links with that parse down to no host
http:twitter.com for example
* Tweak flow
* Add basic tests, fix some of what I probably broke
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2024-02-25 20:27:54 +01:00
Earlopain
fc7d84affd
[RuboCop] Enable Style/FrozenStringLiteralComment
...
This reduces allocations on the posts page by about 5%, from basic testing
2024-02-25 18:15:55 +01:00
Earlopain
bc06f8cea2
[Misc] Fix all remaining (hopefully) issues with frozen string literals
...
+"" is a bit of a copout, that could be done better but very easy to do in these more complicated cases
2024-02-25 16:41:35 +01:00
Earlopain
4975c1f717
[Wiki] Fix show for frozen string literals
...
Move the alias/implication list to a partial
2024-02-25 15:48:52 +01:00
Earlopain
9b59c860ff
[Cleanup] Add helper method for show_or_new_wiki_pages_path
2024-02-25 15:22:33 +01:00
Earlopain
5ac5b85150
[Posts] Move flag display to partial
2024-02-25 14:44:55 +01:00
Earlopain
19932adc7b
[Pools] Fix versions index for frozen string literals
2024-02-25 14:15:26 +01:00
Earlopain
5140bea658
[Pools] Simplify pool versions post changes
...
It unconditionally took values from the passed pool version
2024-02-25 14:14:30 +01:00
Earlopain
3f57ed5c6d
[Posts] Fix popular (and more) for frozen string literals
2024-02-25 13:41:58 +01:00
Earlopain
2352bf54f6
[PostVersions] Fix index for frozen string literals
2024-02-25 13:19:35 +01:00
Earlopain
930b4b905c
[Pools] Fix show/gallery for frozen string literals
...
Get rid of the presenters/post sets.
2024-02-25 11:38:55 +01:00
Earlopain
0381653e80
[Pools] Use paginate method for posts
2024-02-24 19:57:29 +01:00
Earlopain
b02b2353e7
[Pools] Always disallow duplicate posts
...
20 pools have this, 18 of those by accident. Series/collection distinction makes little sense for e6
2024-02-24 19:05:48 +01:00
Earlopain
d4083e1410
[Rubocop] Regenerate todo
...
1011 files inspected, 5302 offenses detected, 5067 offenses autocorrectable
2024-02-23 18:12:31 +01:00
Earlopain
5560829b0b
[Blacklist] Fix breakage on posts with a single tag containing only numbers
...
https://api.jquery.com/data/
> Every attempt is made to convert the attribute's string value to a JavaScript value (this includes booleans, numbers, objects, arrays, and null)
Why
2024-02-23 18:07:01 +01:00
Earlopain
5a139969dd
[Users] Move view-only code to helper
2024-02-23 17:23:25 +01:00
Earlopain
6c623496a2
[Users] Stop using has_mail bitflag
2024-02-23 17:18:22 +01:00
Earlopain
b042ce8dd0
[Users] Don't automatically add all boolean attributes to json
2024-02-23 17:11:40 +01:00
Earlopain
457c59c3c6
[Users] Mark unused bitprefs via underscore
2024-02-23 17:06:50 +01:00
Earlopain
56e849695b
[Cleanup] Remove readonly only
...
Since its introduction 3 years ago, it got used once I believe
I can't even say if this properly works anymore.
If something like that is actually desired in the future, it should just be a whitelist instead
2024-02-23 16:48:56 +01:00
Donovan Daniels
6b2b2cfc14
[DMails] Add marking as unread ( #620 )
...
* [DMails] Add marking as unread
* Tweak wording to be same as "Mark all as read", dmail capitalization
2024-02-23 16:39:59 +01:00
Earlopain
f59399ed67
[TagRelationships] Fix aliases/implications being left in queued state
...
This wasn't going through the error handler
2024-02-22 17:38:51 +01:00
Earlopain
9f796049a3
[Tests] Remove a rails bug workaround
...
Fixed sometime in the last 5 years
2024-02-22 16:44:19 +01:00
Earlopain
0bed93d8b6
[JS] Switch back to upstream vue-loader
...
rails/ujs > 7.1 contains the same thing that this fork fixes.
The amount of complains was low enough that I didn't bother fixing it
so there's no reason to continue to work around with vue-loader
2024-02-20 15:59:14 +01:00
Earlopain
066c7559c2
[Users] Add a not about the sensitivity of api keys
2024-02-19 20:18:56 +01:00
Earlopain
b18e921174
[Posts] Show a nicer error message on upload if redis is down
2024-02-19 16:32:58 +01:00
Earlopain
bab944ba95
[Users] Remove API limits column
...
Hardy useful, breaks user profiles if redis is down
2024-02-19 16:22:18 +01:00
Earlopain
674df5582e
[Gems] Bump dotenv to v3
2024-02-17 12:46:44 +01:00
Earlopain
c9fa546fb3
[Cleanup] Remove deny_transitives from tag alias approve!
...
Passing true would error because the error class doesn't exist.
BURs check this condition right before.
2024-02-17 12:12:39 +01:00
Earlopain
16de61c044
[Help] Sort entries by their displayed title
2024-02-15 20:11:44 +01:00
Earlopain
069a009dde
[Cleanup] Refactor help pages
...
The code wasn't very easy to follow. Uses the hip new normalized method from Rails 7.1
Adds some barebones tests
2024-02-15 20:05:36 +01:00
Earlopain
192fb2c1ed
[Discord] Fix counts for AIBUR report
2024-02-15 17:00:31 +01:00
Earlopain
43ade626e0
[AIBUR] Fix ModActions for implications and on alias reject
2024-02-15 16:58:47 +01:00
Earlopain
feb205204b
Merge pull request #596 from DonovanDMC/forum-post-vote-fix
...
[ForumPosts] Fix voting buttons
2024-02-14 19:46:09 +01:00
Earlopain
860084b68c
[Tests] Skip more flakiness
...
https://github.com/e621ng/e621ng/actions/runs/7905570941/job/21578501986
2024-02-14 19:23:10 +01:00
Donovan Daniels
0702b4fd19
[AIBUR] Link to forum post & show votes in show action ( #601 )
...
* [AIBUR] Link to forum post & show votes in `show` action
* Use strict locals, they are pretty cool
Also clarify the purpose of the new parameter
* Only show voting box when any votes are present
Looks weird otherwise
* Move the list into the partial
* Remove voting link on show page
* Uniform display on forum/show page
Display the votes inline, like on forum posts
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2024-02-14 19:17:54 +01:00
Earlopain
5759cc4103
Merge pull request #615 from Sindrake/forum-topic-background
...
[ForumTopics] Fix deleted topic row colors
2024-02-14 16:37:36 +01:00
