[Rubocop] Regenerate todo

1011 files inspected, 5302 offenses detected, 5067 offenses autocorrectable

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 20000`
-# on 2023-12-04 19:57:30 UTC using RuboCop version 1.58.0.
+# on 2024-02-23 17:07:51 UTC using RuboCop version 1.58.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -81,7 +81,7 @@ Layout/ElseAlignment:
     - 'app/models/bulk_update_request.rb'
     - 'app/models/tag_implication.rb'
 
-# Offense count: 10
+# Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, DefLikeMacros, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
 Layout/EmptyLineBetweenDefs:
@@ -90,10 +90,9 @@ Layout/EmptyLineBetweenDefs:
     - 'app/models/favorite.rb'
     - 'app/models/post.rb'
     - 'app/models/post_set.rb'
-    - 'app/models/post_version.rb'
     - 'app/models/user.rb'
 
-# Offense count: 11
+# Offense count: 9
 # This cop supports safe autocorrection (--autocorrect).
 Layout/EmptyLines:
   Exclude:
@@ -106,7 +105,6 @@ Layout/EmptyLines:
     - 'app/models/post_report_reason.rb'
     - 'app/models/tag_alias.rb'
     - 'config/environments/development.rb'
-    - 'config/environments/production.rb'
 
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
@@ -277,7 +275,7 @@ Layout/IndentationConsistency:
     - 'app/logical/apng_inspector.rb'
     - 'app/models/tag.rb'
 
-# Offense count: 10
+# Offense count: 9
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Width, AllowedPatterns.
 Layout/IndentationWidth:
@@ -285,7 +283,6 @@ Layout/IndentationWidth:
     - 'app/decorators/posts_decorator.rb'
     - 'app/helpers/post_flags_helper.rb'
     - 'app/logical/apng_inspector.rb'
-    - 'app/logical/moderator/ip_addr_search.rb'
     - 'app/models/bulk_update_request.rb'
     - 'app/models/pool_version.rb'
     - 'app/models/tag_implication.rb'
@@ -302,13 +299,11 @@ Layout/LeadingCommentSpace:
     - 'app/models/user.rb'
     - 'app/views/users/home.html.erb'
 
-# Offense count: 3
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Layout/LeadingEmptyLines:
   Exclude:
     - 'app/views/forum_post_votes/_add_vote.html.erb'
-    - 'app/views/forum_post_votes/_list.html.erb'
-    - 'app/views/forum_post_votes/_vote.html.erb'
 
 # Offense count: 40
 # This cop supports safe autocorrection (--autocorrect).
@@ -345,7 +340,7 @@ Layout/SpaceAfterColon:
   Exclude:
     - 'app/views/users/_statistics.html.erb'
 
-# Offense count: 29
+# Offense count: 28
 # This cop supports safe autocorrection (--autocorrect).
 Layout/SpaceAfterComma:
   Exclude:
@@ -359,7 +354,6 @@ Layout/SpaceAfterComma:
     - 'app/serializers/post_serializer.rb'
     - 'app/views/admin/danger_zone/index.html.erb'
     - 'app/views/mod_actions/_search.html.erb'
-    - 'app/views/moderator/post/queues/_quick_mod.html.erb'
     - 'app/views/post_events/_search.html.erb'
     - 'app/views/post_events/index.html.erb'
     - 'app/views/users/edit.html.erb'
@@ -422,12 +416,6 @@ Layout/SpaceBeforeBlockBraces:
     - 'app/views/moderator/ip_addrs/_ip_listing.html.erb'
     - 'test/unit/post_replacement_test.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/SpaceBeforeComma:
-  Exclude:
-    - 'app/views/moderator/post/queues/_quick_mod.html.erb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowForAlignment.
@@ -462,7 +450,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
   Exclude:
     - 'config/environments/production.rb'
 
-# Offense count: 312
+# Offense count: 310
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
@@ -491,7 +479,6 @@ Layout/SpaceInsideBlockBraces:
     - 'app/models/post.rb'
     - 'app/models/post_report_reason.rb'
     - 'app/models/post_set.rb'
-    - 'app/models/post_version.rb'
     - 'app/models/tag.rb'
     - 'app/models/tag_alias.rb'
     - 'app/models/tag_relationship.rb'
@@ -519,7 +506,7 @@ Layout/SpaceInsideBlockBraces:
     - 'test/unit/tag_test.rb'
     - 'test/unit/user_test.rb'
 
-# Offense count: 879
+# Offense count: 818
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
@@ -600,7 +587,6 @@ Layout/SpaceInsideHashLiteralBraces:
     - 'app/views/moderator/ip_addrs/_ip_listing.html.erb'
     - 'app/views/moderator/ip_addrs/_ip_listing.json.erb'
     - 'app/views/moderator/ip_addrs/_user_listing.erb'
-    - 'app/views/moderator/post/queues/_quick_mod.html.erb'
     - 'app/views/note_versions/_revert_listing.html.erb'
     - 'app/views/note_versions/_standard_listing.html.erb'
     - 'app/views/notes/index.html.erb'
@@ -680,12 +666,11 @@ Layout/TrailingEmptyLines:
   Exclude:
     - 'app/controllers/user_reverts_controller.rb'
 
-# Offense count: 15
+# Offense count: 14
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
-    - 'app/controllers/post_sets_controller.rb'
     - 'app/logical/sources/strategies/base.rb'
     - 'app/logical/storage_manager/match.rb'
     - 'app/models/destroyed_post.rb'
@@ -713,11 +698,10 @@ Lint/AssignmentInCondition:
   Exclude:
     - 'app/logical/set_diff.rb'
 
-# Offense count: 16
+# Offense count: 15
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
 Lint/DuplicateBranch:
   Exclude:
-    - 'app/controllers/application_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'app/helpers/note_versions_helper.rb'
     - 'app/logical/elastic_post_query_builder.rb'
@@ -761,7 +745,7 @@ Lint/IneffectiveAccessModifier:
     - 'app/logical/email_link_validator.rb'
     - 'app/logical/vote_manager.rb'
 
-# Offense count: 23
+# Offense count: 22
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: standard_error, runtime_error
@@ -807,13 +791,6 @@ Lint/MissingSuper:
     - 'app/presenters/tag_set_presenter.rb'
     - 'app/presenters/upload_presenter.rb'
 
-# Offense count: 6
-# Configuration parameters: AllowedMethods, AllowedPatterns.
-Lint/NestedMethodDefinition:
-  Exclude:
-    - 'app/logical/moderator/ip_addr_search.rb'
-    - 'app/models/post_version.rb'
-
 # Offense count: 2
 Lint/NoReturnInBeginEndBlocks:
   Exclude:
@@ -876,7 +853,7 @@ Lint/SuppressedException:
     - 'app/models/forum_subscription.rb'
     - 'app/models/tag.rb'
 
-# Offense count: 81
+# Offense count: 71
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, consistent
@@ -892,8 +869,6 @@ Lint/SymbolConversion:
     - 'app/views/favorites/index.html.erb'
     - 'app/views/forum_post_votes/_add_vote.html.erb'
     - 'app/views/forum_post_votes/_vote.html.erb'
-    - 'app/views/help/index.html.erb'
-    - 'app/views/moderator/post/queues/_quick_mod.html.erb'
     - 'app/views/note_versions/_revert_listing.html.erb'
     - 'app/views/pool_versions/_revert_listing.html.erb'
     - 'app/views/post_replacements/index.html.erb'
@@ -1049,13 +1024,6 @@ Naming/ConstantName:
   Exclude:
     - 'app/models/mod_action.rb'
 
-# Offense count: 1
-# Configuration parameters: ForbiddenDelimiters.
-# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
-Naming/HeredocDelimiterNaming:
-  Exclude:
-    - 'test/unit/user_feedback_test.rb'
-
 # Offense count: 5
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
@@ -1173,7 +1141,7 @@ Rails/ActionOrder:
     - 'app/controllers/users_controller.rb'
     - 'app/controllers/wiki_pages_controller.rb'
 
-# Offense count: 11
+# Offense count: 10
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
@@ -1185,7 +1153,6 @@ Rails/ActiveRecordCallbacksOrder:
     - 'app/models/news_update.rb'
     - 'app/models/pool.rb'
     - 'app/models/post_set.rb'
-    - 'app/models/tag_implication.rb'
     - 'app/models/ticket.rb'
     - 'app/models/user.rb'
     - 'app/models/wiki_page.rb'
@@ -1278,13 +1245,12 @@ Rails/EnvironmentComparison:
   Exclude:
     - 'app/models/application_record.rb'
 
-# Offense count: 7
+# Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: slashes, arguments
 Rails/FilePath:
   Exclude:
-    - 'app/logical/danbooru_image_resizer.rb'
     - 'app/logical/storage_manager.rb'
     - 'config/danbooru_default_config.rb'
     - 'test/test_helper.rb'
@@ -1316,14 +1282,12 @@ Rails/IndexBy:
     - 'app/models/pool.rb'
     - 'app/presenters/tag_set_presenter.rb'
 
-# Offense count: 3
+# Offense count: 1
 # Configuration parameters: Include.
 # Include: app/controllers/**/*.rb, app/mailers/**/*.rb
 Rails/LexicallyScopedActionFilter:
   Exclude:
-    - 'app/controllers/posts_controller.rb'
     - 'app/controllers/tickets_controller.rb'
-    - 'app/controllers/upload_whitelists_controller.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
@@ -1462,11 +1426,10 @@ Rails/TimeZoneAssignment:
   Exclude:
     - 'test/unit/post_test.rb'
 
-# Offense count: 10
+# Offense count: 9
 # Configuration parameters: TransactionMethods.
 Rails/TransactionExitStatement:
   Exclude:
-    - 'app/controllers/tickets_controller.rb'
     - 'app/logical/favorite_manager.rb'
     - 'app/logical/vote_manager.rb'
     - 'app/models/post.rb'
@@ -1670,12 +1633,6 @@ Style/FormatString:
   Exclude:
     - 'app/presenters/tag_set_presenter.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/GlobalStdStream:
-  Exclude:
-    - 'config/environments/production.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -1706,7 +1663,7 @@ Style/HashLikeCase:
     - 'app/models/post.rb'
     - 'config/initializers/core_extensions.rb'
 
-# Offense count: 1144
+# Offense count: 1134
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
@@ -1718,7 +1675,6 @@ Style/HashSyntax:
     - 'app/controllers/artists_controller.rb'
     - 'app/controllers/bans_controller.rb'
     - 'app/controllers/comments_controller.rb'
-    - 'app/controllers/dmails_controller.rb'
     - 'app/controllers/favorites_controller.rb'
     - 'app/controllers/forum_posts_controller.rb'
     - 'app/controllers/forum_topics_controller.rb'
@@ -1804,7 +1760,6 @@ Style/HashSyntax:
     - 'app/views/comments/_quick_search.html.erb'
     - 'app/views/comments/partials/index/_list.html.erb'
     - 'app/views/comments/partials/show/_comment.html.erb'
-    - 'app/views/dmails/_form.html.erb'
     - 'app/views/dmails/_quick_search.html.erb'
     - 'app/views/dmails/index.html.erb'
     - 'app/views/dmails/new.html.erb'
@@ -2035,13 +1990,12 @@ Style/MissingRespondToMissing:
     - 'app/logical/current_user.rb'
     - 'config/danbooru_default_config.rb'
 
-# Offense count: 3
+# Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle, Autocorrect.
 # SupportedStyles: module_function, extend_self, forbidden
 Style/ModuleFunction:
   Exclude:
-    - 'app/logical/danbooru_image_resizer.rb'
     - 'app/logical/post_thumbnailer.rb'
     - 'app/logical/upload_service/utils.rb'
 
@@ -2050,13 +2004,12 @@ Style/MultilineBlockChain:
   Exclude:
     - 'app/models/wiki_page.rb'
 
-# Offense count: 21
+# Offense count: 16
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
   Exclude:
-    - 'app/logical/danbooru_image_resizer.rb'
     - 'app/logical/downloads/file.rb'
     - 'app/logical/pbkdf2.rb'
     - 'app/logical/storage_manager.rb'
@@ -2066,7 +2019,6 @@ Style/MutableConstant:
     - 'app/models/mod_action.rb'
     - 'app/models/post.rb'
     - 'app/models/post_replacement.rb'
-    - 'app/models/user.rb'
     - 'test/unit/storage_manager_test.rb'
 
 # Offense count: 27
@@ -2182,7 +2134,7 @@ Style/ParallelAssignment:
     - 'app/models/tag_alias.rb'
     - 'app/models/tag_implication.rb'
 
-# Offense count: 65
+# Offense count: 64
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -2222,7 +2174,7 @@ Style/PreferredHashMethods:
   Exclude:
     - 'app/helpers/posts_helper.rb'
 
-# Offense count: 56
+# Offense count: 54
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, AllowedCompactTypes.
 # SupportedStyles: compact, exploded
@@ -2250,7 +2202,6 @@ Style/RaiseArgs:
     - 'app/models/note.rb'
     - 'app/models/pool.rb'
     - 'app/models/post.rb'
-    - 'app/models/tag_alias.rb'
     - 'app/models/wiki_page.rb'
 
 # Offense count: 10
@@ -2285,12 +2236,11 @@ Style/RedundantBegin:
     - 'config/initializers/cache_store.rb'
     - 'db/fixes/101_migrate_mod_actions.rb'
 
-# Offense count: 2
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantConstantBase:
   Exclude:
     - 'config.ru'
-    - 'config/environments/production.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
@@ -2305,13 +2255,12 @@ Style/RedundantFetchBlock:
   Exclude:
     - 'config/puma.rb'
 
-# Offense count: 4
+# Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/RedundantInterpolation:
   Exclude:
     - 'app/decorators/post_event_decorator.rb'
     - 'app/helpers/users_helper.rb'
-    - 'app/views/help/index.html.erb'
     - 'db/fixes/102_generate_missing_post_version_fields.rb'
 
 # Offense count: 4
@@ -2408,7 +2357,7 @@ Style/RedundantStringEscape:
   Exclude:
     - 'test/unit/user_test.rb'
 
-# Offense count: 26
+# Offense count: 25
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
 # SupportedStyles: slashes, percent_r, mixed
@@ -2420,7 +2369,6 @@ Style/RegexpLiteral:
     - 'app/logical/tag_name_validator.rb'
     - 'app/models/artist.rb'
     - 'app/models/artist_url.rb'
-    - 'app/models/upload_whitelist.rb'
     - 'app/views/takedowns/index.html.erb'
     - 'app/views/takedowns/show.html.erb'
 
@@ -2548,7 +2496,7 @@ Style/StringConcatenation:
     - 'test/unit/bulk_update_importer_importer_test.rb'
     - 'test/unit/bulk_update_request_test.rb'
 
-# Offense count: 771
+# Offense count: 756
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
@@ -2618,7 +2566,6 @@ Style/StringLiterals:
     - 'app/models/post_report_reason.rb'
     - 'app/models/post_set.rb'
     - 'app/models/post_set_maintainer.rb'
-    - 'app/models/post_version.rb'
     - 'app/models/tag_alias.rb'
     - 'app/models/takedown.rb'
     - 'app/models/ticket.rb'
@@ -2641,7 +2588,6 @@ Style/StringLiterals:
     - 'app/views/help/_form.html.erb'
     - 'app/views/moderator/ip_addrs/_ip_listing.html.erb'
     - 'app/views/moderator/ip_addrs/_user_listing.erb'
-    - 'app/views/moderator/post/queues/_quick_mod.html.erb'
     - 'app/views/note_versions/_revert_listing.html.erb'
     - 'app/views/pool_versions/_revert_listing.html.erb'
     - 'app/views/post_replacements/index.html.erb'
@@ -2663,7 +2609,6 @@ Style/StringLiterals:
     - 'app/views/takedowns/index.html.erb'
     - 'app/views/takedowns/new.html.erb'
     - 'app/views/tickets/index.html.erb'
-    - 'app/views/tickets/new.html.erb'
     - 'app/views/tickets/show.html.erb'
     - 'app/views/uploads/new.html.erb'
     - 'app/views/users/home.html.erb'
@@ -2756,7 +2701,6 @@ Style/StringLiterals:
     - 'test/unit/post_replacement_test.rb'
     - 'test/unit/post_sets/favorites_test.rb'
     - 'test/unit/post_sets/pool_test.rb'
-    - 'test/unit/post_sets/post_test.rb'
     - 'test/unit/post_test.rb'
     - 'test/unit/post_version_test.rb'
     - 'test/unit/post_vote_test.rb'
@@ -2803,7 +2747,7 @@ Style/StructInheritance:
     - 'app/logical/moderator/dashboard/queries/upload.rb'
     - 'app/logical/moderator/dashboard/queries/wiki_page.rb'
 
-# Offense count: 110
+# Offense count: 106
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, MinSize.
 # SupportedStyles: percent, brackets
@@ -2817,7 +2761,6 @@ Style/SymbolArray:
     - 'app/controllers/comment_votes_controller.rb'
     - 'app/controllers/comments_controller.rb'
     - 'app/controllers/deleted_posts_controller.rb'
-    - 'app/controllers/dmails_controller.rb'
     - 'app/controllers/forum_categories_controller.rb'
     - 'app/controllers/forum_posts_controller.rb'
     - 'app/controllers/forum_topics_controller.rb'
@@ -2828,12 +2771,10 @@ Style/SymbolArray:
     - 'app/controllers/post_replacements_controller.rb'
     - 'app/controllers/post_sets_controller.rb'
     - 'app/controllers/post_votes_controller.rb'
-    - 'app/controllers/posts_controller.rb'
     - 'app/controllers/tag_aliases_controller.rb'
     - 'app/controllers/tag_corrections_controller.rb'
     - 'app/controllers/tag_implications_controller.rb'
     - 'app/controllers/tags_controller.rb'
-    - 'app/controllers/tickets_controller.rb'
     - 'app/controllers/upload_whitelists_controller.rb'
     - 'app/controllers/uploads_controller.rb'
     - 'app/controllers/user_feedbacks_controller.rb'
@@ -2976,7 +2917,7 @@ Style/WhileUntilModifier:
   Exclude:
     - 'app/logical/user_deletion.rb'
 
-# Offense count: 79
+# Offense count: 78
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, MinSize, WordRegex.
 # SupportedStyles: percent, brackets
@@ -2999,7 +2940,6 @@ Style/WordArray:
     - 'app/views/post_flags/_search.html.erb'
     - 'app/views/post_replacements/_search.html.erb'
     - 'app/views/post_sets/maintainers.html.erb'
-    - 'app/views/post_versions/_search.html.erb'
     - 'app/views/tag_relationships/_search.html.erb'
     - 'app/views/tags/edit.html.erb'
     - 'app/views/takedowns/_editor.html.erb'