Everything is already scoped to the approver. Switching to the creator doesn't make much sense here.
In addition, this sent the success message 5 times because the rename happened at the wrong place
This doesn't have the same issue as mass updates, but
it doesn't hurt to change this away from tag_string_diff as well
Aliases/Implications still do this but considering this has been the case
for 4 years now I don't believe this to be a problem
Resolving aliases here is not great. Just mass update nothing in these cases, that's much safer.
Using tag_string_diff also wasn't a very bright idea, this too can result in both tags being removed
* [Misc] Add favicons to some external links
* RuboCop changes from master
* Use packs for favicon images
This works better with caching.
If the file changes, the url changes
* Add favicons to an artists domain list
* Fix aliases
The lookup is done by strings, the keys were symbols
* Add old deviantart cdn alias
* Guard against links with that parse down to no host
http:twitter.com for example
* Tweak flow
* Add basic tests, fix some of what I probably broke
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
* [Tests] Add hide & delete modaction tests to comments and forum posts
* [ForumPosts] Remove user id check on destroy
* [ForumPosts] Don't create edit modaction on hide
* Assert correct amount of ModActions is created
Especially important when it previously created 2 instead of 1 for hiding
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
* [ForumPosts] Check for existence of topic & category
* [Tests] Add invalid topic category_id test
* Tweak how it is getting validated
If the category doesn't exist there's not point in doing anything further
* Move response assert before the other one
Should always be that way. If the response doesn't have the expected format
the assert will for sure fail and produce a confusing error message
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
Some sites serve urls that redirect by default. This would append the
"You are being redirected" html to the file being downloaded after that
and subsequently report that text/html is not a valid format
Run the following commands to import data into OpenSearch:
Post.document_store.create_index!
PostVersion.document_store.create_index!
Post.document_store.import
PostVersion.document_store.import
* Add opensearch client
* Add url param to force use opensearch
* Switch import method over to opensearch
* Index to opensearch as well
* Add option to gradually roll out os
* Index os with separate queue
* Move os post creation to job as well
* Exclusively use the OpenSearch client
* Stop enqueuing OsIndexUpdateJob
* Remove remaining elasticsearch code
Bump faraday since v2 is no longer blocked
