Commit Graph

11 Commits

Author SHA1 Message Date
Earlopain
a0a0d8db13
[Docker] Replace solargraph with ruby-lsp
It just works.
Requires a bit of a workaround for the .rubocop.yml env setup currently in use but thats alright.
The companion ruby-lsp-rails doesn't do much right now but I imagine that to become quite powerful in the future.
2024-01-11 23:16:03 +01:00
Earlopain
51ae8e9708
[Rubocop] Disable Rails/WhereNotWithMultipleConditions
The reasoning for this rule seems to be that behaviour changed in 6.1
Not sure how that is relevant for apps that aren't in the process of migrating
2023-08-04 20:45:44 +02:00
Earlopain
7adac7b250
[Gems] Bump rubocop/regenerate todo
987 files inspected, 6509 offenses detected, 6224 offenses autocorrectable
2023-08-01 19:32:24 +02:00
Earlopain
024f195858
[Rubocop] Default to running with todo
These are only interesting in solargraph
2023-07-07 13:39:06 +02:00
Earlopain
26ced45f67
[Rubocop] Enforce consistent lambda notation 2023-03-17 19:52:41 +01:00
Earlopain
94efeddf04
[JS/Gems] Bump packages/gems
Also regenerates rubocop-todo
2023-03-10 10:23:58 +01:00
Earlopain
996f1c30c1
[Tests] Remove/Disable remaining failing tests 2023-02-25 00:15:08 +01:00
Earlopain
3553987b6d
[Gems] Add rubocop-erb 2023-02-23 13:22:26 +01:00
Earlopain
f00e781b3b
[CI] Run rubocop and add rubocop-todo
There's no point in building the Dockerfile just for rubocop, but
doing it this way allows for easy integration of a test action in the future.
2023-02-22 21:59:43 +01:00
Earlopain
179a948cf2
[Docker] Add solargraph to the image, and a few more things
* Allow modifying .env without git complainging about changes to commit
* Require COMPOSE_PROFILE=solargraph for solargraph to be included in the image
* Set required vscode settings for solargraph to correctly work in docker
* Clean up .solargraph.yml. All these removed values are the default
* Disable autocomplete in the rails console
* Add a compose service to run rubocop

* Upddate rubocop config

Added some, removed some, ordered alphabetically.
Before: 844 files inspected, 6871 offenses detected, 6095 offenses autocorrectable
After: 844 files inspected, 8024 offenses detected, 7538 offenses autocorrectable
Most of the new offences are because of Style/StringLiterals (1312)
2022-10-18 23:35:18 +02:00
Earlopain
6910369e2a
[Misc] Add rubocop and solargraph config
A bunch of rules are disabled or tweaked for the current style
2021-07-05 13:21:49 +02:00