Earlopain
58f9a18915
[Tests] Improve/Add tests around network requests
2024-04-27 13:57:51 +02:00
Earlopain
75ea36b700
[Cleanup] Remove unused size method from file class
2024-04-26 15:58:18 +02:00
Earlopain
b058077cf0
[Misc] Add a method that returns the base url for network requests
...
This makes it easier to stub in tests.
Also add a method to the iqdb proxy to say if it is enabled or not and use it everywhere.
2024-04-26 15:57:56 +02:00
Earlopain
988b607c57
Merge pull request #638 from DonovanDMC/note-previews-posts
...
[Notes] Remove note previews, replace with dtext previews
2024-04-21 19:40:09 +02:00
Earlopain
53d67da88d
[TagImplications] Ignore tag count limit on approve
...
This will apply to all automated changes, though I think only implications really need it.
2024-04-21 19:09:52 +02:00
Donovan Daniels
0f8ec1de53
[Notes] Remove note previews, replace with dtext previews
2024-04-18 05:31:25 -05:00
Earlopain
3229106431
[WikiPages] Fix exception on show_or_new without arg
...
This now uses `titled` which didn't handle nil
2024-04-12 15:11:45 +02:00
Earlopain
d2d6e83537
[Misc] Fix an exception during exception logging
...
This broke after the upgrade to rails 7.1 because of https://github.com/rails/rails/pull/46535
2024-04-11 19:10:57 +02:00
Earlopain
0b47770c49
[Prod] Add Datadog
...
Let's see how this one works out. Cute logo
2024-04-09 20:16:29 +02:00
Earlopain
40ff649250
Merge pull request #631 from DonovanDMC/wikipages-normalize-title
...
[WikiPages] normalize title in show_or_new & edit
2024-04-09 19:56:16 +02:00
Earlopain
7cd026d18d
[Cleanup] Return a single wiki from WikiPage.titled
2024-04-09 19:50:33 +02:00
Donovan Daniels
b2c4fffdb5
[Tests] Fix post expunge note/post update count test
2024-04-06 08:12:01 -05:00
Earlopain
d9a055d058
[Users] Redirect to name changes when name is invalid
...
The more or less unintrusive message has been there for a few months now.
Start forcing a name change when accessing through a browser, ignore api for now
2024-04-05 17:33:09 +02:00
Earlopain
e3fdc5d61b
[Pools] Fix discrepancy between index page count and actual page count
...
One was using `user.per_page`, the other config.posts_per_page. Consolidate this
logic to `paginate_posts` to make it more obvious what's going on.
2024-04-04 22:52:49 +02:00
Earlopain
2e140a5607
[Posts] Use addressable for source parsing
...
Fixes no icons for links with square brackets
2024-03-18 18:59:19 +01:00
Earlopain
aeb2076b80
[TagAliases] Fix locked artist preventing approval
...
Everything is already scoped to the approver. Switching to the creator doesn't make much sense here.
In addition, this sent the success message 5 times because the rename happened at the wrong place
2024-03-17 19:16:01 +01:00
Earlopain
979e2e4d5f
[Tests] Add basic tests for takedowns
...
Would have ccaught the breakage from frozen string literals
2024-03-17 19:16:01 +01:00
Earlopain
1da52e3d0d
[TagRelations] Fix rejecting in certain cases
...
Rejection should always be possible
Previously this skipped validations, now it doesn't
2024-03-03 20:35:28 +01:00
Earlopain
853790272b
[Posts] Allow excluding multiple ids in search
2024-03-03 20:04:02 +01:00
Earlopain
17b99821e3
[Posts] Fix searches for huge ids erroring
...
This is because they can exceed Integer.MAX_VALUE on the opensearch side
2024-02-28 17:25:54 +01:00
Earlopain
7c03dddc56
[Pools] Fix exception on the ordering page
...
Broken through 0381653e80
2024-02-27 18:37:22 +01:00
Earlopain
45fd9d52a8
[RuboCop] Disallow logging in tests
...
Don't want these committed
2024-02-27 16:18:01 +01:00
Earlopain
2d7e507555
[Posts] Show an icon for non-matches urls
2024-02-27 15:48:52 +01:00
Earlopain
a816ee3b34
[BURs] Don't use tag_string_diff for tag nuking
...
This doesn't have the same issue as mass updates, but
it doesn't hurt to change this away from tag_string_diff as well
Aliases/Implications still do this but considering this has been the case
for 4 years now I don't believe this to be a problem
2024-02-26 16:56:20 +01:00
Earlopain
ca56ef3529
[BURs] Fix mass updates when the tag has been aliased away
...
Resolving aliases here is not great. Just mass update nothing in these cases, that's much safer.
Using tag_string_diff also wasn't a very bright idea, this too can result in both tags being removed
2024-02-26 16:48:25 +01:00
Earlopain
e0b52c13af
[PostVersions] Fix display of unchanged locked tags
...
2352bf54f6 (r139054663)
2024-02-26 12:48:58 +01:00
Cinder
e1e4b94a50
[Misc] External link favicons (now without a spritesheet) ( #610 )
...
* [Misc] Add favicons to some external links
* RuboCop changes from master
* Use packs for favicon images
This works better with caching.
If the file changes, the url changes
* Add favicons to an artists domain list
* Fix aliases
The lookup is done by strings, the keys were symbols
* Add old deviantart cdn alias
* Guard against links with that parse down to no host
http:twitter.com for example
* Tweak flow
* Add basic tests, fix some of what I probably broke
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2024-02-25 20:27:54 +01:00
Earlopain
fc7d84affd
[RuboCop] Enable Style/FrozenStringLiteralComment
...
This reduces allocations on the posts page by about 5%, from basic testing
2024-02-25 18:15:55 +01:00
Earlopain
930b4b905c
[Pools] Fix show/gallery for frozen string literals
...
Get rid of the presenters/post sets.
2024-02-25 11:38:55 +01:00
Earlopain
6c623496a2
[Users] Stop using has_mail bitflag
2024-02-23 17:18:22 +01:00
Donovan Daniels
6b2b2cfc14
[DMails] Add marking as unread ( #620 )
...
* [DMails] Add marking as unread
* Tweak wording to be same as "Mark all as read", dmail capitalization
2024-02-23 16:39:59 +01:00
Earlopain
f59399ed67
[TagRelationships] Fix aliases/implications being left in queued state
...
This wasn't going through the error handler
2024-02-22 17:38:51 +01:00
Earlopain
9f796049a3
[Tests] Remove a rails bug workaround
...
Fixed sometime in the last 5 years
2024-02-22 16:44:19 +01:00
Earlopain
069a009dde
[Cleanup] Refactor help pages
...
The code wasn't very easy to follow. Uses the hip new normalized method from Rails 7.1
Adds some barebones tests
2024-02-15 20:05:36 +01:00
Earlopain
43ade626e0
[AIBUR] Fix ModActions for implications and on alias reject
2024-02-15 16:58:47 +01:00
Earlopain
860084b68c
[Tests] Skip more flakiness
...
https://github.com/e621ng/e621ng/actions/runs/7905570941/job/21578501986
2024-02-14 19:23:10 +01:00
Earlopain
8112e57329
[Tests] Skip flaky pagination test on CI
2024-02-04 16:51:13 +01:00
Earlopain
b00f7145c0
[Rails] Enable some new framework defaults
...
Others require a deploy first (like caching stuff) or need more thought (like serialization changes)
2024-01-27 13:49:57 +01:00
Earlopain
0fad5d5659
[Comments] Fix exception when searching by poster_id
...
Caused by 2c832dc633
2024-01-25 18:47:26 +01:00
Donovan Daniels
8f8feac8aa
[Artists] Show error when changing notes with locked wiki page ( #580 )
...
* [Artists] Show error when changing notes with locked wiki page
* [Tests] Add tests for editing artists with locked wiki pages
2024-01-14 21:01:01 +01:00
Earlopain
1fed677a45
[Tickets] Make response mandatory
2024-01-14 12:36:37 +01:00
Donovan Daniels
c11ad6b874
[UserFeedback] Add Updater
2024-01-04 14:31:54 -06:00
Earlopain
acae76a907
[Dmails] Change http verb from post to put for marking as read
...
That's what mark_all_as_read should have been from the start and
what I should have put mark_as_read to as well
2023-12-18 20:03:38 +01:00
Earlopain
18f8f99730
[Dmails] Don't mark as read on show for API requests
2023-12-17 20:08:44 +01:00
Earlopain
f477141c63
[Dmails] Add route to mark single dmail read
2023-12-17 20:06:10 +01:00
Earlopain
16014a438f
[Dmails] Partially enable api
...
Basically everything except sending
2023-12-17 19:55:13 +01:00
Donovan Daniels
74007f2e30
[Blips] Add Updater & Tests/Move modactions to callbacks ( #540 )
...
* [Blips] Add `updater_id` & update notice
* [Blips] Move modaction generation logic into rails callbacks
* [Tests] Add blip tests
* Move update notice to right place
* Assert amount of difference
* Rebase oopsie
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 20:56:14 +01:00
Donovan Daniels
6eaf435002
Bring ForumPost ModAction trigger in line with Comments ( #542 )
...
* [Tests] Add hide & delete modaction tests to comments and forum posts
* [ForumPosts] Remove user id check on destroy
* [ForumPosts] Don't create edit modaction on hide
* Assert correct amount of ModActions is created
Especially important when it previously created 2 instead of 1 for hiding
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 19:41:29 +01:00
Donovan Daniels
10e9304f17
[ForumPosts] Check for existence of topic & category ( #524 )
...
* [ForumPosts] Check for existence of topic & category
* [Tests] Add invalid topic category_id test
* Tweak how it is getting validated
If the category doesn't exist there's not point in doing anything further
* Move response assert before the other one
Should always be that way. If the response doesn't have the expected format
the assert will for sure fail and produce a confusing error message
---------
Co-authored-by: Earlopain <14981592+Earlopain@users.noreply.github.com>
2023-12-04 18:03:11 +01:00
Earlopain
b68fcd8148
[Admin] Fix editing email validation
2023-12-03 15:53:33 +01:00
