[RuboCop] Enable Style/FrozenStringLiteralComment

This reduces allocations on the posts page by about 5%, from basic testing

.rubocop.yml

@@ -118,9 +118,6 @@ Style/EmptyMethod:
 Style/FloatDivision:
   Enabled: false
 
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 Style/GuardClause:
   Enabled: false
 

Gemfile

@@ -1,4 +1,6 @@
-source 'https://rubygems.org/'
+# frozen_string_literal: true
+
+source "https://rubygems.org/"
 
 gem "dotenv", require: "dotenv/load"
 

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

app/concerns/user_warnable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module UserWarnable
   extend ActiveSupport::Concern
 

app/controllers/admin/danger_zone_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class DangerZoneController < ApplicationController
     before_action :admin_only

app/controllers/admin/dashboards_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class DashboardsController < ApplicationController
     before_action :admin_only

app/controllers/admin/exceptions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class ExceptionsController < ApplicationController
     before_action :admin_only

app/controllers/admin/reowner_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class ReownerController < ApplicationController
     before_action :is_bd_staff_only

app/controllers/admin/staff_notes_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class StaffNotesController < ApplicationController
     before_action :can_view_staff_notes_only

app/controllers/admin/stuck_dnp_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class StuckDnpController < ApplicationController
     before_action :admin_only

app/controllers/admin/users_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class UsersController < ApplicationController
     before_action :admin_only

app/controllers/application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   class APIThrottled < Exception; end
   class FeatureUnavailable < StandardError; end

app/controllers/artist_urls_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ArtistUrlsController < ApplicationController
   respond_to :json, :html
   before_action :member_only, except: [:index]

app/controllers/artist_versions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ArtistVersionsController < ApplicationController
   respond_to :html, :json
 

app/controllers/artists_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ArtistsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, :except => [:index, :show, :show_or_new]

app/controllers/bans_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BansController < ApplicationController
   before_action :moderator_only, :except => [:show, :index]
   respond_to :html

app/controllers/blips_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BlipsController < ApplicationController
   class BlipTooOld < Exception ; end
   respond_to :html, :json

app/controllers/bulk_update_requests_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BulkUpdateRequestsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, except: [:index, :show]

app/controllers/comment_votes_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CommentVotesController < ApplicationController
   respond_to :json
   respond_to :html, only: [:index]

app/controllers/comments_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CommentsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, except: %i[index search show for_post]

app/controllers/concerns/deferred_posts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DeferredPosts
   extend ActiveSupport::Concern
 

app/controllers/deleted_posts_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DeletedPostsController < ApplicationController
   respond_to :html
 

app/controllers/dmails_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DmailsController < ApplicationController
   respond_to :html
   respond_to :json, except: %i[new create]

app/controllers/dtext_previews_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DtextPreviewsController < ApplicationController
   def create
     body = params[:body] || ""

app/controllers/edit_histories_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EditHistoriesController < ApplicationController
   respond_to :html
   before_action :moderator_only

app/controllers/email_blacklists_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EmailBlacklistsController < ApplicationController
   respond_to :html, :json, :js
   before_action :admin_only

app/controllers/emails_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EmailsController < ApplicationController
   respond_to :html
 

app/controllers/favorites_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class FavoritesController < ApplicationController
   before_action :member_only, except: [:index]
   respond_to :html, :json

app/controllers/forum_categories_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ForumCategoriesController < ApplicationController
   respond_to :html
   before_action :admin_only

app/controllers/forum_post_votes_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ForumPostVotesController < ApplicationController
   respond_to :json
   before_action :member_only

app/controllers/forum_posts_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ForumPostsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, :except => [:index, :show, :search]

app/controllers/forum_topics_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ForumTopicsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, :except => [:index, :show]

app/controllers/help_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class HelpController < ApplicationController
   respond_to :html, :json
   helper :wiki_pages

app/controllers/ip_bans_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IpBansController < ApplicationController
   respond_to :html, :json
   before_action :admin_only

app/controllers/iqdb_queries_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IqdbQueriesController < ApplicationController
   respond_to :html, :json
   # Show uses POST because it needs a file parameter. This would be GET otherwise.

app/controllers/maintenance/user/api_keys_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class ApiKeysController < ApplicationController

app/controllers/maintenance/user/count_fixes_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class CountFixesController < ApplicationController

app/controllers/maintenance/user/deletions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class DeletionsController < ApplicationController

app/controllers/maintenance/user/dmail_filters_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class DmailFiltersController < ApplicationController

app/controllers/maintenance/user/email_changes_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class EmailChangesController < ApplicationController

app/controllers/maintenance/user/email_notifications_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class EmailNotificationsController < ApplicationController

app/controllers/maintenance/user/login_reminders_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class LoginRemindersController < ApplicationController

app/controllers/maintenance/user/password_resets_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class PasswordResetsController < ApplicationController

app/controllers/maintenance/user/passwords_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Maintenance
   module User
     class PasswordsController < ApplicationController

app/controllers/mascots_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MascotsController < ApplicationController
   respond_to :html, :json
   before_action :admin_only, except: [:index]

app/controllers/meta_searches_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MetaSearchesController < ApplicationController
   def tags
     @meta_search = MetaSearches::Tag.new(params)

app/controllers/mod_actions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ModActionsController < ApplicationController
   respond_to :html, :json
 

app/controllers/moderator/dashboards_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moderator
   class DashboardsController < ApplicationController
     before_action :janitor_only

app/controllers/moderator/ip_addrs_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moderator
   class IpAddrsController < ApplicationController
     before_action :admin_only

app/controllers/moderator/post/approvals_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moderator
   module Post
     class ApprovalsController < ApplicationController

app/controllers/moderator/post/disapprovals_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moderator
   module Post
     class DisapprovalsController < ApplicationController

app/controllers/moderator/post/posts_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moderator
   module Post
     class PostsController < ApplicationController

app/controllers/news_updates_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NewsUpdatesController < ApplicationController
   before_action :admin_only, except: [:index]
   respond_to :html

app/controllers/note_previews_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NotePreviewsController < ApplicationController
   respond_to :json
 

app/controllers/note_versions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NoteVersionsController < ApplicationController
   respond_to :html, :json
 

app/controllers/notes_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NotesController < ApplicationController
   respond_to :html, :json, :js
   before_action :member_only, :except => [:index, :show, :search]

app/controllers/pool_elements_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PoolElementsController < ApplicationController
   respond_to :html, :json, :js
   before_action :member_only

app/controllers/pool_orders_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PoolOrdersController < ApplicationController
   respond_to :html, :json, :js
   before_action :member_only

app/controllers/pool_versions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PoolVersionsController < ApplicationController
   respond_to :html, :json
   before_action :member_only

app/controllers/pools_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PoolsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, :except => [:index, :show, :gallery]

app/controllers/popular_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PopularController < ApplicationController
   respond_to :html, :json
 

app/controllers/post_approvals_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostApprovalsController < ApplicationController
   respond_to :html, :json
 

app/controllers/post_events_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostEventsController < ApplicationController
   respond_to :html, :json
 

app/controllers/post_favorites_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostFavoritesController < ApplicationController
   respond_to :html
 

app/controllers/post_flags_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostFlagsController < ApplicationController
   before_action :member_only, :except => [:index, :show]
   before_action :janitor_only, only: [:destroy]

app/controllers/post_replacements_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostReplacementsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, only: [:create, :new]

app/controllers/post_report_reasons_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostReportReasonsController < ApplicationController
   respond_to :html
   before_action :admin_only

app/controllers/post_set_maintainers_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostSetMaintainersController < ApplicationController
   respond_to :html
   respond_to :js, except: [:index]

app/controllers/post_sets_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostSetsController < ApplicationController
   respond_to :html, :json
   before_action :member_only, except: [:index, :show]

app/controllers/post_versions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostVersionsController < ApplicationController
   before_action :member_only, except: [:index]
   respond_to :html, :json

app/controllers/post_votes_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostVotesController < ApplicationController
   before_action :member_only
   before_action :moderator_only, only: [:index, :lock]

app/controllers/posts_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostsController < ApplicationController
   before_action :member_only, except: %i[show show_seq index random]
   before_action :admin_only, only: [:update_iqdb]

app/controllers/related_tags_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class RelatedTagsController < ApplicationController
   respond_to :json, :html, only: [:show]
   respond_to :json, only: [:bulk]

app/controllers/sessions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SessionsController < ApplicationController
   def new
     @user = User.new

app/controllers/static_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class StaticController < ApplicationController
   def privacy
     @page = WikiPage.find_by(title: "e621:privacy_policy")

app/controllers/stats_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class StatsController < ApplicationController
   respond_to :html
 

app/controllers/tag_alias_requests_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagAliasRequestsController < ApplicationController
   before_action :member_only
 

app/controllers/tag_aliases_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagAliasesController < ApplicationController
   before_action :admin_only, except: [:index, :show, :destroy]
   respond_to :html, :json, :js

app/controllers/tag_corrections_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagCorrectionsController < ApplicationController
   respond_to :html, :json
   before_action :janitor_only, only: [:new, :create]

app/controllers/tag_implication_requests_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagImplicationRequestsController < ApplicationController
   before_action :member_only
 

app/controllers/tag_implications_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagImplicationsController < ApplicationController
   before_action :admin_only, except: [:index, :show, :destroy]
   respond_to :html, :json, :js

app/controllers/tag_type_versions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagTypeVersionsController < ApplicationController
   respond_to :html, :json
 

app/controllers/tags_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagsController < ApplicationController
   before_action :member_only, :only => [:edit, :update, :preview]
   respond_to :html, :json

app/controllers/takedowns_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TakedownsController < ApplicationController
   respond_to :html, :json
   before_action :can_handle_takedowns_only, only: %i[update edit destroy add_by_ids add_by_tags count_matching_posts remove_by_ids]

app/controllers/tickets_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TicketsController < ApplicationController
   respond_to :html
   before_action :member_only, except: [:index]

app/controllers/upload_whitelists_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class UploadWhitelistsController < ApplicationController
   respond_to :html, :json, :js
   before_action :admin_only, only: [:new, :create, :edit, :update, :destroy]

app/controllers/uploads_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class UploadsController < ApplicationController
   before_action :member_only
   before_action :janitor_only, only: [:index, :show]

app/controllers/user_feedbacks_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class UserFeedbacksController < ApplicationController
   before_action :moderator_only, :only => [:new, :edit, :create, :update, :destroy]
   respond_to :html, :json

app/controllers/user_name_change_requests_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class UserNameChangeRequestsController < ApplicationController
   before_action :member_only, only: [:new, :create, :show]
   before_action :moderator_only, only: :index

app/controllers/user_reverts_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class UserRevertsController < ApplicationController
   before_action :moderator_only
 

app/controllers/users_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class UsersController < ApplicationController
   respond_to :html, :json
   skip_before_action :api_check

app/controllers/wiki_page_versions_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class WikiPageVersionsController < ApplicationController
   respond_to :html, :json
 

app/controllers/wiki_pages_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class WikiPagesController < ApplicationController
   respond_to :html, :json, :js
   before_action :member_only, :except => [:index, :search, :show, :show_or_new]

app/decorators/application_decorator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationDecorator < Draper::Decorator
   # NOTE: This is required for correct serialization of member models, otherwise hidden_attributes is ignored!!!
   delegate :as_json, :serializable_hash

app/decorators/mod_action_decorator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ModActionDecorator < ApplicationDecorator
   def self.collection_decorator_class
     PaginatedDecorator

app/decorators/paginated_decorator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PaginatedDecorator < Draper::CollectionDecorator
   delegate :current_page, :total_pages, :is_first_page?, :is_last_page?, :pagination_mode, :max_numbered_pages, :records, :total_count
 end

app/decorators/post_event_decorator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostEventDecorator < ApplicationDecorator
   def self.collection_decorator_class
     PaginatedDecorator

app/decorators/posts_decorator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostsDecorator < ApplicationDecorator
   def self.collection_decorator_class
     PaginatedDecorator

app/helpers/admin/users_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin::UsersHelper
   def user_level_select(object, field)
     options = Danbooru.config.levels.map { |x,y| [x,y] }

app/helpers/application_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
   def disable_mobile_mode?
     if CurrentUser.user.present? && CurrentUser.is_member?