edshot99/eBooru
1
0
Fork 0
forked from e621ng/e621ng
Code Issues 11 Releases 1 Activity

[Rubocop] Regenerate todo

Browse Source 
1012 files inspected, 5003 offenses detected, 4797 offenses autocorrectable
This commit is contained in:
Earlopain 2024-04-05 14:11:13 +02:00
parent 64259a0b4e
commit e397370498
No known key found for this signature in database
GPG Key ID: 48860312319ADF61
1 changed files with 30 additions and 192 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

222
.rubocop_todo.yml
View File

@ -1,6 +1,6 @@
# This configuration was generated by # This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 20000` # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 20000`
# on 2024-02-23 17:07:51 UTC using RuboCop version 1.58.0. # on 2024-04-05 12:02:56 UTC using RuboCop version 1.58.0.
# The point is for the user to remove these configuration records # The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base. # one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new # Note that changes in the inspected code, or installation of new
@ -116,7 +116,7 @@ Layout/EmptyLinesAroundAccessModifier:
- 'app/controllers/forum_topics_controller.rb' - 'app/controllers/forum_topics_controller.rb'
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
# Offense count: 12 # Offense count: 9
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowAliasSyntax, AllowedMethods. # Configuration parameters: AllowAliasSyntax, AllowedMethods.
# AllowedMethods: alias_method, public, protected, private # AllowedMethods: alias_method, public, protected, private
@ -129,9 +129,6 @@ Layout/EmptyLinesAroundAttributeAccessor:
- 'app/models/upload.rb' - 'app/models/upload.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
- 'app/presenters/post_presenter.rb' - 'app/presenters/post_presenter.rb'
- 'app/presenters/post_set_presenters/pool.rb'
- 'app/presenters/post_set_presenters/pool_gallery.rb'
- 'app/presenters/post_set_presenters/popular.rb'
- 'app/presenters/post_set_presenters/post.rb' - 'app/presenters/post_set_presenters/post.rb'
- 'app/presenters/upload_presenter.rb' - 'app/presenters/upload_presenter.rb'
@ -275,16 +272,14 @@ Layout/IndentationConsistency:
- 'app/logical/apng_inspector.rb' - 'app/logical/apng_inspector.rb'
- 'app/models/tag.rb' - 'app/models/tag.rb'
# Offense count: 9 # Offense count: 7
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Width, AllowedPatterns. # Configuration parameters: Width, AllowedPatterns.
Layout/IndentationWidth: Layout/IndentationWidth:
Exclude: Exclude:
- 'app/decorators/posts_decorator.rb' - 'app/decorators/posts_decorator.rb'
- 'app/helpers/post_flags_helper.rb'
- 'app/logical/apng_inspector.rb' - 'app/logical/apng_inspector.rb'
- 'app/models/bulk_update_request.rb' - 'app/models/bulk_update_request.rb'
- 'app/models/pool_version.rb'
- 'app/models/tag_implication.rb' - 'app/models/tag_implication.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
- 'test/unit/forum_topic_test.rb' - 'test/unit/forum_topic_test.rb'
@ -400,7 +395,7 @@ Layout/SpaceAroundOperators:
- 'test/unit/post_test.rb' - 'test/unit/post_test.rb'
- 'test/unit/related_tag_calculator_test.rb' - 'test/unit/related_tag_calculator_test.rb'
# Offense count: 39 # Offense count: 38
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space # SupportedStyles: space, no_space
@ -408,7 +403,6 @@ Layout/SpaceAroundOperators:
Layout/SpaceBeforeBlockBraces: Layout/SpaceBeforeBlockBraces:
Exclude: Exclude:
- 'app/controllers/posts_controller.rb' - 'app/controllers/posts_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/logical/tags_preview.rb' - 'app/logical/tags_preview.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/models/tag_relationship.rb' - 'app/models/tag_relationship.rb'
@ -450,7 +444,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
Exclude: Exclude:
- 'config/environments/production.rb' - 'config/environments/production.rb'
# Offense count: 310 # Offense count: 294
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space # SupportedStyles: space, no_space
@ -461,8 +455,6 @@ Layout/SpaceInsideBlockBraces:
- 'app/controllers/post_flags_controller.rb' - 'app/controllers/post_flags_controller.rb'
- 'app/controllers/post_sets_controller.rb' - 'app/controllers/post_sets_controller.rb'
- 'app/controllers/posts_controller.rb' - 'app/controllers/posts_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/tags_helper.rb'
- 'app/indexes/post_index.rb' - 'app/indexes/post_index.rb'
- 'app/logical/post_sets/base.rb' - 'app/logical/post_sets/base.rb'
- 'app/logical/related_tag_calculator.rb' - 'app/logical/related_tag_calculator.rb'
@ -475,10 +467,8 @@ Layout/SpaceInsideBlockBraces:
- 'app/models/forum_topic.rb' - 'app/models/forum_topic.rb'
- 'app/models/note.rb' - 'app/models/note.rb'
- 'app/models/note_version.rb' - 'app/models/note_version.rb'
- 'app/models/pool.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/models/post_report_reason.rb' - 'app/models/post_report_reason.rb'
- 'app/models/post_set.rb'
- 'app/models/tag.rb' - 'app/models/tag.rb'
- 'app/models/tag_alias.rb' - 'app/models/tag_alias.rb'
- 'app/models/tag_relationship.rb' - 'app/models/tag_relationship.rb'
@ -506,7 +496,7 @@ Layout/SpaceInsideBlockBraces:
- 'test/unit/tag_test.rb' - 'test/unit/tag_test.rb'
- 'test/unit/user_test.rb' - 'test/unit/user_test.rb'
# Offense count: 818 # Offense count: 810
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space, compact # SupportedStyles: space, no_space, compact
@ -535,11 +525,9 @@ Layout/SpaceInsideHashLiteralBraces:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/helpers/dmails_helper.rb' - 'app/helpers/dmails_helper.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/helpers/wiki_pages_helper.rb'
- 'app/logical/elastic_post_query_builder.rb' - 'app/logical/elastic_post_query_builder.rb'
- 'app/logical/moderator/ip_addr_search.rb' - 'app/logical/moderator/ip_addr_search.rb'
- 'app/logical/post_thumbnailer.rb' - 'app/logical/post_thumbnailer.rb'
- 'app/logical/related_tag_calculator.rb'
- 'app/logical/session_creator.rb' - 'app/logical/session_creator.rb'
- 'app/logical/session_loader.rb' - 'app/logical/session_loader.rb'
- 'app/logical/sources/strategies/pixiv_slim.rb' - 'app/logical/sources/strategies/pixiv_slim.rb'
@ -554,7 +542,6 @@ Layout/SpaceInsideHashLiteralBraces:
- 'app/models/post_replacement.rb' - 'app/models/post_replacement.rb'
- 'app/models/post_set.rb' - 'app/models/post_set.rb'
- 'app/models/post_version.rb' - 'app/models/post_version.rb'
- 'app/models/tag.rb'
- 'app/models/tag_alias.rb' - 'app/models/tag_alias.rb'
- 'app/models/tag_implication.rb' - 'app/models/tag_implication.rb'
- 'app/models/ticket.rb' - 'app/models/ticket.rb'
@ -593,7 +580,6 @@ Layout/SpaceInsideHashLiteralBraces:
- 'app/views/pool_orders/edit.html.erb' - 'app/views/pool_orders/edit.html.erb'
- 'app/views/pool_versions/_revert_listing.html.erb' - 'app/views/pool_versions/_revert_listing.html.erb'
- 'app/views/pool_versions/_standard_listing.html.erb' - 'app/views/pool_versions/_standard_listing.html.erb'
- 'app/views/pools/gallery.html.erb'
- 'app/views/pools/index.html.erb' - 'app/views/pools/index.html.erb'
- 'app/views/post_replacements/index.html.erb' - 'app/views/post_replacements/index.html.erb'
- 'app/views/post_report_reasons/index.html.erb' - 'app/views/post_report_reasons/index.html.erb'
@ -683,12 +669,10 @@ Lint/AmbiguousOperator:
- 'app/views/layouts/blank.html.erb' - 'app/views/layouts/blank.html.erb'
- 'app/views/layouts/default.html.erb' - 'app/views/layouts/default.html.erb'
# Offense count: 12 # Offense count: 2
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Lint/AmbiguousOperatorPrecedence: Lint/AmbiguousOperatorPrecedence:
Exclude: Exclude:
- 'app/helpers/post_flags_helper.rb'
- 'app/helpers/post_versions_helper.rb'
- 'app/logical/user_throttle.rb' - 'app/logical/user_throttle.rb'
# Offense count: 1 # Offense count: 1
@ -698,12 +682,11 @@ Lint/AssignmentInCondition:
Exclude: Exclude:
- 'app/logical/set_diff.rb' - 'app/logical/set_diff.rb'
# Offense count: 15 # Offense count: 14
# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
Lint/DuplicateBranch: Lint/DuplicateBranch:
Exclude: Exclude:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/helpers/note_versions_helper.rb'
- 'app/logical/elastic_post_query_builder.rb' - 'app/logical/elastic_post_query_builder.rb'
- 'app/logical/sources/alternates/pixiv.rb' - 'app/logical/sources/alternates/pixiv.rb'
- 'app/logical/storage_manager.rb' - 'app/logical/storage_manager.rb'
@ -771,22 +754,14 @@ Lint/InheritException:
- 'app/models/user_vote.rb' - 'app/models/user_vote.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
# Offense count: 15 # Offense count: 7
# Configuration parameters: AllowedParentClasses. # Configuration parameters: AllowedParentClasses.
Lint/MissingSuper: Lint/MissingSuper:
Exclude: Exclude:
- 'app/logical/post_sets/favorites.rb'
- 'app/logical/post_sets/pool.rb'
- 'app/logical/post_sets/pool_gallery.rb'
- 'app/logical/post_sets/popular.rb'
- 'app/logical/post_sets/post.rb'
- 'app/logical/storage_manager/hybrid.rb' - 'app/logical/storage_manager/hybrid.rb'
- 'app/logical/storage_manager/match.rb' - 'app/logical/storage_manager/match.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
- 'app/presenters/post_presenter.rb' - 'app/presenters/post_presenter.rb'
- 'app/presenters/post_set_presenters/pool.rb'
- 'app/presenters/post_set_presenters/pool_gallery.rb'
- 'app/presenters/post_set_presenters/popular.rb'
- 'app/presenters/post_set_presenters/post.rb' - 'app/presenters/post_set_presenters/post.rb'
- 'app/presenters/tag_set_presenter.rb' - 'app/presenters/tag_set_presenter.rb'
- 'app/presenters/upload_presenter.rb' - 'app/presenters/upload_presenter.rb'
@ -853,14 +828,13 @@ Lint/SuppressedException:
- 'app/models/forum_subscription.rb' - 'app/models/forum_subscription.rb'
- 'app/models/tag.rb' - 'app/models/tag.rb'
# Offense count: 71 # Offense count: 67
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, consistent # SupportedStyles: strict, consistent
Lint/SymbolConversion: Lint/SymbolConversion:
Exclude: Exclude:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/presenters/post_set_presenters/popular.rb'
- 'app/views/artist_versions/_standard_listing.html.erb' - 'app/views/artist_versions/_standard_listing.html.erb'
- 'app/views/artists/_quick_search.html.erb' - 'app/views/artists/_quick_search.html.erb'
- 'app/views/blips/partials/show/_blip.html.erb' - 'app/views/blips/partials/show/_blip.html.erb'
@ -917,18 +891,16 @@ Lint/UnusedBlockArgument:
- 'test/factories/bulk_update_request.rb' - 'test/factories/bulk_update_request.rb'
- 'test/unit/storage_manager_test.rb' - 'test/unit/storage_manager_test.rb'
# Offense count: 23 # Offense count: 20
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
Lint/UnusedMethodArgument: Lint/UnusedMethodArgument:
Exclude: Exclude:
- 'app/controllers/posts_controller.rb' - 'app/controllers/posts_controller.rb'
- 'app/helpers/pool_versions_helper.rb'
- 'app/indexes/post_version_index.rb' - 'app/indexes/post_version_index.rb'
- 'app/logical/maintenance.rb' - 'app/logical/maintenance.rb'
- 'app/logical/storage_manager.rb' - 'app/logical/storage_manager.rb'
- 'app/models/application_record.rb' - 'app/models/application_record.rb'
- 'app/models/pool_version.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/models/ticket.rb' - 'app/models/ticket.rb'
- 'app/presenters/post_presenter.rb' - 'app/presenters/post_presenter.rb'
@ -1072,7 +1044,7 @@ Naming/VariableName:
Exclude: Exclude:
- 'app/logical/pbkdf2.rb' - 'app/logical/pbkdf2.rb'
# Offense count: 28 # Offense count: 25
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns. # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
# SupportedStyles: snake_case, normalcase, non_integer # SupportedStyles: snake_case, normalcase, non_integer
# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64 # AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
@ -1088,7 +1060,6 @@ Naming/VariableNumber:
- 'test/functional/wiki_pages_controller_test.rb' - 'test/functional/wiki_pages_controller_test.rb'
- 'test/unit/post_disapproval_test.rb' - 'test/unit/post_disapproval_test.rb'
- 'test/unit/post_sets/favorites_test.rb' - 'test/unit/post_sets/favorites_test.rb'
- 'test/unit/post_sets/pool_test.rb'
- 'test/unit/post_sets/post_test.rb' - 'test/unit/post_sets/post_test.rb'
- 'test/unit/related_tag_query_test.rb' - 'test/unit/related_tag_query_test.rb'
@ -1209,7 +1180,7 @@ Rails/Delegate:
- 'app/logical/sources/strategies/base.rb' - 'app/logical/sources/strategies/base.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
# Offense count: 49 # Offense count: 48
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers. # Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers.
# Whitelist: find_by_sql, find_by_token_for # Whitelist: find_by_sql, find_by_token_for
@ -1232,7 +1203,6 @@ Rails/DynamicFindBy:
- 'app/models/tag_type_version.rb' - 'app/models/tag_type_version.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
- 'app/presenters/post_set_presenters/pool_gallery.rb'
- 'test/functional/artists_controller_test.rb' - 'test/functional/artists_controller_test.rb'
- 'test/unit/post_test.rb' - 'test/unit/post_test.rb'
- 'test/unit/related_tag_calculator_test.rb' - 'test/unit/related_tag_calculator_test.rb'
@ -1274,12 +1244,11 @@ Rails/HttpStatus:
Exclude: Exclude:
- 'app/controllers/posts_controller.rb' - 'app/controllers/posts_controller.rb'
# Offense count: 3 # Offense count: 2
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Rails/IndexBy: Rails/IndexBy:
Exclude: Exclude:
- 'app/logical/moderator/ip_addr_search.rb' - 'app/logical/moderator/ip_addr_search.rb'
- 'app/models/pool.rb'
- 'app/presenters/tag_set_presenter.rb' - 'app/presenters/tag_set_presenter.rb'
# Offense count: 1 # Offense count: 1
@ -1309,24 +1278,16 @@ Rails/Output:
Exclude: Exclude:
- 'app/indexes/post_version_index.rb' - 'app/indexes/post_version_index.rb'
# Offense count: 75 # Offense count: 58
Rails/OutputSafety: Rails/OutputSafety:
Exclude: Exclude:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/helpers/artists_helper.rb' - 'app/helpers/artists_helper.rb'
- 'app/helpers/note_versions_helper.rb'
- 'app/helpers/pool_versions_helper.rb'
- 'app/helpers/post_flags_helper.rb'
- 'app/helpers/post_versions_helper.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/helpers/tags_helper.rb' - 'app/helpers/tags_helper.rb'
- 'app/helpers/text_helper.rb' - 'app/helpers/text_helper.rb'
- 'app/helpers/wiki_pages_helper.rb' - 'app/helpers/wiki_pages_helper.rb'
- 'app/javascript/src/javascripts/autocomplete.js.erb' - 'app/javascript/src/javascripts/autocomplete.js.erb'
- 'app/presenters/post_set_presenters/base.rb'
- 'app/presenters/post_set_presenters/pool.rb'
- 'app/presenters/post_set_presenters/pool_gallery.rb'
- 'app/presenters/post_set_presenters/popular.rb'
- 'app/presenters/tag_set_presenter.rb' - 'app/presenters/tag_set_presenter.rb'
- 'app/presenters/user_presenter.rb' - 'app/presenters/user_presenter.rb'
- 'app/views/ads/_leaderboard.html.erb' - 'app/views/ads/_leaderboard.html.erb'
@ -1459,7 +1420,7 @@ Rails/WhereExists:
- 'test/unit/post_test.rb' - 'test/unit/post_test.rb'
- 'test/unit/tag_implication_test.rb' - 'test/unit/tag_implication_test.rb'
# Offense count: 13 # Offense count: 12
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Rails/WhereNot: Rails/WhereNot:
Exclude: Exclude:
@ -1584,7 +1545,7 @@ Style/EachWithObject:
Exclude: Exclude:
- 'app/controllers/concerns/deferred_posts.rb' - 'app/controllers/concerns/deferred_posts.rb'
# Offense count: 8 # Offense count: 6
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, AllowComments. # Configuration parameters: EnforcedStyle, AllowComments.
# SupportedStyles: empty, nil, both # SupportedStyles: empty, nil, both
@ -1596,7 +1557,6 @@ Style/EmptyElse:
- 'app/models/tag_alias.rb' - 'app/models/tag_alias.rb'
- 'app/models/tag_implication.rb' - 'app/models/tag_implication.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
- 'app/presenters/post_set_presenters/popular.rb'
# Offense count: 1 # Offense count: 1
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
@ -1604,12 +1564,6 @@ Style/EmptyLiteral:
Exclude: Exclude:
- 'app/models/tag_implication.rb' - 'app/models/tag_implication.rb'
# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Style/Encoding:
Exclude:
- 'test/unit/pool_test.rb'
# Offense count: 3 # Offense count: 3
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Style/ExpandPathArguments: Style/ExpandPathArguments:
@ -1641,13 +1595,6 @@ Style/HashAsLastArrayItem:
Exclude: Exclude:
- 'app/controllers/post_versions_controller.rb' - 'app/controllers/post_versions_controller.rb'
# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowSplatArgument.
Style/HashConversion:
Exclude:
- 'app/models/pool.rb'
# Offense count: 1 # Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowedReceivers. # Configuration parameters: AllowedReceivers.
@ -1663,7 +1610,7 @@ Style/HashLikeCase:
- 'app/models/post.rb' - 'app/models/post.rb'
- 'config/initializers/core_extensions.rb' - 'config/initializers/core_extensions.rb'
# Offense count: 1134 # Offense count: 1084
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
@ -1700,15 +1647,11 @@ Style/HashSyntax:
- 'app/controllers/user_feedbacks_controller.rb' - 'app/controllers/user_feedbacks_controller.rb'
- 'app/controllers/wiki_pages_controller.rb' - 'app/controllers/wiki_pages_controller.rb'
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/helpers/post_versions_helper.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/helpers/tags_helper.rb'
- 'app/helpers/wiki_pages_helper.rb'
- 'app/logical/bulk_update_request_importer.rb' - 'app/logical/bulk_update_request_importer.rb'
- 'app/logical/favorite_manager.rb' - 'app/logical/favorite_manager.rb'
- 'app/logical/forum_updater.rb' - 'app/logical/forum_updater.rb'
- 'app/logical/post_thumbnailer.rb' - 'app/logical/post_thumbnailer.rb'
- 'app/logical/related_tag_calculator.rb'
- 'app/logical/user_deletion.rb' - 'app/logical/user_deletion.rb'
- 'app/mailers/maintenance/user/email_confirmation_mailer.rb' - 'app/mailers/maintenance/user/email_confirmation_mailer.rb'
- 'app/mailers/maintenance/user/login_reminder_mailer.rb' - 'app/mailers/maintenance/user/login_reminder_mailer.rb'
@ -1738,9 +1681,6 @@ Style/HashSyntax:
- 'app/models/user.rb' - 'app/models/user.rb'
- 'app/models/user_name_change_request.rb' - 'app/models/user_name_change_request.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
- 'app/presenters/post_set_presenters/pool.rb'
- 'app/presenters/post_set_presenters/pool_gallery.rb'
- 'app/presenters/post_set_presenters/popular.rb'
- 'app/views/admin/dashboards/show.html.erb' - 'app/views/admin/dashboards/show.html.erb'
- 'app/views/admin/reowner/new.html.erb' - 'app/views/admin/reowner/new.html.erb'
- 'app/views/artists/_form.html.erb' - 'app/views/artists/_form.html.erb'
@ -1815,7 +1755,6 @@ Style/HashSyntax:
- 'app/views/pools/edit.html.erb' - 'app/views/pools/edit.html.erb'
- 'app/views/pools/index.html.erb' - 'app/views/pools/index.html.erb'
- 'app/views/pools/new.html.erb' - 'app/views/pools/new.html.erb'
- 'app/views/pools/show.html.erb'
- 'app/views/post_favorites/index.html.erb' - 'app/views/post_favorites/index.html.erb'
- 'app/views/post_versions/index.html.erb' - 'app/views/post_versions/index.html.erb'
- 'app/views/posts/_blank.html.erb' - 'app/views/posts/_blank.html.erb'
@ -1835,10 +1774,8 @@ Style/HashSyntax:
- 'app/views/static/_footer.html.erb' - 'app/views/static/_footer.html.erb'
- 'app/views/static/access_denied.html.erb' - 'app/views/static/access_denied.html.erb'
- 'app/views/tag_aliases/edit.html.erb' - 'app/views/tag_aliases/edit.html.erb'
- 'app/views/tag_aliases/show.html.erb'
- 'app/views/tag_corrections/new.html.erb' - 'app/views/tag_corrections/new.html.erb'
- 'app/views/tag_implications/edit.html.erb' - 'app/views/tag_implications/edit.html.erb'
- 'app/views/tag_implications/show.html.erb'
- 'app/views/tags/_quick_search.html.erb' - 'app/views/tags/_quick_search.html.erb'
- 'app/views/tags/edit.html.erb' - 'app/views/tags/edit.html.erb'
- 'app/views/tags/index.html.erb' - 'app/views/tags/index.html.erb'
@ -1909,13 +1846,12 @@ Style/HashTransformValues:
Exclude: Exclude:
- 'app/indexes/post_index.rb' - 'app/indexes/post_index.rb'
# Offense count: 6 # Offense count: 4
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
Style/IdenticalConditionalBranches: Style/IdenticalConditionalBranches:
Exclude: Exclude:
- 'app/controllers/users_controller.rb' - 'app/controllers/users_controller.rb'
- 'app/models/forum_post.rb' - 'app/models/forum_post.rb'
- 'app/models/pool_version.rb'
# Offense count: 2 # Offense count: 2
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
@ -2004,14 +1940,13 @@ Style/MultilineBlockChain:
Exclude: Exclude:
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
# Offense count: 16 # Offense count: 14
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: literals, strict # SupportedStyles: literals, strict
Style/MutableConstant: Style/MutableConstant:
Exclude: Exclude:
- 'app/logical/downloads/file.rb' - 'app/logical/downloads/file.rb'
- 'app/logical/pbkdf2.rb'
- 'app/logical/storage_manager.rb' - 'app/logical/storage_manager.rb'
- 'app/logical/upload_service/utils.rb' - 'app/logical/upload_service/utils.rb'
- 'app/models/artist.rb' - 'app/models/artist.rb'
@ -2057,7 +1992,7 @@ Style/NegatedIfElseCondition:
- 'app/views/tickets/show.html.erb' - 'app/views/tickets/show.html.erb'
- 'app/views/uploads/new.html.erb' - 'app/views/uploads/new.html.erb'
# Offense count: 5 # Offense count: 4
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, MinBodyLength. # Configuration parameters: EnforcedStyle, MinBodyLength.
# SupportedStyles: skip_modifier_ifs, always # SupportedStyles: skip_modifier_ifs, always
@ -2066,7 +2001,6 @@ Style/Next:
- 'app/logical/apng_inspector.rb' - 'app/logical/apng_inspector.rb'
- 'app/logical/set_diff.rb' - 'app/logical/set_diff.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
- 'app/presenters/post_set_presenters/pool_gallery.rb'
- 'app/presenters/tag_set_presenter.rb' - 'app/presenters/tag_set_presenter.rb'
# Offense count: 5 # Offense count: 5
@ -2204,7 +2138,7 @@ Style/RaiseArgs:
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
# Offense count: 10 # Offense count: 9
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Methods. # Configuration parameters: Methods.
Style/RedundantArgument: Style/RedundantArgument:
@ -2212,7 +2146,6 @@ Style/RedundantArgument:
- 'app/decorators/posts_decorator.rb' - 'app/decorators/posts_decorator.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/indexes/post_index.rb' - 'app/indexes/post_index.rb'
- 'app/logical/post_sets/pool.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/models/tag_alias.rb' - 'app/models/tag_alias.rb'
- 'app/presenters/post_presenter.rb' - 'app/presenters/post_presenter.rb'
@ -2248,7 +2181,7 @@ Style/RedundantException:
Exclude: Exclude:
- 'app/logical/upload_service/utils.rb' - 'app/logical/upload_service/utils.rb'
# Offense count: 2 # Offense count: 3
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: SafeForConstants. # Configuration parameters: SafeForConstants.
Style/RedundantFetchBlock: Style/RedundantFetchBlock:
@ -2263,11 +2196,10 @@ Style/RedundantInterpolation:
- 'app/helpers/users_helper.rb' - 'app/helpers/users_helper.rb'
- 'db/fixes/102_generate_missing_post_version_fields.rb' - 'db/fixes/102_generate_missing_post_version_fields.rb'
# Offense count: 4 # Offense count: 3
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Style/RedundantParentheses: Style/RedundantParentheses:
Exclude: Exclude:
- 'app/models/forum_post.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/views/takedowns/show.html.erb' - 'app/views/takedowns/show.html.erb'
@ -2284,13 +2216,12 @@ Style/RedundantRegexpEscape:
- 'app/models/pool.rb' - 'app/models/pool.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
# Offense count: 61 # Offense count: 58
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowMultipleReturnValues. # Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn: Style/RedundantReturn:
Exclude: Exclude:
- 'app/helpers/forum_topics_helper.rb' - 'app/helpers/forum_topics_helper.rb'
- 'app/helpers/pool_versions_helper.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/logical/apng_inspector.rb' - 'app/logical/apng_inspector.rb'
- 'app/logical/bulk_update_request_importer.rb' - 'app/logical/bulk_update_request_importer.rb'
@ -2397,7 +2328,7 @@ Style/RescueStandardError:
- 'app/models/post_flag.rb' - 'app/models/post_flag.rb'
- 'db/fixes/101_migrate_mod_actions.rb' - 'db/fixes/101_migrate_mod_actions.rb'
# Offense count: 24 # Offense count: 22
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength. # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
# AllowedMethods: present?, blank?, presence, try, try! # AllowedMethods: present?, blank?, presence, try, try!
@ -2409,9 +2340,7 @@ Style/SafeNavigation:
- 'app/logical/admin_route_constraint.rb' - 'app/logical/admin_route_constraint.rb'
- 'app/models/ban.rb' - 'app/models/ban.rb'
- 'app/models/forum_topic.rb' - 'app/models/forum_topic.rb'
- 'app/models/pool.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/models/post_set.rb'
- 'app/models/post_version.rb' - 'app/models/post_version.rb'
- 'app/models/tag.rb' - 'app/models/tag.rb'
- 'app/models/tag_alias.rb' - 'app/models/tag_alias.rb'
@ -2470,7 +2399,7 @@ Style/SpecialGlobalVars:
- 'app/helpers/forum_topics_helper.rb' - 'app/helpers/forum_topics_helper.rb'
- 'app/logical/sources/alternates/pixiv.rb' - 'app/logical/sources/alternates/pixiv.rb'
# Offense count: 33 # Offense count: 20
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Mode. # Configuration parameters: Mode.
Style/StringConcatenation: Style/StringConcatenation:
@ -2478,10 +2407,6 @@ Style/StringConcatenation:
- 'app/controllers/comments_controller.rb' - 'app/controllers/comments_controller.rb'
- 'app/controllers/posts_controller.rb' - 'app/controllers/posts_controller.rb'
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/helpers/note_versions_helper.rb'
- 'app/helpers/pool_versions_helper.rb'
- 'app/helpers/post_flags_helper.rb'
- 'app/helpers/post_versions_helper.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/helpers/title_helper.rb' - 'app/helpers/title_helper.rb'
- 'app/logical/storage_manager/local.rb' - 'app/logical/storage_manager/local.rb'
@ -2496,7 +2421,7 @@ Style/StringConcatenation:
- 'test/unit/bulk_update_importer_importer_test.rb' - 'test/unit/bulk_update_importer_importer_test.rb'
- 'test/unit/bulk_update_request_test.rb' - 'test/unit/bulk_update_request_test.rb'
# Offense count: 756 # Offense count: 629
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
@ -2530,10 +2455,6 @@ Style/StringLiterals:
- 'app/decorators/posts_decorator.rb' - 'app/decorators/posts_decorator.rb'
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/helpers/bulk_update_requests_helper.rb' - 'app/helpers/bulk_update_requests_helper.rb'
- 'app/helpers/note_versions_helper.rb'
- 'app/helpers/pool_versions_helper.rb'
- 'app/helpers/post_flags_helper.rb'
- 'app/helpers/post_versions_helper.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/logical/apng_inspector.rb' - 'app/logical/apng_inspector.rb'
- 'app/logical/bulk_update_request_importer.rb' - 'app/logical/bulk_update_request_importer.rb'
@ -2573,7 +2494,6 @@ Style/StringLiterals:
- 'app/models/user.rb' - 'app/models/user.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
- 'app/presenters/post_presenter.rb' - 'app/presenters/post_presenter.rb'
- 'app/presenters/post_set_presenters/popular.rb'
- 'app/presenters/tag_set_presenter.rb' - 'app/presenters/tag_set_presenter.rb'
- 'app/serializers/post_serializer.rb' - 'app/serializers/post_serializer.rb'
- 'app/views/admin/reowner/new.html.erb' - 'app/views/admin/reowner/new.html.erb'
@ -2631,96 +2551,22 @@ Style/StringLiterals:
- 'db/fixes/105_modaction_to_postevents.rb' - 'db/fixes/105_modaction_to_postevents.rb'
- 'db/fixes/106_note_ranges.rb' - 'db/fixes/106_note_ranges.rb'
- 'db/fixes/107_remove_name_change_tickets.rb' - 'db/fixes/107_remove_name_change_tickets.rb'
- 'test/controllers/forum_post_votes_controller_test.rb'
- 'test/factories/mod_action.rb' - 'test/factories/mod_action.rb'
- 'test/factories/upload.rb' - 'test/factories/upload.rb'
- 'test/functional/admin/danger_zone_controller_test.rb'
- 'test/functional/admin/dashboards_controller_test.rb'
- 'test/functional/admin/users_controller_test.rb'
- 'test/functional/artists_controller_test.rb'
- 'test/functional/bans_controller_test.rb'
- 'test/functional/bulk_update_requests_controller_test.rb'
- 'test/functional/comment_votes_controller_test.rb'
- 'test/functional/comments_controller_test.rb'
- 'test/functional/dmails_controller_test.rb'
- 'test/functional/dtext_previews_controller_test.rb'
- 'test/functional/favorites_controller_test.rb'
- 'test/functional/forum_posts_controller_test.rb'
- 'test/functional/forum_topics_controller_test.rb'
- 'test/functional/ip_bans_controller_test.rb'
- 'test/functional/iqdb_queries_controller_test.rb'
- 'test/functional/maintenance/user/api_keys_controller_test.rb'
- 'test/functional/meta_searches_controller_test.rb'
- 'test/functional/mod_actions_controller_test.rb'
- 'test/functional/moderator/dashboards_controller_test.rb'
- 'test/functional/moderator/ip_addrs_controller_test.rb'
- 'test/functional/moderator/post/disapprovals_controller_test.rb'
- 'test/functional/moderator/post/posts_controller_test.rb'
- 'test/functional/news_updates_controller_test.rb'
- 'test/functional/note_previews_controller_test.rb'
- 'test/functional/note_versions_controller_test.rb'
- 'test/functional/notes_controller_test.rb'
- 'test/functional/pool_elements_controller_test.rb'
- 'test/functional/pool_versions_controller_test.rb'
- 'test/functional/pools_controller_test.rb'
- 'test/functional/post_approvals_controller_test.rb'
- 'test/functional/post_events_controller_test.rb'
- 'test/functional/post_flags_controller_test.rb'
- 'test/functional/post_replacements_controller_test.rb' - 'test/functional/post_replacements_controller_test.rb'
- 'test/functional/post_votes_controller_test.rb'
- 'test/functional/related_tags_controller_test.rb'
- 'test/functional/tag_alias_requests_controller_test.rb'
- 'test/functional/tag_implication_requests_controller_test.rb'
- 'test/functional/tags_controller_test.rb'
- 'test/functional/user_name_change_requests_controller_test.rb'
- 'test/functional/users_controller_test.rb'
- 'test/functional/wiki_page_versions_controller_test.rb'
- 'test/functional/wiki_pages_controller_test.rb'
- 'test/models/upload_service_test.rb' - 'test/models/upload_service_test.rb'
- 'test/unit/api_key_test.rb'
- 'test/unit/apng_inspector_test.rb' - 'test/unit/apng_inspector_test.rb'
- 'test/unit/application_record.rb'
- 'test/unit/artist_url_test.rb'
- 'test/unit/ban_test.rb'
- 'test/unit/bulk_update_importer_importer_test.rb'
- 'test/unit/bulk_update_request_test.rb'
- 'test/unit/current_user_test.rb'
- 'test/unit/dmail_filter_test.rb'
- 'test/unit/email_blacklist_test.rb' - 'test/unit/email_blacklist_test.rb'
- 'test/unit/favorite_test.rb'
- 'test/unit/forum_topic_test.rb'
- 'test/unit/ip_ban_test.rb'
- 'test/unit/maintenance_test.rb'
- 'test/unit/note_test.rb'
- 'test/unit/pool_test.rb'
- 'test/unit/post_approval_test.rb'
- 'test/unit/post_disapproval_test.rb'
- 'test/unit/post_event_test.rb'
- 'test/unit/post_flag_test.rb'
- 'test/unit/post_pruner_test.rb'
- 'test/unit/post_replacement_test.rb' - 'test/unit/post_replacement_test.rb'
- 'test/unit/post_sets/favorites_test.rb'
- 'test/unit/post_sets/pool_test.rb'
- 'test/unit/post_test.rb' - 'test/unit/post_test.rb'
- 'test/unit/post_version_test.rb'
- 'test/unit/post_vote_test.rb' - 'test/unit/post_vote_test.rb'
- 'test/unit/related_tag_calculator_test.rb'
- 'test/unit/related_tag_query_test.rb'
- 'test/unit/session_loader_test.rb'
- 'test/unit/sources/null_test.rb'
- 'test/unit/storage_manager_test.rb'
- 'test/unit/string_test.rb' - 'test/unit/string_test.rb'
- 'test/unit/tag_alias_request_test.rb'
- 'test/unit/tag_alias_test.rb' - 'test/unit/tag_alias_test.rb'
- 'test/unit/tag_implication_request_test.rb'
- 'test/unit/tag_implication_test.rb' - 'test/unit/tag_implication_test.rb'
- 'test/unit/tag_test.rb' - 'test/unit/tag_test.rb'
- 'test/unit/user_feedback_test.rb'
- 'test/unit/user_password_reset_nonce_test.rb'
- 'test/unit/user_test.rb' - 'test/unit/user_test.rb'
- 'test/unit/wiki_page_test.rb'
# Offense count: 31 # Offense count: 23
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
@ -2730,7 +2576,6 @@ Style/StringLiteralsInInterpolation:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/helpers/bulk_update_requests_helper.rb' - 'app/helpers/bulk_update_requests_helper.rb'
- 'app/helpers/posts_helper.rb' - 'app/helpers/posts_helper.rb'
- 'app/helpers/tags_helper.rb'
- 'app/logical/bulk_update_request_importer.rb' - 'app/logical/bulk_update_request_importer.rb'
- 'app/models/post.rb' - 'app/models/post.rb'
- 'app/presenters/tag_set_presenter.rb' - 'app/presenters/tag_set_presenter.rb'
@ -2820,7 +2665,7 @@ Style/SymbolProc:
- 'db/fixes/100_new_iqdb_import.rb' - 'db/fixes/100_new_iqdb_import.rb'
- 'test/factories/post.rb' - 'test/factories/post.rb'
# Offense count: 29 # Offense count: 23
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyleForMultiline. # Configuration parameters: EnforcedStyleForMultiline.
# SupportedStylesForMultiline: comma, consistent_comma, no_comma # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@ -2838,7 +2683,6 @@ Style/TrailingCommaInArguments:
- 'app/models/tag_alias.rb' - 'app/models/tag_alias.rb'
- 'app/models/tag_implication.rb' - 'app/models/tag_implication.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'
- 'app/presenters/post_set_presenters/popular.rb'
- 'db/fixes/102_generate_missing_post_version_fields.rb' - 'db/fixes/102_generate_missing_post_version_fields.rb'
- 'test/functional/user_name_change_requests_controller_test.rb' - 'test/functional/user_name_change_requests_controller_test.rb'
- 'test/unit/tag_implication_test.rb' - 'test/unit/tag_implication_test.rb'
@ -2905,12 +2749,6 @@ Style/TrivialAccessors:
Exclude: Exclude:
- 'app/models/ban.rb' - 'app/models/ban.rb'
# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Style/UnpackFirst:
Exclude:
- 'app/logical/apng_inspector.rb'
# Offense count: 1 # Offense count: 1
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Style/WhileUntilModifier: Style/WhileUntilModifier: