diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0a9f0833a..80f310ebf 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 20000` -# on 2023-08-31 06:56:33 UTC using RuboCop version 1.55.1. +# on 2023-10-02 18:41:11 UTC using RuboCop version 1.55.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -24,13 +24,12 @@ Layout/AccessModifierIndentation: - 'app/logical/session_loader.rb' - 'config/state_checker.rb' -# Offense count: 2 +# Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: with_first_argument, with_fixed_indentation Layout/ArgumentAlignment: Exclude: - - 'app/logical/elastic_post_query_builder.rb' - 'app/models/user.rb' # Offense count: 1 @@ -57,11 +56,10 @@ Layout/CaseIndentation: Exclude: - 'app/helpers/application_helper.rb' -# Offense count: 13 +# Offense count: 12 # This cop supports safe autocorrection (--autocorrect). Layout/ClosingParenthesisIndentation: Exclude: - - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/moderator/dashboard/queries/mod_action.rb' - 'app/logical/pbkdf2.rb' - 'app/models/post_set_maintainer.rb' @@ -237,20 +235,18 @@ Layout/FirstArrayElementIndentation: Exclude: - 'app/models/mod_action.rb' -# Offense count: 60 +# Offense count: 51 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces Layout/FirstHashElementIndentation: Exclude: - - 'app/controllers/admin/users_controller.rb' - 'app/controllers/post_sets_controller.rb' - 'app/controllers/posts_controller.rb' - 'app/controllers/upload_whitelists_controller.rb' - 'app/controllers/uploads_controller.rb' - 'app/decorators/posts_decorator.rb' - 'app/indexes/post_version_index.rb' - - 'app/logical/elastic_post_query_builder.rb' - 'app/models/edit_history.rb' - 'app/models/pool_version.rb' - 'app/models/post.rb' @@ -262,7 +258,7 @@ Layout/FirstHashElementIndentation: - 'config/danbooru_default_config.rb' - 'config/environments/production.rb' -# Offense count: 65 +# Offense count: 64 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. # SupportedHashRocketStyles: key, separator, table @@ -316,22 +312,6 @@ Layout/LeadingEmptyLines: - 'app/views/forum_post_votes/_list.html.erb' - 'app/views/forum_post_votes/_vote.html.erb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: symmetrical, new_line, same_line -Layout/MultilineHashBraceLayout: - Exclude: - - 'app/controllers/admin/users_controller.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: symmetrical, new_line, same_line -Layout/MultilineMethodCallBraceLayout: - Exclude: - - 'app/logical/elastic_post_query_builder.rb' - # Offense count: 40 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. @@ -345,13 +325,12 @@ Layout/MultilineMethodCallIndentation: - 'app/logical/moderator/dashboard/queries/wiki_page.rb' - 'app/models/forum_topic.rb' -# Offense count: 11 +# Offense count: 10 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented Layout/MultilineOperationIndentation: Exclude: - - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/sources/alternates/pixiv.rb' - 'test/unit/bulk_update_importer_importer_test.rb' - 'test/unit/bulk_update_request_test.rb' @@ -429,7 +408,7 @@ Layout/SpaceAroundOperators: - 'test/unit/post_test.rb' - 'test/unit/related_tag_calculator_test.rb' -# Offense count: 38 +# Offense count: 39 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space @@ -493,7 +472,7 @@ Layout/SpaceInsideArrayLiteralBrackets: Exclude: - 'config/environments/production.rb' -# Offense count: 347 +# Offense count: 334 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space @@ -508,7 +487,6 @@ Layout/SpaceInsideBlockBraces: - 'app/helpers/tags_helper.rb' - 'app/helpers/text_helper.rb' - 'app/indexes/post_index.rb' - - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/post_sets/base.rb' - 'app/logical/related_tag_calculator.rb' - 'app/logical/sources/alternates.rb' @@ -553,7 +531,7 @@ Layout/SpaceInsideBlockBraces: - 'test/unit/tag_test.rb' - 'test/unit/user_test.rb' -# Offense count: 988 +# Offense count: 893 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -584,7 +562,6 @@ Layout/SpaceInsideHashLiteralBraces: - 'app/helpers/dmails_helper.rb' - 'app/helpers/posts_helper.rb' - 'app/helpers/wiki_pages_helper.rb' - - 'app/indexes/post_version_index.rb' - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/moderator/ip_addr_search.rb' - 'app/logical/post_thumbnailer.rb' @@ -611,7 +588,6 @@ Layout/SpaceInsideHashLiteralBraces: - 'app/models/ticket.rb' - 'app/models/upload_whitelist.rb' - 'app/models/user.rb' - - 'app/models/user_name_change_request.rb' - 'app/models/wiki_page.rb' - 'app/views/admin/users/edit_blacklist.html.erb' - 'app/views/artist_versions/_standard_listing.html.erb' @@ -1044,7 +1020,7 @@ Lint/UselessAssignment: - 'test/unit/tag_implication_test.rb' - 'test/unit/tag_test.rb' -# Offense count: 13 +# Offense count: 11 # Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns. # AllowedMethods: refine Metrics/BlockLength: @@ -1362,12 +1338,11 @@ Rails/IndexBy: - 'app/models/pool.rb' - 'app/presenters/tag_set_presenter.rb' -# Offense count: 4 +# Offense count: 3 # Configuration parameters: Include. # Include: app/controllers/**/*.rb, app/mailers/**/*.rb Rails/LexicallyScopedActionFilter: Exclude: - - 'app/controllers/maintenance/user/api_keys_controller.rb' - 'app/controllers/posts_controller.rb' - 'app/controllers/tickets_controller.rb' - 'app/controllers/upload_whitelists_controller.rb' @@ -1392,7 +1367,7 @@ Rails/Output: Exclude: - 'app/indexes/post_version_index.rb' -# Offense count: 73 +# Offense count: 75 Rails/OutputSafety: Exclude: - 'app/helpers/application_helper.rb' @@ -1752,7 +1727,7 @@ Style/HashLikeCase: - 'app/models/post.rb' - 'config/initializers/core_extensions.rb' -# Offense count: 1166 +# Offense count: 1162 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -1768,7 +1743,6 @@ Style/HashSyntax: - 'app/controllers/favorites_controller.rb' - 'app/controllers/forum_posts_controller.rb' - 'app/controllers/forum_topics_controller.rb' - - 'app/controllers/maintenance/user/api_keys_controller.rb' - 'app/controllers/maintenance/user/deletions_controller.rb' - 'app/controllers/maintenance/user/email_changes_controller.rb' - 'app/controllers/maintenance/user/email_notifications_controller.rb' @@ -2145,13 +2119,12 @@ Style/NegatedIf: - 'app/models/user_password_reset_nonce.rb' - 'app/views/posts/partials/show/_options.html.erb' -# Offense count: 6 +# Offense count: 5 # This cop supports safe autocorrection (--autocorrect). Style/NegatedIfElseCondition: Exclude: - 'app/controllers/comment_votes_controller.rb' - 'app/controllers/post_votes_controller.rb' - - 'app/models/dmail.rb' - 'app/views/posts/show.html.erb' - 'app/views/tickets/show.html.erb' - 'app/views/uploads/new.html.erb' @@ -2193,14 +2166,13 @@ Style/NumericLiteralPrefix: Exclude: - 'app/logical/storage_manager/local.rb' -# Offense count: 13 +# Offense count: 12 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinDigits, Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: Exclude: - 'app/indexes/post_version_index.rb' - 'app/logical/apng_inspector.rb' - - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/pbkdf2.rb' - 'app/views/ads/_leaderboard.html.erb' - 'app/views/takedowns/new.html.erb' @@ -2282,7 +2254,7 @@ Style/PreferredHashMethods: Exclude: - 'app/helpers/posts_helper.rb' -# Offense count: 58 +# Offense count: 56 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, AllowedCompactTypes. # SupportedStyles: compact, exploded @@ -2401,7 +2373,7 @@ Style/RedundantRegexpEscape: - 'app/models/pool.rb' - 'app/models/post.rb' -# Offense count: 62 +# Offense count: 61 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: @@ -2614,7 +2586,7 @@ Style/StringConcatenation: - 'test/unit/bulk_update_importer_importer_test.rb' - 'test/unit/bulk_update_request_test.rb' -# Offense count: 864 +# Offense count: 781 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -2653,8 +2625,6 @@ Style/StringLiterals: - 'app/helpers/post_flags_helper.rb' - 'app/helpers/post_versions_helper.rb' - 'app/helpers/posts_helper.rb' - - 'app/indexes/post_index.rb' - - 'app/indexes/post_version_index.rb' - 'app/logical/apng_inspector.rb' - 'app/logical/bulk_update_request_importer.rb' - 'app/logical/elastic_post_query_builder.rb' @@ -2737,7 +2707,6 @@ Style/StringLiterals: - 'app/views/users/home.html.erb' - 'app/views/users/new.html.erb' - 'config.ru' - - 'config/application.rb' - 'config/danbooru_default_config.rb' - 'config/environments/development.rb' - 'config/initializers/backtrace_silencers.rb' @@ -2876,7 +2845,7 @@ Style/StructInheritance: - 'app/logical/moderator/dashboard/queries/upload.rb' - 'app/logical/moderator/dashboard/queries/wiki_page.rb' -# Offense count: 113 +# Offense count: 112 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize. # SupportedStyles: percent, brackets @@ -2934,13 +2903,12 @@ Style/SymbolArray: - 'test/unit/post_event_test.rb' - 'test/unit/storage_manager_test.rb' -# Offense count: 16 +# Offense count: 14 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. # AllowedMethods: define_method, mail, respond_to Style/SymbolProc: Exclude: - - 'app/controllers/maintenance/user/api_keys_controller.rb' - 'app/controllers/news_updates_controller.rb' - 'app/controllers/pools_controller.rb' - 'app/controllers/posts_controller.rb' @@ -2992,13 +2960,12 @@ Style/TrailingCommaInArrayLiteral: - 'app/models/user.rb' - 'config/initializers/filter_parameter_logging.rb' -# Offense count: 83 +# Offense count: 78 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma Style/TrailingCommaInHashLiteral: Exclude: - - 'app/controllers/admin/users_controller.rb' - 'app/controllers/post_sets_controller.rb' - 'app/controllers/posts_controller.rb' - 'app/controllers/upload_whitelists_controller.rb' @@ -3007,7 +2974,6 @@ Style/TrailingCommaInHashLiteral: - 'app/helpers/application_helper.rb' - 'app/indexes/post_index.rb' - 'app/indexes/post_version_index.rb' - - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/tag_relationship_request.rb' - 'app/logical/upload_service/replacer.rb' - 'app/models/edit_history.rb' @@ -3087,7 +3053,7 @@ Style/WordArray: - 'test/unit/related_tag_query_test.rb' - 'test/unit/tag_alias_test.rb' -# Offense count: 17 +# Offense count: 16 # This cop supports unsafe autocorrection (--autocorrect-all). Style/ZeroLengthPredicate: Exclude: @@ -3095,7 +3061,6 @@ Style/ZeroLengthPredicate: - 'app/controllers/forum_post_votes_controller.rb' - 'app/controllers/post_flags_controller.rb' - 'app/controllers/wiki_pages_controller.rb' - - 'app/logical/elastic_post_query_builder.rb' - 'app/models/bulk_update_request.rb' - 'app/models/pool.rb' - 'app/models/post.rb'