[CSS] Clean up duplicate table classes

width: 100% is already part of the class. Remove duplicate classes .table/.striped and exclusivly use the more common one. Add this class to PostReportReasons/Help, which were missing it.
2022-12-29 16:36:33 +01:00 · 2022-12-29 16:36:33 +01:00 · 9afc1949fa
commit 9afc1949fa
parent 4ee284f215
42 changed files with 44 additions and 49 deletions
--- a/app/javascript/src/styles/common/tables.scss
+++ b/app/javascript/src/styles/common/tables.scss
@ -1,5 +1,5 @@

-table.table {
+table.striped {
  width: 100%;

  // DText formatting fix
@ -66,11 +66,6 @@ table.table {
  }
 }

-// Needed so that unconverted tables work.
-table.striped {
-  @extend .table;
-}
-
 /*
 * A table where one column expands to fill the screen, while the
 * other columns shrink to fit their contents.
--- a/app/views/admin/users/alt_list.html.erb
+++ b/app/views/admin/users/alt_list.html.erb
@ -1,6 +1,6 @@
 <div id="c-admin">
  <div id="a-alt-list">
-    <table class="table">
+    <table class="striped">
      <tbody>
        <% @alts.each do |u1, alt_ids| %>
          <tr class="alt-header" data-alt="<%= u1 %>">
--- a/app/views/artist_urls/index.html.erb
+++ b/app/views/artist_urls/index.html.erb
@ -9,7 +9,7 @@
      <%= f.submit "Search" %>
    <% end %>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>ID</th>
--- a/app/views/artist_versions/_standard_listing.html.erb
+++ b/app/views/artist_versions/_standard_listing.html.erb
@ -1,5 +1,5 @@
 <div id="p-<%= artist_versions_listing_type %>-listing">
-  <table width="100%" class="striped autofit">
+  <table class="striped autofit">
    <thead>
      <tr>
        <th>Name</th>
--- a/app/views/artists/index.html.erb
+++ b/app/views/artists/index.html.erb
@ -1,7 +1,7 @@
 <div id="c-artists">
  <div id="a-index">
    <%= render "search" %>
-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th width="45%">Primary Name</th>
--- a/app/views/bulk_update_requests/_listing.html.erb
+++ b/app/views/bulk_update_requests/_listing.html.erb
@ -1,4 +1,4 @@
-<table class="striped" width="100%">
+<table class="striped">
  <thead>
    <tr>
      <th>Creator</th>
--- a/app/views/deleted_posts/index.html.erb
+++ b/app/views/deleted_posts/index.html.erb
@ -1,6 +1,6 @@
 <h4>Deleted Posts</h4>

-<table class='table'>
+<table class="striped">
  <thead>
  <tr>
    <th>Post</th>
--- a/app/views/dmails/index.html.erb
+++ b/app/views/dmails/index.html.erb
@ -10,7 +10,7 @@

    <%= render "search" %>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>Date</th>
--- a/app/views/edit_histories/index.html.erb
+++ b/app/views/edit_histories/index.html.erb
@ -2,7 +2,7 @@
  <div id="a-index">
    <h1>Recent Edits</h1>

-    <table class='striped' style='width:100%;'>
+    <table class="striped">
      <thead>
      <tr>
        <th></th>
--- a/app/views/email_blacklists/index.html.erb
+++ b/app/views/email_blacklists/index.html.erb
@ -3,7 +3,7 @@
    <%= render "search" %>
    <h1>Email Blacklists</h1>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>User</th>
--- a/app/views/forum_posts/index.html.erb
+++ b/app/views/forum_posts/index.html.erb
@ -1,7 +1,7 @@
 <div id="c-forum-posts">
  <div id="a-index">
    <%= render "search" %>
-    <table width="100%" class="striped">
+    <table class="striped">
      <thead>
        <tr>
          <th>Topic</th>
--- a/app/views/forum_topics/_listing.html.erb
+++ b/app/views/forum_topics/_listing.html.erb
@ -1,4 +1,4 @@
-<table width="100%" class="striped">
+<table class="striped">
  <thead>
    <tr>
      <th>Title</th>
--- a/app/views/help/index.html.erb
+++ b/app/views/help/index.html.erb
@ -7,7 +7,7 @@
      <section id="content">
        <h2>Help Entries</h2>
        <div>
-          <table id="help-table" class="valign rounded" style="width:800px;">
+          <table id="help-table" class="striped" style="width:800px;">
            <thead>
            <tr>
              <th style="width:15%"></th>
--- a/app/views/ip_bans/index.html.erb
+++ b/app/views/ip_bans/index.html.erb
@ -2,7 +2,7 @@
  <div id="a-index">
    <h1>IP Bans</h1>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>IP Address</th>
--- a/app/views/maintenance/user/api_keys/view.html.erb
+++ b/app/views/maintenance/user/api_keys/view.html.erb
@ -2,7 +2,7 @@
  <div id="a-view">
    <h1>API Key</h1>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>API Key</th>
--- a/app/views/meta_searches/tags.html.erb
+++ b/app/views/meta_searches/tags.html.erb
@ -15,7 +15,7 @@
      <% if @meta_search.tags.blank? %>
        <p>No results</p>
      <% else %>
-        <table width="100%" class="striped">
+        <table class="striped">
          <thead>
            <tr>
              <th>Name</th>
@ -47,7 +47,7 @@
      <% if @meta_search.tag_aliases.blank? %>
        <p>No results</p>
      <% else %>
-        <table width="100%" class="striped">
+        <table class="striped">
          <thead>
            <tr>
              <th>From</th>
@ -83,7 +83,7 @@
      <% if @meta_search.tag_implications.blank? %>
        <p>No results</p>
      <% else %>
-        <table width="100%" class="striped">
+        <table class="striped">
          <thead>
            <tr>
              <th>From</th>
--- a/app/views/mod_actions/index.html.erb
+++ b/app/views/mod_actions/index.html.erb
@ -4,7 +4,7 @@

    <%= render "search" %>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>Date</th>
--- a/app/views/moderator/post/disapprovals/index.html.erb
+++ b/app/views/moderator/post/disapprovals/index.html.erb
@ -13,7 +13,7 @@
      <%= f.submit "Search" %>
    <% end %>

-    <table class="striped autofit" width="100%">
+    <table class="striped autofit">
      <thead>
        <tr>
          <th>Post</th>
--- a/app/views/news_updates/index.html.erb
+++ b/app/views/news_updates/index.html.erb
@ -2,7 +2,7 @@
  <div id="a-index">
    <h1>News Updates</h1>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>Creator</th>
--- a/app/views/note_versions/_revert_listing.html.erb
+++ b/app/views/note_versions/_revert_listing.html.erb
@ -1,5 +1,5 @@
 <div id="p-revert-listing">
-  <table width="100%" class="striped autofit">
+  <table class="striped autofit">
    <thead>
      <tr>
        <th></th>
--- a/app/views/note_versions/_standard_listing.html.erb
+++ b/app/views/note_versions/_standard_listing.html.erb
@ -1,5 +1,5 @@
 <div id="p-standard-listing">
-  <table width="100%" class="striped autofit">
+  <table class="striped autofit">
    <thead>
      <tr>
        <th></th>
--- a/app/views/notes/index.html.erb
+++ b/app/views/notes/index.html.erb
@ -3,7 +3,7 @@
    <h1>Notes</h1>

    <%= render "search" %>
-    <table width="100%" class="striped autofit">
+    <table class="striped autofit">
      <thead>
        <tr>
          <th>Post</th>
--- a/app/views/pool_versions/_revert_listing.html.erb
+++ b/app/views/pool_versions/_revert_listing.html.erb
@ -1,5 +1,5 @@
 <div id="p-revert-listing">
-  <table width="100%" class="striped autofit">
+  <table class="striped autofit">
    <thead>
      <tr>
        <th>Pool</th>
--- a/app/views/pool_versions/_standard_listing.html.erb
+++ b/app/views/pool_versions/_standard_listing.html.erb
@ -1,5 +1,5 @@
 <div id="p-standard-listing">
-  <table width="100%" class="striped autofit">
+  <table class="striped autofit">
    <thead>
      <tr>
        <th>Pool</th>
--- a/app/views/pools/index.html.erb
+++ b/app/views/pools/index.html.erb
@ -2,7 +2,7 @@
  <div id="a-index">
    <%= render partial: "search", locals: {path: pools_path} %>
    <h2>Pools</h2>
-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th width="5%"></th>
--- a/app/views/post_approvals/index.html.erb
+++ b/app/views/post_approvals/index.html.erb
@ -9,7 +9,7 @@
      <%= f.submit "Search" %>
    <% end %>

-    <table width="100%" class="striped">
+    <table class="striped">
      <thead>
        <tr>
          <th width="1%">Post</th>
--- a/app/views/post_events/index.html.erb
+++ b/app/views/post_events/index.html.erb
@ -4,7 +4,7 @@

    <%= render "search" %>

-    <table width="100%" class="table autofit">
+    <table class="striped autofit">
      <thead>
        <tr>
          <th>Post</th>
--- a/app/views/post_favorites/index.html.erb
+++ b/app/views/post_favorites/index.html.erb
@ -2,7 +2,7 @@
  <div id="a-index">
    <h1>Post Favorites</h1>
    <%= PostPresenter.preview(@post) %>
-    <table width="100%" class="striped">
+    <table class="striped">
      <thead>
        <tr>
          <th>Favorited by</th>
--- a/app/views/post_flags/index.html.erb
+++ b/app/views/post_flags/index.html.erb
@ -3,7 +3,7 @@
    <h1>Flags</h1>
    <%= render "search" %>
    <%= render "posts/partials/common/inline_blacklist" %>
-    <table width="100%" class="table">
+    <table class="striped">
      <thead>
        <tr>
          <th width="1%">Post</th>
--- a/app/views/post_replacements/index.html.erb
+++ b/app/views/post_replacements/index.html.erb
@ -5,7 +5,7 @@
    <%= render "search" %>
    <%= render "posts/partials/common/inline_blacklist" %>

-    <table width="100%" class="striped autofit" style="max-width:100%">
+    <table class="striped autofit" style="max-width:100%">
      <thead>
        <tr>
          <th width="1%">Post</th>
--- a/app/views/post_report_reasons/index.html.erb
+++ b/app/views/post_report_reasons/index.html.erb
@ -2,7 +2,7 @@
  <div id="a-index">
    <h1>Post Report Reasons</h1>

-    <table class='rounded' style='width:100%;'>
+    <table class="striped">
      <thead>
      <tr>
        <th></th>
--- a/app/views/post_sets/index.html.erb
+++ b/app/views/post_sets/index.html.erb
@ -5,7 +5,7 @@
    <h2>Sets</h2>

    <div id="set-index">
-      <table width="100%" class="table striped">
+      <table class="striped">
        <thead>
        <tr>
          <th width="30%">Name</th>
--- a/app/views/takedowns/index.html.erb
+++ b/app/views/takedowns/index.html.erb
@ -1,7 +1,7 @@
 <div id="c-takedowns">
  <div id="a-index">
    <%= render partial: 'search', locals: {path: takedowns_path} %>
-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
      <tr>
        <th>ID</th>
--- a/app/views/tickets/index.html.erb
+++ b/app/views/tickets/index.html.erb
@ -3,7 +3,7 @@
    <%= render partial: 'search' %>

    <h2>Ticket Center</h2>
-    <table class="valign striped">
+    <table class="striped">
      <thead>
        <tr>
          <th style="width:5%">ID</th>
--- a/app/views/upload_whitelists/index.html.erb
+++ b/app/views/upload_whitelists/index.html.erb
@ -3,7 +3,7 @@
    <%= render "search" %>
    <h1>Upload Whitelists</h1>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>Pattern</th>
--- a/app/views/uploads/index.html.erb
+++ b/app/views/uploads/index.html.erb
@ -3,7 +3,7 @@
    <%= render "uploads/search" %>
    <%= render "posts/partials/common/inline_blacklist" %>

-    <table width="100%" class="striped autofit">
+    <table class="striped autofit">
      <thead>
        <tr>
          <th>Upload</th>
--- a/app/views/user_feedbacks/index.html.erb
+++ b/app/views/user_feedbacks/index.html.erb
@ -3,7 +3,7 @@
    <h1>User Feedback</h1>

    <%= render "search" %>
-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th width="15%">User</th>
--- a/app/views/user_name_change_requests/index.html.erb
+++ b/app/views/user_name_change_requests/index.html.erb
@ -4,7 +4,7 @@

    <h1>Name Change Requests</h1>

-    <table class="striped" width="100%">
+    <table class="striped">
      <thead>
        <tr>
          <th>User</th>
--- a/app/views/users/index.html.erb
+++ b/app/views/users/index.html.erb
@ -3,7 +3,7 @@
    <h1>Users</h1>

    <%= render "search" %>
-    <table width="100%" class="striped">
+    <table class="striped">
      <thead>
        <tr>
          <th></th>
--- a/app/views/wiki_page_versions/_global_listing.html.erb
+++ b/app/views/wiki_page_versions/_global_listing.html.erb
@ -1,5 +1,5 @@
 <div id="p-global-listing">
-  <table width="100%" class="striped">
+  <table class="striped">
    <thead>
      <tr>
        <th>Title</th>
--- a/app/views/wiki_page_versions/_page_listing.html.erb
+++ b/app/views/wiki_page_versions/_page_listing.html.erb
@ -1,6 +1,6 @@
 <div id="p-page-listing">
  <%= form_tag(diff_wiki_page_versions_path, :method => :get) do %>
-    <table width="100%" class="striped">
+    <table class="striped">
      <thead>
        <tr>
          <th width="3%"></th>
--- a/app/views/wiki_pages/index.html.erb
+++ b/app/views/wiki_pages/index.html.erb
@ -6,7 +6,7 @@
      <h1>Wiki</h1>

      <%= render "search" %>
-      <table class="striped" width="100%">
+      <table class="striped">
        <thead>
          <tr>
            <th>Title</th>