From 92125ea7bea0fc2058ef469a1fa868ce0b880c08 Mon Sep 17 00:00:00 2001
From: Cinder <cinder@e621.net>
Date: Mon, 3 Feb 2025 08:06:34 -0800
Subject: [PATCH] [NewsUpdates] Stop links from being clickable when the news
 section is closed (#872)

---
 app/javascript/src/styles/common/news.scss | 15 +++++++++------
 app/views/news_updates/_notice.erb         |  4 ++--
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/app/javascript/src/styles/common/news.scss b/app/javascript/src/styles/common/news.scss
index d57876385..180900cd9 100644
--- a/app/javascript/src/styles/common/news.scss
+++ b/app/javascript/src/styles/common/news.scss
@@ -17,6 +17,8 @@ div#page div#news {
 
   &.open {
     max-height: none;
+
+    #news-body { pointer-events: unset; }
   }
 
   #news-header {
@@ -26,26 +28,27 @@ div#page div#news {
     cursor: pointer;
     width: 100%;
     text-align: center;
-    padding: 0.5rem 0.5rem 0;
+    padding: 0.5rem;
   }
 
   #news-body {
     display: block;
     box-sizing: border-box;
 
-    margin-top: 5px;
     max-width: 800px;
     padding: 0 0.5rem 0.5rem;
+
+    pointer-events: none;
   }
 
   #news-dismiss {
     position: absolute;
-    right: 0.5rem;
-    top: 0.25rem;
+    right: 0;
+    top: 0;
+    padding: 0.25rem 1rem;
 
     cursor: pointer;
-    font-size: 1.15rem;
+    font-size: 1.25rem;
     font-weight: bold;
-    color: white;
   }
 }
diff --git a/app/views/news_updates/_notice.erb b/app/views/news_updates/_notice.erb
index bd9ce5c8b..3da879607 100644
--- a/app/views/news_updates/_notice.erb
+++ b/app/views/news_updates/_notice.erb
@@ -1,8 +1,8 @@
 <% if news_update.present? %>
   <div class="ui-state-highlight site-notice" style="display: none;" id="news" data-id="<%= news_update.id %>">
-    <a href="" id="news-dismiss" title="Dismiss"><i class="fas fa-times"></i></a>
+    <a href="" role="button" id="news-dismiss" title="Dismiss"><i class="fas fa-times"></i></a>
     <h6 id="news-header">News: <%= news_update.created_at.strftime("%b %d, %Y") %>
-      <a href="" id="news-show">Show</a>
+      <a href="" role="button" id="news-show">Show</a>
     </h6>
     <div id="news-body" class="dtext-container"><%= format_text(news_update.message) %></div>
   </div>