diff --git a/app/javascript/src/javascripts/artist.js b/app/javascript/src/javascripts/artist.js index 2484ccae6..59386fadf 100644 --- a/app/javascript/src/javascripts/artist.js +++ b/app/javascript/src/javascripts/artist.js @@ -9,10 +9,10 @@ Artist.update = function (id, params) { type: "PUT", url: "/artists/" + id + ".json", data: params, - success: function(data) { + success: function() { Utility.notice("Artist updated."); }, - error: function(data) { + error: function() { Utility.error(`There was an error updating artist #${id}`); } }); diff --git a/app/javascript/src/javascripts/blacklists.js b/app/javascript/src/javascripts/blacklists.js index 9bcd2b96a..bbdd0bebd 100644 --- a/app/javascript/src/javascripts/blacklists.js +++ b/app/javascript/src/javascripts/blacklists.js @@ -9,7 +9,7 @@ Blacklist.post_count = 0; Blacklist.entries = []; Blacklist.entryGet = function (line) { - return $.grep(Blacklist.entries, function (e, i) { + return $.grep(Blacklist.entries, function (e) { return e.tags === line; })[0]; }; @@ -326,7 +326,7 @@ Blacklist.initialize_blacklist_editor = function () { } }).done(function () { Utility.notice("Blacklist updated"); - }).fail(function (data, status, xhr) { + }).fail(function () { Utility.error("Failed to update blacklist"); }); } diff --git a/app/javascript/src/javascripts/comments.js b/app/javascript/src/javascripts/comments.js index 828aee918..6f24ae540 100644 --- a/app/javascript/src/javascripts/comments.js +++ b/app/javascript/src/javascripts/comments.js @@ -50,7 +50,7 @@ Comment.show_all = function(e) { current_comment_section.html(data.html); Comment.reinitialize_all(); $(window).trigger("e621:add_deferred_posts", data.posts); - }).fail(function(data) { + }).fail(function() { Utility.error("Failed to fetch all comments for this post."); }); }; @@ -65,10 +65,10 @@ Comment.hide = function (e) { url: `/comments/${cid}/hide.json`, type: 'POST', dataType: 'json' - }).done(function (data) { + }).done(function () { $(`.comment[data-comment-id="${cid}"] div.author h1`).append(" (hidden)"); $(`.comment[data-comment-id="${cid}"]`).attr('data-is-deleted', 'true'); - }).fail(function (data) { + }).fail(function () { Utility.error("Failed to hide comment."); }); }; @@ -83,11 +83,11 @@ Comment.unhide = function (e) { url: `/comments/${cid}/unhide.json`, type: 'POST', dataType: 'json' - }).done(function (data) { + }).done(function () { const $author = $(`.comment[data-comment-id="${cid}"] div.author h1`); $author.text($author.text().replace(" (hidden)", "")); $(`.comment[data-comment-id="${cid}"]`).attr('data-is-deleted', 'false'); - }).fail(function (data) { + }).fail(function () { Utility.error("Failed to unhide comment."); }); }; @@ -102,9 +102,9 @@ Comment.delete = function (e) { url: `/comments/${cid}.json`, type: 'DELETE', dataType: 'json' - }).done(function (data) { + }).done(function () { parent.remove(); - }).fail(function (data) { + }).fail(function () { Utility.error("Failed to delete comment."); }); }; diff --git a/app/javascript/src/javascripts/common.js b/app/javascript/src/javascripts/common.js index 7656b791b..3074a7eaa 100644 --- a/app/javascript/src/javascripts/common.js +++ b/app/javascript/src/javascripts/common.js @@ -23,7 +23,7 @@ function initSearch() { } $(function() { - $("#theme-switcher").change(function(e) { + $("#theme-switcher").change(function() { let theme = $(this).val(); LS.put("theme", theme); $("body").attr("data-th-main", theme); @@ -60,9 +60,9 @@ $(function() { method: "PUT", url: path, dataType: 'json' - }).done(data => { + }).done(() => { location.reload(); - }).fail(data => { + }).fail(() => { Utility.error("Failed to revert to specified version."); }) }); diff --git a/app/javascript/src/javascripts/favorites.js b/app/javascript/src/javascripts/favorites.js index 46dd60d61..62f4dacb5 100644 --- a/app/javascript/src/javascripts/favorites.js +++ b/app/javascript/src/javascripts/favorites.js @@ -42,7 +42,7 @@ Favorite.create = function (post_id) { Post.notice_update("dec"); Favorite.after_action(post_id, 1); Utility.notice("Favorite added"); - }).fail(function (data, status, xhr) { + }).fail(function (data) { Utility.error("Error: " + data.responseJSON.message); }); }); @@ -60,7 +60,7 @@ Favorite.destroy = function (post_id) { Post.notice_update("dec"); Favorite.after_action(post_id, -1); Utility.notice("Favorite removed"); - }).fail(function (data, status, xhr) { + }).fail(function (data) { Utility.error("Error: " + data.responseJSON.message); }); }); diff --git a/app/javascript/src/javascripts/forum_posts.js b/app/javascript/src/javascripts/forum_posts.js index 86d413d99..753de516a 100644 --- a/app/javascript/src/javascripts/forum_posts.js +++ b/app/javascript/src/javascripts/forum_posts.js @@ -84,11 +84,11 @@ ForumPost.vote_remove = function(evt) { type: "DELETE", dataType: "json", accept: "text/javascript", - }).done(function(data) { + }).done(function() { $(evt.target).parents(".own-forum-vote").remove(); $(`#forum-post-votes-for-${id} .forum-post-vote-block`).show(); Utility.notice("Vote removed."); - }).fail(function(data) { + }).fail(function() { Utility.error("Failed to unvote on forum post."); }) } @@ -136,10 +136,10 @@ ForumPost.hide = function (e) { url: `/forum_posts/${fpid}/hide.json`, type: 'POST', dataType: 'json' - }).done(function (data) { + }).done(function () { $(`.forum-post[data-forum-post-id="${fpid}"] div.author h4`).append(" (hidden)"); $(`.forum-post[data-forum-post-id="${fpid}"]`).attr('data-is-hidden', 'true'); - }).fail(function (data) { + }).fail(function () { Utility.error("Failed to hide post."); }); }; @@ -154,11 +154,11 @@ ForumPost.unhide = function (e) { url: `/forum_posts/${fpid}/unhide.json`, type: 'POST', dataType: 'json' - }).done(function (data) { + }).done(function () { const $author = $(`.forum-post[data-forum-post-id="${fpid}"] div.author h4`); $author.text($author.text().replace(" (hidden)", "")); $(`.forum-post[data-forum-post-id="${fpid}"]`).attr('data-is-hidden', 'false'); - }).fail(function (data) { + }).fail(function () { Utility.error("Failed to unhide post."); }); }; diff --git a/app/javascript/src/javascripts/local_storage.js b/app/javascript/src/javascripts/local_storage.js index 54063b585..45a9be018 100644 --- a/app/javascript/src/javascripts/local_storage.js +++ b/app/javascript/src/javascripts/local_storage.js @@ -13,6 +13,7 @@ let LS = { try { return JSON.parse(value); } catch (error) { + console.log(error); return null; } } diff --git a/app/javascript/src/javascripts/notes.js b/app/javascript/src/javascripts/notes.js index 3f915877a..dd55b6933 100644 --- a/app/javascript/src/javascripts/notes.js +++ b/app/javascript/src/javascripts/notes.js @@ -16,14 +16,14 @@ let Note = { $note_box.attr("data-id", String(id)); $note_box.draggable({ containment: $("#image"), - stop: function(e, ui) { + stop: function() { Note.Box.update_data_attributes($note_box); } }); $note_box.resizable({ containment: $("#image"), handles: "se, nw", - stop: function(e, ui) { + stop: function() { Note.Box.update_data_attributes($note_box); } }); @@ -406,11 +406,11 @@ let Note = { return hash; }, - error_handler: function(xhr, status, exception) { + error_handler: function(xhr) { Utility.error("Error: " + (xhr.responseJSON.reason || xhr.responseJSON.reasons.join("; "))); }, - success_handler: function(data, status, xhr) { + success_handler: function(data) { var $note_box = null; if (data.html_id) { // new note diff --git a/app/javascript/src/javascripts/post_mode_menu.js b/app/javascript/src/javascripts/post_mode_menu.js index 2b4212ca8..bebe83d42 100644 --- a/app/javascript/src/javascripts/post_mode_menu.js +++ b/app/javascript/src/javascripts/post_mode_menu.js @@ -54,7 +54,7 @@ PostModeMenu.initialize_selector = function() { $("#mode-box-mode").val(LS.get("mode")); } - $("#mode-box-mode").on("change.danbooru", function(e) { + $("#mode-box-mode").on("change.danbooru", function() { PostModeMenu.change(); $("#tag-script-field:visible").focus().select(); }); @@ -103,7 +103,7 @@ PostModeMenu.close_edit_form = function() { } PostModeMenu.initialize_tag_script_field = function() { - $("#tag-script-field").blur(function(e) { + $("#tag-script-field").blur(function() { const script = $(this).val(); const current_script_id = LS.get("current_tag_script_id"); diff --git a/app/javascript/src/javascripts/post_replacement.js b/app/javascript/src/javascripts/post_replacement.js index 1e5963c60..3ded0806e 100644 --- a/app/javascript/src/javascripts/post_replacement.js +++ b/app/javascript/src/javascripts/post_replacement.js @@ -34,7 +34,7 @@ PostReplacement.approve = function (id, penalize_current_uploader) { dataType: 'json' }).done(function () { set_status($row, "approved"); - }).fail(function (data, status, xhr) { + }).fail(function (data) { Utility.error(data.responseText); set_status($row, "replacement failed"); }); @@ -51,7 +51,7 @@ PostReplacement.reject = function (id) { dataType: 'json' }).done(function () { set_status($row, "rejected"); - }).fail(function (data, status, xhr) { + }).fail(function (data) { Utility.error(data.responseText); set_status($row, "rejecting failed"); }); @@ -69,7 +69,7 @@ PostReplacement.promote = function (id) { }).done(function (data) { Utility.notice(`Replacement promoted to post #${data.post.id}`); set_status($row, "promoted"); - }).fail(function (data, status, xhr) { + }).fail(function (data) { Utility.error(data.responseText); set_status($row, "promoting failed"); }); @@ -83,10 +83,10 @@ PostReplacement.toggle_penalize = function ($target) { type: "PUT", url: `/post_replacements/${id}/toggle_penalize.json`, dataType: 'json' - }).done(function (data) { + }).done(function () { $target.removeClass("disabled-link"); $currentStatus.text($currentStatus.text() == "yes" ? "no" : "yes"); - }).fail(function (data, status, xhr) { + }).fail(function (data) { Utility.error(data.responseText); }); } diff --git a/app/javascript/src/javascripts/post_sets.js b/app/javascript/src/javascripts/post_sets.js index ffad5b16a..59c733eb1 100644 --- a/app/javascript/src/javascripts/post_sets.js +++ b/app/javascript/src/javascripts/post_sets.js @@ -14,7 +14,7 @@ PostSet.add_post = function (set_id, post_id) { url: "/post_sets/" + set_id + "/add_posts.json", data: {post_ids: [post_id]}, }).fail(function (data) { - var message = $.map(data.responseJSON.errors, function(msg, attr) { return msg; }).join('; '); + var message = $.map(data.responseJSON.errors, function(msg) { return msg; }).join('; '); Post.notice_update("dec"); $(window).trigger('danbooru:error', "Error: " + message); }).done(function () { @@ -32,7 +32,7 @@ PostSet.remove_post = function (set_id, post_id) { url: "/post_sets/" + set_id + "/remove_posts.json", data: {post_ids: [post_id]}, }).fail(function (data) { - var message = $.map(data.responseJSON.errors, function(msg, attr) { return msg; }).join('; '); + var message = $.map(data.responseJSON.errors, function(msg) { return msg; }).join('; '); Post.notice_update("dec"); $(window).trigger('danbooru:error', "Error: " + message); }).done(function () { diff --git a/app/javascript/src/javascripts/post_versions.js b/app/javascript/src/javascripts/post_versions.js index 2ba134128..5f7a59850 100644 --- a/app/javascript/src/javascripts/post_versions.js +++ b/app/javascript/src/javascripts/post_versions.js @@ -22,11 +22,11 @@ PostVersion.initialize_undo = function () { $(event.target).find(".post-version-select:not(:disabled)").prop("checked", (_, checked) => !checked).change(); }); - $("#post-version-select-all").on("change.danbooru", function (event) { + $("#post-version-select-all").on("change.danbooru", function () { $(".post-version-select:not(:disabled)").prop("checked", $("#post-version-select-all").prop("checked")).change(); }); - $(".post-version-select").on("change.danbooru", function (event) { + $(".post-version-select").on("change.danbooru", function () { let checked = $(".post-version-select:checked"); $("#subnav-undo-selected-link").text(`Undo selected (${checked.length})`).toggle(checked.length > 0); }); diff --git a/app/javascript/src/javascripts/posts.js b/app/javascript/src/javascripts/posts.js index a69f2d937..431570c8d 100644 --- a/app/javascript/src/javascripts/posts.js +++ b/app/javascript/src/javascripts/posts.js @@ -106,7 +106,7 @@ Post.open_edit_dialog = function() { at: "right-20", of: window }, - drag: function(e, ui) { + drag: function() { if (Utility.meta("enable-auto-complete") === "true") { $tag_string.data("uiAutocomplete").close(); } @@ -118,7 +118,7 @@ Post.open_edit_dialog = function() { var pin_button = $("