diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 80f310ebf..5cf1e6d65 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 20000` -# on 2023-10-02 18:41:11 UTC using RuboCop version 1.55.1. +# on 2023-12-04 19:57:30 UTC using RuboCop version 1.58.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -93,7 +93,7 @@ Layout/EmptyLineBetweenDefs: - 'app/models/post_version.rb' - 'app/models/user.rb' -# Offense count: 12 +# Offense count: 11 # This cop supports safe autocorrection (--autocorrect). Layout/EmptyLines: Exclude: @@ -105,7 +105,6 @@ Layout/EmptyLines: - 'app/models/post_approval.rb' - 'app/models/post_report_reason.rb' - 'app/models/tag_alias.rb' - - 'config/danbooru_default_config.rb' - 'config/environments/development.rb' - 'config/environments/production.rb' @@ -196,7 +195,7 @@ Layout/EndAlignment: - 'app/models/bulk_update_request.rb' - 'app/models/tag_implication.rb' -# Offense count: 15 +# Offense count: 14 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. Layout/ExtraSpacing: @@ -213,7 +212,6 @@ Layout/ExtraSpacing: - 'app/views/user_votes/_common_index.html.erb' - 'app/views/wiki_pages/show_or_new.html.erb' - 'config.ru' - - 'config/initializers/backtrace_silencers.rb' # Offense count: 12 # This cop supports safe autocorrection (--autocorrect). @@ -235,7 +233,7 @@ Layout/FirstArrayElementIndentation: Exclude: - 'app/models/mod_action.rb' -# Offense count: 51 +# Offense count: 50 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces @@ -347,7 +345,7 @@ Layout/SpaceAfterColon: Exclude: - 'app/views/users/_statistics.html.erb' -# Offense count: 32 +# Offense count: 29 # This cop supports safe autocorrection (--autocorrect). Layout/SpaceAfterComma: Exclude: @@ -375,17 +373,17 @@ Layout/SpaceAroundEqualsInParameterDefault: - 'app/logical/storage_manager.rb' - 'app/models/artist.rb' -# Offense count: 2 +# Offense count: 1 # This cop supports safe autocorrection (--autocorrect). Layout/SpaceAroundKeyword: Exclude: - - 'app/logical/danbooru_logger.rb' - 'test/functional/comments_controller_test.rb' # Offense count: 38 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. +# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals. # SupportedStylesForExponentOperator: space, no_space +# SupportedStylesForRationalLiterals: space, no_space Layout/SpaceAroundOperators: Exclude: - 'app/decorators/posts_decorator.rb' @@ -455,14 +453,6 @@ Layout/SpaceBeforeSemicolon: - 'app/models/user.rb' - 'app/models/wiki_page.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: require_no_space, require_space -Layout/SpaceInLambdaLiteral: - Exclude: - - 'app/models/upload.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. @@ -472,7 +462,7 @@ Layout/SpaceInsideArrayLiteralBrackets: Exclude: - 'config/environments/production.rb' -# Offense count: 334 +# Offense count: 312 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space @@ -485,7 +475,6 @@ Layout/SpaceInsideBlockBraces: - 'app/controllers/posts_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/tags_helper.rb' - - 'app/helpers/text_helper.rb' - 'app/indexes/post_index.rb' - 'app/logical/post_sets/base.rb' - 'app/logical/related_tag_calculator.rb' @@ -494,7 +483,6 @@ Layout/SpaceInsideBlockBraces: - 'app/models/artist.rb' - 'app/models/bulk_update_request.rb' - 'app/models/favorite.rb' - - 'app/models/forum_post.rb' - 'app/models/forum_post_vote.rb' - 'app/models/forum_topic.rb' - 'app/models/note.rb' @@ -531,7 +519,7 @@ Layout/SpaceInsideBlockBraces: - 'test/unit/tag_test.rb' - 'test/unit/user_test.rb' -# Offense count: 893 +# Offense count: 879 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -541,7 +529,6 @@ Layout/SpaceInsideHashLiteralBraces: - 'app/controllers/admin/staff_notes_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' - - 'app/controllers/blips_controller.rb' - 'app/controllers/comment_votes_controller.rb' - 'app/controllers/comments_controller.rb' - 'app/controllers/help_controller.rb' @@ -571,10 +558,8 @@ Layout/SpaceInsideHashLiteralBraces: - 'app/logical/sources/strategies/pixiv_slim.rb' - 'app/logical/tags_preview.rb' - 'app/logical/user_deletion.rb' - - 'app/models/application_record.rb' - 'app/models/ban.rb' - 'app/models/bulk_update_request.rb' - - 'app/models/forum_post.rb' - 'app/models/forum_post_vote.rb' - 'app/models/forum_topic.rb' - 'app/models/pool.rb' @@ -770,10 +755,9 @@ Lint/EmptyConditionalBody: Exclude: - 'app/models/post_version.rb' -# Offense count: 3 +# Offense count: 2 Lint/IneffectiveAccessModifier: Exclude: - - 'app/logical/danbooru_logger.rb' - 'app/logical/email_link_validator.rb' - 'app/logical/vote_manager.rb' @@ -858,7 +842,7 @@ Lint/RescueException: # Offense count: 3 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods. -# AllowedMethods: present?, blank?, presence, try, try!, in? +# AllowedMethods: present?, blank?, presence, presence_in, try, try!, in? Lint/SafeNavigationChain: Exclude: - 'app/views/blips/partials/show/_blip.html.erb' @@ -892,7 +876,7 @@ Lint/SuppressedException: - 'app/models/forum_subscription.rb' - 'app/models/tag.rb' -# Offense count: 83 +# Offense count: 81 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, consistent @@ -920,7 +904,6 @@ Lint/SymbolConversion: - 'app/views/posts/show.html.erb' - 'app/views/static/home.html.erb' - 'app/views/takedowns/_editor.html.erb' - - 'test/unit/downloads/file_test.rb' # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). @@ -941,7 +924,7 @@ Lint/UnreachableCode: - 'app/controllers/application_controller.rb' - 'app/controllers/static_controller.rb' -# Offense count: 59 +# Offense count: 56 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: @@ -949,8 +932,6 @@ Lint/UnusedBlockArgument: - 'app/controllers/application_controller.rb' - 'app/controllers/posts_controller.rb' - 'app/indexes/post_index.rb' - - 'app/logical/storage_manager.rb' - - 'app/logical/storage_manager/local.rb' - 'app/models/post.rb' - 'app/views/admin/danger_zone/index.html.erb' - 'config/application.rb' @@ -984,12 +965,11 @@ Lint/UriEscapeUnescape: Exclude: - 'app/presenters/presenter.rb' -# Offense count: 3 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. Lint/UselessAccessModifier: Exclude: - - 'app/logical/danbooru_logger.rb' - 'app/logical/email_link_validator.rb' - 'app/logical/vote_manager.rb' @@ -1020,13 +1000,12 @@ Lint/UselessAssignment: - 'test/unit/tag_implication_test.rb' - 'test/unit/tag_test.rb' -# Offense count: 11 +# Offense count: 10 # Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns. # AllowedMethods: refine Metrics/BlockLength: Exclude: - 'app/controllers/posts_controller.rb' - - 'app/helpers/text_helper.rb' - 'app/indexes/post_index.rb' - 'app/logical/bulk_update_request_importer.rb' - 'app/logical/storage_manager/match.rb' @@ -1313,8 +1292,7 @@ Rails/FilePath: # Offense count: 5 # This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: Include, AllowedMethods, AllowedPatterns. -# Include: app/models/**/*.rb +# Configuration parameters: AllowedMethods, AllowedPatterns. # AllowedMethods: order, limit, select, lock Rails/FindEach: Exclude: @@ -1485,6 +1463,7 @@ Rails/TimeZoneAssignment: - 'test/unit/post_test.rb' # Offense count: 10 +# Configuration parameters: TransactionMethods. Rails/TransactionExitStatement: Exclude: - 'app/controllers/tickets_controller.rb' @@ -1727,7 +1706,7 @@ Style/HashLikeCase: - 'app/models/post.rb' - 'config/initializers/core_extensions.rb' -# Offense count: 1162 +# Offense count: 1144 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -1784,7 +1763,6 @@ Style/HashSyntax: - 'app/models/artist_url.rb' - 'app/models/artist_version.rb' - 'app/models/ban.rb' - - 'app/models/blip.rb' - 'app/models/bulk_update_request.rb' - 'app/models/comment.rb' - 'app/models/dmail.rb' @@ -1804,7 +1782,6 @@ Style/HashSyntax: - 'app/models/user.rb' - 'app/models/user_name_change_request.rb' - 'app/models/wiki_page.rb' - - 'app/models/wiki_page_version.rb' - 'app/presenters/post_set_presenters/pool.rb' - 'app/presenters/post_set_presenters/pool_gallery.rb' - 'app/presenters/post_set_presenters/popular.rb' @@ -1952,7 +1929,6 @@ Style/HashSyntax: - 'test/functional/users_controller_test.rb' - 'test/functional/wiki_page_versions_controller_test.rb' - 'test/functional/wiki_pages_controller_test.rb' - - 'test/unit/comment_test.rb' - 'test/unit/dmail_filter_test.rb' - 'test/unit/forum_post_test.rb' - 'test/unit/forum_topic_test.rb' @@ -2206,15 +2182,7 @@ Style/ParallelAssignment: - 'app/models/tag_alias.rb' - 'app/models/tag_implication.rb' -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions. -Style/ParenthesesAroundCondition: - Exclude: - - 'app/controllers/users_controller.rb' - - 'app/models/post_flag.rb' - -# Offense count: 67 +# Offense count: 65 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: @@ -2317,12 +2285,6 @@ Style/RedundantBegin: - 'config/initializers/cache_store.rb' - 'db/fixes/101_migrate_mod_actions.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Style/RedundantCondition: - Exclude: - - 'app/controllers/posts_controller.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). Style/RedundantConstantBase: @@ -2586,7 +2548,7 @@ Style/StringConcatenation: - 'test/unit/bulk_update_importer_importer_test.rb' - 'test/unit/bulk_update_request_test.rb' -# Offense count: 781 +# Offense count: 771 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -2709,7 +2671,6 @@ Style/StringLiterals: - 'config.ru' - 'config/danbooru_default_config.rb' - 'config/environments/development.rb' - - 'config/initializers/backtrace_silencers.rb' - 'config/initializers/content_security_policy.rb' - 'config/initializers/core_extensions.rb' - 'config/initializers/secret_token.rb' @@ -2778,13 +2739,10 @@ Style/StringLiterals: - 'test/unit/ban_test.rb' - 'test/unit/bulk_update_importer_importer_test.rb' - 'test/unit/bulk_update_request_test.rb' - - 'test/unit/comment_test.rb' - 'test/unit/current_user_test.rb' - 'test/unit/dmail_filter_test.rb' - - 'test/unit/downloads/file_test.rb' - 'test/unit/email_blacklist_test.rb' - 'test/unit/favorite_test.rb' - - 'test/unit/forum_post_test.rb' - 'test/unit/forum_topic_test.rb' - 'test/unit/ip_ban_test.rb' - 'test/unit/maintenance_test.rb' @@ -2845,7 +2803,7 @@ Style/StructInheritance: - 'app/logical/moderator/dashboard/queries/upload.rb' - 'app/logical/moderator/dashboard/queries/wiki_page.rb' -# Offense count: 112 +# Offense count: 110 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize. # SupportedStyles: percent, brackets @@ -2890,7 +2848,6 @@ Style/SymbolArray: - 'app/models/mod_action.rb' - 'app/models/pool.rb' - 'app/models/post.rb' - - 'app/models/post_version.rb' - 'app/models/tag.rb' - 'app/models/takedown.rb' - 'app/models/user.rb' @@ -2960,7 +2917,7 @@ Style/TrailingCommaInArrayLiteral: - 'app/models/user.rb' - 'config/initializers/filter_parameter_logging.rb' -# Offense count: 78 +# Offense count: 76 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma @@ -3019,7 +2976,7 @@ Style/WhileUntilModifier: Exclude: - 'app/logical/user_deletion.rb' -# Offense count: 80 +# Offense count: 79 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize, WordRegex. # SupportedStyles: percent, brackets @@ -3048,7 +3005,6 @@ Style/WordArray: - 'app/views/takedowns/_editor.html.erb' - 'app/views/user_feedbacks/_form.html.erb' - 'app/views/users/edit.html.erb' - - 'db/fixes/103_fill_new_post_replacement_fields.rb' - 'test/unit/post_test.rb' - 'test/unit/related_tag_query_test.rb' - 'test/unit/tag_alias_test.rb'