From 58f9a18915c13ebbcb03c4d62224fe8e90a036ba Mon Sep 17 00:00:00 2001
From: Earlopain <14981592+Earlopain@users.noreply.github.com>
Date: Sat, 27 Apr 2024 13:57:51 +0200
Subject: [PATCH] [Tests] Improve/Add tests around network requests

---
 .../iqdb_queries_controller_test.rb           | 58 ++++++-------------
 test/unit/discord_report/aibur_stats_test.rb  | 16 +++++
 .../unit/discord_report/janitor_stats_test.rb | 16 +++++
 .../discord_report/moderator_stats_test.rb    | 16 +++++
 4 files changed, 65 insertions(+), 41 deletions(-)
 create mode 100644 test/unit/discord_report/aibur_stats_test.rb
 create mode 100644 test/unit/discord_report/janitor_stats_test.rb
 create mode 100644 test/unit/discord_report/moderator_stats_test.rb

diff --git a/test/functional/iqdb_queries_controller_test.rb b/test/functional/iqdb_queries_controller_test.rb
index 7b998eccd..f035ccdf1 100644
--- a/test/functional/iqdb_queries_controller_test.rb
+++ b/test/functional/iqdb_queries_controller_test.rb
@@ -6,59 +6,35 @@ class IqdbQueriesControllerTest < ActionDispatch::IntegrationTest
   context "The iqdb controller" do
     setup do
       IqdbProxy.stubs(:endpoint).returns("http://iqdb:5588")
-      @user = create(:user)
-      as(@user) do
-        @posts = create_list(:post, 2)
-      end
+      CloudflareService.stubs(:ips).returns([])
     end
 
     context "show action" do
       context "with a url parameter" do
-        setup do
-          create(:upload_whitelist, pattern: "*google.com")
-          @url = "https://google.com"
-          @params = { url: @url }
-          @mocked_response = [{
-            "post" => @posts[0],
-            "post_id" => @posts[0].id,
-            "score" => 1
-          }]
-        end
-
         should "render a response" do
-          IqdbProxy.expects(:query_url).with(@url, nil).returns(@mocked_response)
-          get_auth iqdb_queries_path, @user, params: @params
-          assert_select("#post_#{@posts[0].id}")
+          post = create(:post)
+          create(:upload_whitelist, pattern: "https://google.com/*")
+          stub_request(:get, "https://google.com/foo.jpg")
+            .to_return(body: file_fixture("test.jpg").read)
+          response = [{ "post_id" => post.id, "score" => 80 }]
+          stub_request(:post, "#{IqdbProxy.endpoint}/query").to_return_json(body: response)
+          get iqdb_queries_path, params: { url: "https://google.com/foo.jpg" }
+
+          assert_response :success
+          assert_select("#post_#{post.id}")
         end
       end
 
       context "with a post_id parameter" do
-        setup do
-          @params = { post_id: @posts[0].id }
-          @url = @posts[0].preview_file_url
-          @mocked_response = [{
-            "post" => @posts[0],
-            "post_id" => @posts[0].id,
-            "score" => 1
-          }]
-        end
-
         should "redirect to iqdb" do
-          IqdbProxy.expects(:query_post).with(@posts[0], nil).returns(@mocked_response)
-          get_auth iqdb_queries_path, @user, params: @params
-          assert_select("#post_#{@posts[0].id}")
-        end
-      end
+          post = create(:post)
+          response = [{ "post_id" => post.id, "score" => 80 }]
+          stub_request(:post, "#{IqdbProxy.endpoint}/query").to_return_json(body: response)
+          Post.any_instance.stubs(:preview_file_path).returns(file_fixture("test.jpg"))
 
-      context "with matches" do
-        setup do
-          json = @posts.map { |x| { "post_id" => x.id, "score" => 1 } }.to_json
-          @params = { matches: json }
-        end
-
-        should "render with matches" do
-          get_auth iqdb_queries_path, @user, params: @params
+          get iqdb_queries_path, params: { post_id: post.id }
           assert_response :success
+          assert_select("#post_#{post.id}")
         end
       end
     end
diff --git a/test/unit/discord_report/aibur_stats_test.rb b/test/unit/discord_report/aibur_stats_test.rb
new file mode 100644
index 000000000..1672000a7
--- /dev/null
+++ b/test/unit/discord_report/aibur_stats_test.rb
@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module DiscordReport
+  class AiburStatsTest < ActiveSupport::TestCase
+    test "it works" do
+      AiburStats.new.report # Prime cache
+      stats = AiburStats.new
+      stats.stubs(:webhook_url).returns("https://example.com")
+      stub_request(:post, "https://example.com/")
+        .with(body: /AIBUR report for/, headers: { "Content-Type" => "application/json" })
+      stats.post_webhook
+    end
+  end
+end
diff --git a/test/unit/discord_report/janitor_stats_test.rb b/test/unit/discord_report/janitor_stats_test.rb
new file mode 100644
index 000000000..4e57f548a
--- /dev/null
+++ b/test/unit/discord_report/janitor_stats_test.rb
@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module DiscordReport
+  class JanitorStatsTest < ActiveSupport::TestCase
+    test "it works" do
+      JanitorStats.new.report # Prime cache
+      stats = JanitorStats.new
+      stats.stubs(:webhook_url).returns("https://example.com")
+      stub_request(:post, "https://example.com/")
+        .with(body: /Janitor report for/, headers: { "Content-Type" => "application/json" })
+      stats.post_webhook
+    end
+  end
+end
diff --git a/test/unit/discord_report/moderator_stats_test.rb b/test/unit/discord_report/moderator_stats_test.rb
new file mode 100644
index 000000000..f67c508be
--- /dev/null
+++ b/test/unit/discord_report/moderator_stats_test.rb
@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module DiscordReport
+  class ModeratorStatsTest < ActiveSupport::TestCase
+    test "it works" do
+      ModeratorStats.new.report # Prime cache
+      stats = ModeratorStats.new
+      stats.stubs(:webhook_url).returns("https://example.com")
+      stub_request(:post, "https://example.com/")
+        .with(body: /Moderator report for/, headers: { "Content-Type" => "application/json" })
+      stats.post_webhook
+    end
+  end
+end