[Tests] Replace FFaker with FactoryBot sequences

Gemfile

@@ -64,7 +64,6 @@ group :test do
   gem "shoulda-matchers"
   gem "factory_bot"
   gem "mocha", :require => "mocha/minitest"
-  gem "ffaker"
   gem "webmock"
   gem "mock_redis"
 end

Gemfile.lock

@@ -161,7 +161,6 @@ GEM
     faraday-patron (1.0.0)
     faraday-rack (1.0.0)
     faraday-retry (1.0.3)
-    ffaker (2.21.0)
     ffi (1.15.5)
     ffi (1.15.5-x64-mingw32)
     get_process_mem (0.2.7)
@@ -410,7 +409,6 @@ DEPENDENCIES
   elasticsearch-model
   elasticsearch-rails
   factory_bot
-  ffaker
   httparty
   listen
   mailgun-ruby

test/factories/artist_url.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:artist_url) do
     artist
-    url {FFaker::Internet.domain_name}
+    sequence(:url) { |n| "artist_domain_#{n}.com" }
   end
 end

test/factories/ban.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory(:ban) do |f|
-    banner :factory => :admin_user
-    reason {FFaker::Lorem.words.join(" ")}
+    banner factory: :admin_user
+    sequence(:reason) { |n| "ban_reason_#{n}" }
     duration { 60 }
   end
 end

test/factories/blip.rb

@@ -2,6 +2,6 @@ FactoryBot.define do
   factory(:blip) do
     creator
     creator_ip_addr { "127.0.0.1" }
-    body { FFaker::Lorem.sentences.join(" ") }
+    sequence(:body) { |n| "blip_body_#{n}" }
   end
 end

test/factories/comment.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:comment) do
     post { create(:post) }
-    body { FFaker::Lorem.sentences.join(" ") }
+    sequence(:body) { |n| "comment_body_#{n}" }
   end
 end

test/factories/dmail.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory(:dmail) do
-    to :factory => :user
-    title {FFaker::Lorem.words.join(" ")}
-    body {FFaker::Lorem.sentences.join(" ")}
+    to factory: :user
+    sequence(:title) { |n| "dmail_title_#{n}" }
+    sequence(:body) { |n| "dmail_body_#{n}" }
   end
 end

test/factories/forum_post.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
   factory(:forum_post) do
-    body {FFaker::Lorem.sentences.join(" ")}
+    sequence(:body) { |n| "forum_post_body_#{n}" }
   end
 end

test/factories/forum_topic.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:forum_topic) do
-    title { FFaker::Lorem.words.join(" ") }
+    sequence(:title) { |n| "forum_topic_title_#{n}" }
     is_sticky { false }
     is_locked { false }
     category_id { Danbooru.config.alias_implication_forum_category }
@@ -8,7 +8,7 @@ FactoryBot.define do
     creator_ip_addr { "127.0.0.1" }
 
     transient do
-      body { FFaker::Lorem.sentences.join(" ") }
+      sequence(:body) { |n| "forum_topic_body_#{n}" }
     end
 
     after(:build) do |topic, evaluator|

test/factories/ip_ban.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:ip_ban) do
     creator
-    reason { FFaker::Lorem.words.join(" ") }
+    sequence(:reason) { |n| "ip_ban_reason_#{n}" }
   end
 end

test/factories/note.rb

@@ -6,6 +6,6 @@ FactoryBot.define do
     width { 1 }
     height { 1 }
     is_active { true }
-    body { FFaker::Lorem.sentences.join(" ") }
+    sequence(:body) { |n| "note_body_#{n}" }
   end
 end

test/factories/pool.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory(:pool) do
     name {"pool_" + (rand(1_000_000) + 100).to_s}
-    association :creator, :factory => :user
-    description {FFaker::Lorem.sentences.join(" ")}
+    association :creator, factory: :user
+    sequence(:description) { |n| "pool_description_#{n}" }
   end
 end

test/factories/post.rb

@@ -14,7 +14,7 @@ FactoryBot.define do
     file_size { 2000 }
     rating { "q" }
     duration { 0.0 }
-    source { FFaker::Internet.http_url }
+    sequence(:source) { |n| "https://example.com/#{n}" }
 
     after(:create) do |post|
       post.update_index

test/factories/post_disapproval.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:post_disapproval) do
     reason { %w[borderline_quality borderline_relevancy other].sample }
-    message { FFaker::Lorem.sentence }
+    sequence(:message) { |n| "post_disapproval_message_#{n}" }
   end
 end

test/factories/post_replacement.rb

@@ -2,8 +2,8 @@ FactoryBot.define do
   factory(:post_replacement) do
     creator_ip_addr { "127.0.0.1" }
     creator { create(:user, created_at: 2.weeks.ago) }
-    replacement_url { FFaker::Internet.http_url }
-    reason { FFaker::Lorem.words.join(" ") }
+    sequence(:replacement_url) { |n| "https://example.com/#{n}.jpg" }
+    sequence(:reason) { |n| "post_replacement_reason#{n}" }
 
     factory(:webm_replacement) do
       replacement_file do

test/factories/post_set.rb

@@ -2,7 +2,7 @@ FactoryBot.define do
   factory(:post_set) do
     creator
     creator_ip_addr { "127.0.0.1" }
-    name { FFaker::Lorem.words.join(" ") }
-    shortname { FFaker::Lorem.words.join("_") }
+    sequence(:name) { |n| "post_set_name_#{n}" }
+    sequence(:shortname) { |n| "post_set_shortname_#{n}" }
   end
 end

test/factories/tag.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:tag) do
-    name {"#{FFaker::Name.first_name.downcase}#{rand(1000)}"}
+    sequence(:name) { |n| "tag_name_#{n}" }
     post_count { 0 }
     category {Tag.categories.general}
     related_tags { "" }

test/factories/tag_alias.rb

@@ -3,6 +3,6 @@ FactoryBot.define do
     antecedent_name { "aaa" }
     consequent_name { "bbb" }
     status { "active" }
-    creator_ip_addr { FFaker::Internet.ip_v4_address }
+    creator_ip_addr { "127.0.0.1" }
   end
 end

test/factories/user.rb

@@ -6,7 +6,7 @@ FactoryBot.define do
     password { "password" }
     password_confirmation { "password" }
     password_hash {"password"}
-    email {FFaker::Internet.email}
+    sequence(:email) { |n| "user_email_#{n}@example.com" }
     default_image_size { "large" }
     base_upload_limit { 10 }
     level { 20 }
@@ -59,4 +59,3 @@ FactoryBot.define do
     end
   end
 end
-

test/factories/user_feedback.rb

@@ -2,6 +2,6 @@ FactoryBot.define do
   factory(:user_feedback) do
     user
     category { "positive" }
-    body {FFaker::Lorem.words.join(" ")}
+    sequence(:body) { |n| "user_feedback_body_#{n}" }
   end
 end

test/factories/user_name_change_request.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory(:user_name_change_request) do
-    desired_name {FFaker::Internet.user_name}
-    change_reason {FFaker::Lorem.sentence}
+    sequence(:desired_name) { |n| "desired_name_#{n}" }
+    change_reason { "" }
   end
 end

test/factories/wiki_page.rb

@@ -1,7 +1,7 @@
 FactoryBot.define do
   factory(:wiki_page) do
-    creator :factory => :user
-    title {FFaker::Lorem.words.join(" ")}
-    body {FFaker::Lorem.sentences.join(" ")}
+    creator factory: :user
+    sequence(:title) { |n| "wiki_page_title_#{n}" }
+    sequence(:body) { |n| "wiki_page_body_#{n}" }
   end
 end

test/functional/forum_topics_controller_test.rb

@@ -34,8 +34,8 @@ class ForumTopicsControllerTest < ActionDispatch::IntegrationTest
     context "index action" do
       setup do
         as_user do
-          @topic1 = create(:forum_topic, :is_sticky => true, :original_post_attributes => {:body => "xxx"})
-          @topic2 = create(:forum_topic, :original_post_attributes => {:body => "xxx"})
+          @topic1 = create(:forum_topic, title: "a", is_sticky: true, original_post_attributes: { body: "xxx"})
+          @topic2 = create(:forum_topic, title: "b", original_post_attributes: { body: "xxx"})
         end
       end