diff --git a/.rubocop.yml b/.rubocop.yml index 265a99c7a..e068a1cf2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,11 +1,14 @@ <% if ENV["CI"] %> inherit_from: .rubocop_todo.yml +<% end %> + inherit_mode: merge: - Exclude -<% end %> + - Include require: + - rubocop-erb - rubocop-rails AllCops: @@ -13,6 +16,7 @@ AllCops: Exclude: - bin/* - node_modules/**/* + - lib/templates/erb/scaffold/_form.html.erb # TODO: rubocop-erb chokes on this Bundler/OrderedGems: Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 4b0dfb1df..c2232e3f3 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 20000` -# on 2023-02-22 19:25:49 UTC using RuboCop version 1.46.0. +# on 2023-02-23 11:53:27 UTC using RuboCop version 1.46.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -76,11 +76,12 @@ Layout/ClosingParenthesisIndentation: - 'app/models/tag_alias.rb' - 'db/fixes/102_generate_missing_post_version_fields.rb' -# Offense count: 3 +# Offense count: 5 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment. Layout/CommentIndentation: Exclude: + - 'app/views/forum_posts/_listing.html.erb' - 'config/danbooru_default_config.rb' # Offense count: 4 @@ -213,7 +214,7 @@ Layout/EndAlignment: - 'app/models/bulk_update_request.rb' - 'app/models/tag_implication.rb' -# Offense count: 11 +# Offense count: 18 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. Layout/ExtraSpacing: @@ -225,6 +226,13 @@ Layout/ExtraSpacing: - 'app/models/post.rb' - 'app/models/tag.rb' - 'app/models/user_feedback.rb' + - 'app/views/post_approvals/index.html.erb' + - 'app/views/tags/index.html.erb' + - 'app/views/takedowns/show.html.erb' + - 'app/views/upload_whitelists/index.html.erb' + - 'app/views/uploads/index.html.erb' + - 'app/views/user_votes/_common_index.html.erb' + - 'app/views/wiki_pages/show_or_new.html.erb' - 'config.ru' - 'config/initializers/backtrace_silencers.rb' @@ -316,7 +324,7 @@ Layout/IndentationWidth: - 'app/models/user_feedback.rb' - 'test/unit/forum_topic_test.rb' -# Offense count: 34 +# Offense count: 35 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. Layout/LeadingCommentSpace: @@ -324,9 +332,18 @@ Layout/LeadingCommentSpace: - 'app/logical/apng_inspector.rb' - 'app/models/post.rb' - 'app/models/user.rb' + - 'app/views/users/home.html.erb' - 'config/danbooru_default_config.rb' - 'config/unicorn/production.rb' +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Layout/LeadingEmptyLines: + Exclude: + - 'app/views/forum_post_votes/_add_vote.html.erb' + - 'app/views/forum_post_votes/_list.html.erb' + - 'app/views/forum_post_votes/_vote.html.erb' + # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -378,7 +395,14 @@ Layout/RescueEnsureAlignment: Exclude: - 'app/models/post_flag.rb' -# Offense count: 59 +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Layout/SpaceAfterColon: + Exclude: + - 'app/views/users/_statistics.html.erb' + - 'app/views/users/home.html.erb' + +# Offense count: 69 # This cop supports safe autocorrection (--autocorrect). Layout/SpaceAfterComma: Exclude: @@ -391,6 +415,14 @@ Layout/SpaceAfterComma: - 'app/logical/tags_preview.rb' - 'app/presenters/post_presenter.rb' - 'app/serializers/post_serializer.rb' + - 'app/views/admin/danger_zone/index.html.erb' + - 'app/views/mod_actions/_search.html.erb' + - 'app/views/moderator/post/queues/_quick_mod.html.erb' + - 'app/views/post_events/_search.html.erb' + - 'app/views/post_events/index.html.erb' + - 'app/views/posts/partials/show/_video.html.erb' + - 'app/views/stats/index.html.erb' + - 'app/views/users/edit.html.erb' - 'config/danbooru_default_config.rb' # Offense count: 6 @@ -411,7 +443,7 @@ Layout/SpaceAroundKeyword: - 'app/logical/danbooru_logger.rb' - 'test/functional/comments_controller_test.rb' -# Offense count: 48 +# Offense count: 57 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. # SupportedStylesForExponentOperator: space, no_space @@ -428,12 +460,19 @@ Layout/SpaceAroundOperators: - 'app/models/tag_alias.rb' - 'app/models/tag_implication.rb' - 'app/models/user.rb' + - 'app/views/edit_histories/index.html.erb' + - 'app/views/edit_histories/show.html.erb' + - 'app/views/forum_topics/_listing.html.erb' + - 'app/views/static/_footer.html.erb' + - 'app/views/stats/index.html.erb' + - 'app/views/takedowns/show.html.erb' + - 'app/views/uploads/new.html.erb' - 'config.ru' - 'test/unit/post_replacement_test.rb' - 'test/unit/post_test.rb' - 'test/unit/related_tag_calculator_test.rb' -# Offense count: 42 +# Offense count: 44 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space @@ -447,8 +486,25 @@ Layout/SpaceBeforeBlockBraces: - 'app/models/post.rb' - 'app/models/tag_relationship.rb' - 'app/models/user.rb' + - 'app/views/moderator/ip_addrs/_ip_listing.html.erb' + - 'app/views/related_tags/show.html.erb' - 'test/unit/post_replacement_test.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Layout/SpaceBeforeComma: + Exclude: + - 'app/views/moderator/post/queues/_quick_mod.html.erb' + - 'app/views/posts/partials/show/_video.html.erb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowForAlignment. +Layout/SpaceBeforeFirstArg: + Exclude: + - 'app/views/post_approvals/index.html.erb' + - 'app/views/uploads/index.html.erb' + # Offense count: 15 # This cop supports safe autocorrection (--autocorrect). Layout/SpaceBeforeSemicolon: @@ -483,7 +539,7 @@ Layout/SpaceInsideArrayLiteralBrackets: Exclude: - 'config/environments/production.rb' -# Offense count: 462 +# Offense count: 478 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space @@ -536,6 +592,15 @@ Layout/SpaceInsideBlockBraces: - 'app/models/wiki_page.rb' - 'app/presenters/tag_set_presenter.rb' - 'app/presenters/user_presenter.rb' + - 'app/views/admin/danger_zone/index.html.erb' + - 'app/views/comments/_index_by_post.html.erb' + - 'app/views/forum_topics/index.html.erb' + - 'app/views/mod_actions/_search.html.erb' + - 'app/views/moderator/ip_addrs/_ip_listing.html.erb' + - 'app/views/moderator/ip_addrs/_ip_listing.json.erb' + - 'app/views/post_disapprovals/_counts.html.erb' + - 'app/views/post_events/_search.html.erb' + - 'app/views/related_tags/show.html.erb' - 'config/application.rb' - 'config/danbooru_default_config.rb' - 'config/routes.rb' @@ -548,7 +613,7 @@ Layout/SpaceInsideBlockBraces: - 'test/unit/tag_test.rb' - 'test/unit/user_test.rb' -# Offense count: 1233 +# Offense count: 1454 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -617,6 +682,75 @@ Layout/SpaceInsideHashLiteralBraces: - 'app/models/user_name_change_request.rb' - 'app/models/wiki_page.rb' - 'app/presenters/user_presenter.rb' + - 'app/views/admin/users/edit_blacklist.html.erb' + - 'app/views/admin/users/request_password_reset.html.erb' + - 'app/views/artist_versions/_standard_listing.html.erb' + - 'app/views/artists/_form.html.erb' + - 'app/views/artists/_secondary_links.html.erb' + - 'app/views/blips/_form.html.erb' + - 'app/views/blips/index.html.erb' + - 'app/views/blips/partials/index/_list.html.erb' + - 'app/views/blips/partials/show/_blip.html.erb' + - 'app/views/blips/show.html.erb' + - 'app/views/comments/_form.html.erb' + - 'app/views/comments/_index_by_post.html.erb' + - 'app/views/comments/partials/index/_list.html.erb' + - 'app/views/dmails/_secondary_links.html.erb' + - 'app/views/dmails/index.html.erb' + - 'app/views/email_blacklists/index.html.erb' + - 'app/views/forum_posts/_forum_post.html.erb' + - 'app/views/forum_topics/_form.html.erb' + - 'app/views/forum_topics/_secondary_links.html.erb' + - 'app/views/forum_topics/index.html.erb' + - 'app/views/forum_topics/show.html.erb' + - 'app/views/ip_bans/index.html.erb' + - 'app/views/maintenance/user/api_keys/show.html.erb' + - 'app/views/maintenance/user/passwords/edit.html.erb' + - 'app/views/meta_searches/tags.html.erb' + - 'app/views/moderator/dashboards/_activity_artist.html.erb' + - 'app/views/moderator/dashboards/_activity_note.html.erb' + - 'app/views/moderator/dashboards/_activity_tag.html.erb' + - 'app/views/moderator/dashboards/_activity_wiki_page.html.erb' + - 'app/views/moderator/ip_addrs/_ip_listing.html.erb' + - 'app/views/moderator/ip_addrs/_ip_listing.json.erb' + - 'app/views/moderator/ip_addrs/_user_listing.erb' + - 'app/views/moderator/post/queues/_quick_mod.html.erb' + - 'app/views/note_versions/_revert_listing.html.erb' + - 'app/views/note_versions/_standard_listing.html.erb' + - 'app/views/notes/index.html.erb' + - 'app/views/pool_orders/edit.html.erb' + - 'app/views/pool_versions/_revert_listing.html.erb' + - 'app/views/pool_versions/_standard_listing.html.erb' + - 'app/views/pools/_secondary_links.html.erb' + - 'app/views/pools/gallery.html.erb' + - 'app/views/pools/index.html.erb' + - 'app/views/post_replacements/index.html.erb' + - 'app/views/post_report_reasons/index.html.erb' + - 'app/views/post_set_maintainers/_invite_links.html.erb' + - 'app/views/post_sets/_secondary_links.html.erb' + - 'app/views/post_sets/maintainers.html.erb' + - 'app/views/posts/partials/index/_posts.html.erb' + - 'app/views/posts/partials/show/_information.html.erb' + - 'app/views/posts/partials/show/_notices.html.erb' + - 'app/views/posts/partials/show/_options.html.erb' + - 'app/views/tag_relationships/_add_form.html.erb' + - 'app/views/tags/index.html.erb' + - 'app/views/takedowns/_editor.html.erb' + - 'app/views/takedowns/_secondary_links.html.erb' + - 'app/views/takedowns/index.html.erb' + - 'app/views/tickets/_secondary_links.html.erb' + - 'app/views/upload_whitelists/index.html.erb' + - 'app/views/user_feedbacks/_secondary_links.html.erb' + - 'app/views/user_feedbacks/index.html.erb' + - 'app/views/users/_dmail_notice.html.erb' + - 'app/views/users/_secondary_links.html.erb' + - 'app/views/users/_statistics.html.erb' + - 'app/views/users/edit.html.erb' + - 'app/views/users/home.html.erb' + - 'app/views/users/index.html.erb' + - 'app/views/users/new.html.erb' + - 'app/views/wiki_pages/_secondary_links.html.erb' + - 'app/views/wiki_pages/show_or_new.html.erb' - 'config/danbooru_default_config.rb' - 'test/factories/mod_action.rb' - 'test/functional/artists_controller_test.rb' @@ -653,7 +787,7 @@ Layout/SpaceInsideHashLiteralBraces: - 'test/unit/post_replacement_test.rb' - 'test/unit/related_tag_calculator_test.rb' -# Offense count: 24 +# Offense count: 25 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: space, compact, no_space @@ -663,6 +797,7 @@ Layout/SpaceInsideParens: - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/pbkdf2.rb' - 'app/logical/tag_category.rb' + - 'app/views/iqdb_queries/show.html.erb' - 'test/unit/post_test.rb' # Offense count: 3 @@ -688,6 +823,13 @@ Layout/TrailingWhitespace: - 'test/functional/admin/dashboards_controller_test.rb' - 'test/unit/artist_test.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Lint/AmbiguousOperator: + Exclude: + - 'app/views/layouts/blank.html.erb' + - 'app/views/layouts/default.html.erb' + # Offense count: 22 # This cop supports safe autocorrection (--autocorrect). Lint/AmbiguousOperatorPrecedence: @@ -706,6 +848,13 @@ Lint/AssignmentInCondition: - 'app/logical/set_diff.rb' - 'app/models/upload.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: DeprecatedConstants. +Lint/DeprecatedConstants: + Exclude: + - 'app/views/ads/_leaderboard.html.erb' + # Offense count: 20 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. Lint/DuplicateBranch: @@ -837,11 +986,12 @@ Lint/RaiseException: Exclude: - 'app/jobs/post_video_conversion_job.rb' -# Offense count: 1 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). Lint/RedundantStringCoercion: Exclude: - 'app/models/bulk_update_request.rb' + - 'app/views/post_sets/show.html.erb' # Offense count: 7 Lint/RescueException: @@ -853,6 +1003,16 @@ Lint/RescueException: - 'app/models/tag_alias.rb' - 'app/models/tag_implication.rb' +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowedMethods. +# AllowedMethods: present?, blank?, presence, try, try!, in? +Lint/SafeNavigationChain: + Exclude: + - 'app/views/blips/partials/show/_blip.html.erb' + - 'app/views/comments/partials/show/_comment.html.erb' + - 'app/views/forum_posts/_forum_post.html.erb' + # Offense count: 9 # This cop supports safe autocorrection (--autocorrect). Lint/ScriptPermission: @@ -894,7 +1054,7 @@ Lint/SuppressedException: - 'app/models/forum_subscription.rb' - 'app/models/tag.rb' -# Offense count: 21 +# Offense count: 106 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, consistent @@ -906,6 +1066,34 @@ Lint/SymbolConversion: - 'app/helpers/posts_helper.rb' - 'app/models/takedown.rb' - 'app/presenters/post_set_presenters/popular.rb' + - 'app/views/admin/users/request_password_reset.html.erb' + - 'app/views/artist_versions/_standard_listing.html.erb' + - 'app/views/artists/_quick_search.html.erb' + - 'app/views/artists/_secondary_links.html.erb' + - 'app/views/blips/partials/show/_blip.html.erb' + - 'app/views/bulk_update_requests/_bur_edit_links.html.erb' + - 'app/views/comments/partials/index/_list.html.erb' + - 'app/views/favorites/index.html.erb' + - 'app/views/forum_post_votes/_add_vote.html.erb' + - 'app/views/forum_post_votes/_vote.html.erb' + - 'app/views/forum_topics/_secondary_links.html.erb' + - 'app/views/help/_secondary_links.html.erb' + - 'app/views/help/index.html.erb' + - 'app/views/moderator/post/queues/_quick_mod.html.erb' + - 'app/views/note_versions/_revert_listing.html.erb' + - 'app/views/pool_versions/_revert_listing.html.erb' + - 'app/views/pools/_secondary_links.html.erb' + - 'app/views/post_replacements/index.html.erb' + - 'app/views/post_versions/_listing.html.erb' + - 'app/views/posts/index.html.erb' + - 'app/views/posts/partials/common/_search.html.erb' + - 'app/views/posts/partials/index/_related.html.erb' + - 'app/views/posts/partials/show/_notices.html.erb' + - 'app/views/posts/partials/show/_options.html.erb' + - 'app/views/posts/show.html.erb' + - 'app/views/static/home.html.erb' + - 'app/views/takedowns/_editor.html.erb' + - 'app/views/wiki_pages/_secondary_links.html.erb' - 'test/unit/downloads/file_test.rb' # Offense count: 1 @@ -928,7 +1116,7 @@ Lint/UnreachableCode: - 'app/controllers/artists_controller.rb' - 'app/controllers/static_controller.rb' -# Offense count: 65 +# Offense count: 66 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: @@ -940,6 +1128,7 @@ Lint/UnusedBlockArgument: - 'app/logical/storage_manager/local.rb' - 'app/logical/tag_category.rb' - 'app/models/post.rb' + - 'app/views/admin/danger_zone/index.html.erb' - 'config/application.rb' - 'config/initializers/content_security_policy.rb' - 'config/routes.rb' @@ -1014,7 +1203,7 @@ Lint/UselessAssignment: - 'test/unit/tag_implication_test.rb' - 'test/unit/tag_test.rb' -# Offense count: 18 +# Offense count: 14 # Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns. # AllowedMethods: refine Metrics/BlockLength: @@ -1028,8 +1217,6 @@ Metrics/BlockLength: - 'app/models/application_record.rb' - 'app/models/post.rb' - 'app/models/tag.rb' - - 'test/factories/post_replacement.rb' - - 'test/factories/user.rb' # Offense count: 2 # Configuration parameters: CountBlocks, Max. @@ -1237,7 +1424,7 @@ Rails/AssertNot: - 'test/unit/post_test.rb' - 'test/unit/user_test.rb' -# Offense count: 15 +# Offense count: 16 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. Rails/Blank: @@ -1250,6 +1437,7 @@ Rails/Blank: - 'app/models/note.rb' - 'app/models/post.rb' - 'app/models/post_flag.rb' + - 'app/views/moderator/post/posts/confirm_delete.html.erb' # Offense count: 6 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -1261,6 +1449,12 @@ Rails/CompactBlank: - 'app/models/post_replacement.rb' - 'app/models/tag_alias.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Rails/ContentTag: + Exclude: + - 'app/views/posts/partials/show/_flash.html.erb' + # Offense count: 9 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforceForPrefixed. @@ -1366,11 +1560,12 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/tickets_controller.rb' - 'app/controllers/upload_whitelists_controller.rb' -# Offense count: 1 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). Rails/LinkToBlank: Exclude: - 'app/inputs/dtext_input.rb' + - 'app/views/static/_guest_warning.html.erb' # Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -1378,7 +1573,7 @@ Rails/NegateInclude: Exclude: - 'app/logical/storage_manager/match.rb' -# Offense count: 6 +# Offense count: 3 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb @@ -1386,11 +1581,8 @@ Rails/Output: Exclude: - 'app/controllers/application_controller.rb' - 'app/indexes/post_version_index.rb' - - 'db/fixes/101_migrate_mod_actions.rb' - - 'db/fixes/102_generate_missing_post_version_fields.rb' - - 'db/fixes/104_2_add_elasticsearch_replacement_data.rb' -# Offense count: 56 +# Offense count: 85 Rails/OutputSafety: Exclude: - 'app/decorators/posts_decorator.rb' @@ -1406,12 +1598,31 @@ Rails/OutputSafety: - 'app/helpers/text_helper.rb' - 'app/helpers/wiki_pages_helper.rb' - 'app/inputs/dtext_input.rb' + - 'app/javascript/src/javascripts/autocomplete.js.erb' - 'app/presenters/post_set_presenters/base.rb' - 'app/presenters/post_set_presenters/pool.rb' - 'app/presenters/post_set_presenters/pool_gallery.rb' - 'app/presenters/post_set_presenters/popular.rb' - 'app/presenters/tag_set_presenter.rb' - 'app/presenters/user_presenter.rb' + - 'app/views/ads/_leaderboard.html.erb' + - 'app/views/forum_topics/index.html.erb' + - 'app/views/layouts/_head.html.erb' + - 'app/views/moderator/ip_addrs/_ip_listing.json.erb' + - 'app/views/moderator/ip_addrs/_user_listing.json.erb' + - 'app/views/moderator/post/posts/confirm_delete.html.erb' + - 'app/views/post_disapprovals/_counts.html.erb' + - 'app/views/post_sets/_form.html.erb' + - 'app/views/post_sets/show.html.erb' + - 'app/views/posts/show.html.erb' + - 'app/views/static/_deferred_posts.html.erb' + - 'app/views/static/error.json.erb' + - 'app/views/static/home.html.erb' + - 'app/views/tickets/new_types/_post.html.erb' + - 'app/views/uploads/new.html.erb' + - 'app/views/users/custom_style.css.erb' + - 'app/views/users/edit.html.erb' + - 'app/views/users/home.html.erb' # Offense count: 9 # This cop supports safe autocorrection (--autocorrect). @@ -1432,20 +1643,26 @@ Rails/PluralizationGrammar: - 'app/logical/storage_manager.rb' - 'app/models/post_flag.rb' -# Offense count: 2 +# Offense count: 4 # This cop supports safe autocorrection (--autocorrect). Rails/Presence: Exclude: - 'app/indexes/post_index.rb' - 'app/presenters/tag_set_presenter.rb' + - 'app/views/post_replacements/index.html.erb' + - 'app/views/tickets/show.html.erb' -# Offense count: 4 +# Offense count: 13 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. Rails/Present: Exclude: - 'app/controllers/post_sets_controller.rb' - 'app/helpers/posts_helper.rb' + - 'app/views/artists/index.html.erb' + - 'app/views/posts/index.atom.erb' + - 'app/views/takedowns/show.html.erb' + - 'app/views/tickets/show.html.erb' - 'db/fixes/103_fill_new_post_replacement_fields.rb' # Offense count: 1 @@ -1540,7 +1757,7 @@ Rails/WhereExists: - 'test/unit/post_test.rb' - 'test/unit/tag_implication_test.rb' -# Offense count: 14 +# Offense count: 15 # This cop supports safe autocorrection (--autocorrect). Rails/WhereNot: Exclude: @@ -1554,6 +1771,7 @@ Rails/WhereNot: - 'app/models/post.rb' - 'app/models/post_flag.rb' - 'app/models/post_replacement.rb' + - 'app/views/tickets/show.html.erb' # Offense count: 1 Security/Open: @@ -1568,11 +1786,12 @@ Style/Alias: Exclude: - 'app/models/post.rb' -# Offense count: 1 +# Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). Style/ArrayIntersect: Exclude: - 'app/models/user_vote.rb' + - 'app/views/post_replacements/index.html.erb' # Offense count: 6 # This cop supports safe autocorrection (--autocorrect). @@ -1798,7 +2017,7 @@ Style/HashLikeCase: - 'app/models/post.rb' - 'config/initializers/core_extensions.rb' -# Offense count: 856 +# Offense count: 1386 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -1888,6 +2107,145 @@ Style/HashSyntax: - 'app/presenters/post_set_presenters/pool_gallery.rb' - 'app/presenters/post_set_presenters/popular.rb' - 'app/presenters/user_presenter.rb' + - 'app/views/admin/dashboards/show.html.erb' + - 'app/views/admin/reowner/new.html.erb' + - 'app/views/admin/users/password_reset.html.erb' + - 'app/views/artist_versions/index.html.erb' + - 'app/views/artists/_form.html.erb' + - 'app/views/artists/_quick_search.html.erb' + - 'app/views/artists/_secondary_links.html.erb' + - 'app/views/artists/_show.html.erb' + - 'app/views/artists/index.html.erb' + - 'app/views/bans/_form.html.erb' + - 'app/views/bans/index.html.erb' + - 'app/views/bans/new.html.erb' + - 'app/views/bans/show.html.erb' + - 'app/views/blips/_form.html.erb' + - 'app/views/blips/_quick_search.html.erb' + - 'app/views/bulk_update_requests/_bur_edit_links.html.erb' + - 'app/views/bulk_update_requests/_form.html.erb' + - 'app/views/bulk_update_requests/_listing.html.erb' + - 'app/views/bulk_update_requests/index.html.erb' + - 'app/views/comments/_form.html.erb' + - 'app/views/comments/_index_by_post.html.erb' + - 'app/views/comments/_quick_search.html.erb' + - 'app/views/comments/_search.html.erb' + - 'app/views/comments/_secondary_links.html.erb' + - 'app/views/comments/partials/index/_list.html.erb' + - 'app/views/comments/partials/show/_comment.html.erb' + - 'app/views/dmails/_form.html.erb' + - 'app/views/dmails/_quick_search.html.erb' + - 'app/views/dmails/_secondary_links.html.erb' + - 'app/views/dmails/index.html.erb' + - 'app/views/dmails/new.html.erb' + - 'app/views/dmails/show.html.erb' + - 'app/views/favorites/index.html.erb' + - 'app/views/forum_posts/_forum_post.html.erb' + - 'app/views/forum_posts/_listing.html.erb' + - 'app/views/forum_posts/_quick_search.html.erb' + - 'app/views/forum_posts/edit.html.erb' + - 'app/views/forum_posts/index.html.erb' + - 'app/views/forum_posts/new.html.erb' + - 'app/views/forum_posts/partials/new/_form.html.erb' + - 'app/views/forum_posts/show.html.erb' + - 'app/views/forum_topics/_form.html.erb' + - 'app/views/forum_topics/_listing.html.erb' + - 'app/views/forum_topics/_secondary_links.html.erb' + - 'app/views/forum_topics/edit.html.erb' + - 'app/views/forum_topics/index.html.erb' + - 'app/views/forum_topics/new.html.erb' + - 'app/views/forum_topics/show.html.erb' + - 'app/views/ip_bans/index.html.erb' + - 'app/views/iqdb_queries/show.html.erb' + - 'app/views/layouts/_head.html.erb' + - 'app/views/layouts/_main_links.html.erb' + - 'app/views/maintenance/user/api_keys/show.html.erb' + - 'app/views/maintenance/user/deletions/show.html.erb' + - 'app/views/maintenance/user/dmail_filters/edit.html.erb' + - 'app/views/maintenance/user/email_changes/new.html.erb' + - 'app/views/maintenance/user/email_notifications/show.html.erb' + - 'app/views/maintenance/user/login_reminders/new.html.erb' + - 'app/views/maintenance/user/password_reset_mailer/confirmation.html.erb' + - 'app/views/maintenance/user/password_reset_mailer/reset_request.html.erb' + - 'app/views/maintenance/user/password_resets/edit.html.erb' + - 'app/views/maintenance/user/password_resets/new.html.erb' + - 'app/views/maintenance/user/passwords/edit.html.erb' + - 'app/views/meta_searches/tags.html.erb' + - 'app/views/moderator/dashboards/_activity_artist.html.erb' + - 'app/views/moderator/dashboards/_activity_note.html.erb' + - 'app/views/moderator/dashboards/_activity_tag.html.erb' + - 'app/views/moderator/dashboards/_activity_upload.html.erb' + - 'app/views/moderator/dashboards/_activity_wiki_page.html.erb' + - 'app/views/moderator/dashboards/_search_activity.html.erb' + - 'app/views/moderator/dashboards/_search_ip_addr.html.erb' + - 'app/views/moderator/ip_addrs/_user_listing.erb' + - 'app/views/moderator/post/posts/confirm_delete.html.erb' + - 'app/views/moderator/post/posts/confirm_move_favorites.html.erb' + - 'app/views/news_updates/index.html.erb' + - 'app/views/note_versions/_revert_listing.html.erb' + - 'app/views/notes/_quick_search.html.erb' + - 'app/views/notes/_search.html.erb' + - 'app/views/notes/_secondary_links.html.erb' + - 'app/views/pool_elements/_new.html.erb' + - 'app/views/pool_orders/edit.html.erb' + - 'app/views/pool_versions/_revert_listing.html.erb' + - 'app/views/pool_versions/_standard_listing.html.erb' + - 'app/views/pools/_quick_search.html.erb' + - 'app/views/pools/_search.html.erb' + - 'app/views/pools/_secondary_links.html.erb' + - 'app/views/pools/edit.html.erb' + - 'app/views/pools/index.html.erb' + - 'app/views/pools/new.html.erb' + - 'app/views/pools/show.html.erb' + - 'app/views/post_favorites/index.html.erb' + - 'app/views/post_versions/_listing.html.erb' + - 'app/views/post_versions/index.html.erb' + - 'app/views/posts/_blank.html.erb' + - 'app/views/posts/index.html.erb' + - 'app/views/posts/partials/common/_search.html.erb' + - 'app/views/posts/partials/index/_blacklist.html.erb' + - 'app/views/posts/partials/index/_edit.html.erb' + - 'app/views/posts/partials/index/_related.html.erb' + - 'app/views/posts/partials/show/_edit.html.erb' + - 'app/views/posts/partials/show/_information.html.erb' + - 'app/views/posts/partials/show/_nav_links.html.erb' + - 'app/views/posts/partials/show/_options.html.erb' + - 'app/views/posts/partials/show/_search_seq.html.erb' + - 'app/views/posts/partials/show/_video.html.erb' + - 'app/views/posts/show.html.erb' + - 'app/views/related_tags/show.html.erb' + - 'app/views/sessions/new.html.erb' + - 'app/views/static/_footer.html.erb' + - 'app/views/static/access_denied.html.erb' + - 'app/views/tag_aliases/edit.html.erb' + - 'app/views/tag_aliases/show.html.erb' + - 'app/views/tag_corrections/new.html.erb' + - 'app/views/tag_implications/edit.html.erb' + - 'app/views/tag_implications/show.html.erb' + - 'app/views/tags/_quick_search.html.erb' + - 'app/views/tags/edit.html.erb' + - 'app/views/tags/index.html.erb' + - 'app/views/tags/show.html.erb' + - 'app/views/user_feedbacks/_secondary_links.html.erb' + - 'app/views/user_feedbacks/index.html.erb' + - 'app/views/user_mailer/dmail_notice.html.erb' + - 'app/views/user_mailer/forum_notice.html.erb' + - 'app/views/users/_dmail_notice.html.erb' + - 'app/views/users/_post_summary.html.erb' + - 'app/views/users/_quick_search.html.erb' + - 'app/views/users/_secondary_links.html.erb' + - 'app/views/users/_statistics.html.erb' + - 'app/views/users/edit.html.erb' + - 'app/views/users/index.html.erb' + - 'app/views/users/new.html.erb' + - 'app/views/users/show.html.erb' + - 'app/views/wiki_page_versions/_page_listing.html.erb' + - 'app/views/wiki_pages/_form.html.erb' + - 'app/views/wiki_pages/_quick_search.html.erb' + - 'app/views/wiki_pages/_recent_changes.html.erb' + - 'app/views/wiki_pages/_secondary_links.html.erb' + - 'app/views/wiki_pages/show.html.erb' + - 'app/views/wiki_pages/show_or_new.html.erb' - 'config/initializers/secret_token.rb' - 'config/initializers/unicorn.rb' - 'config/routes.rb' @@ -1936,6 +2294,12 @@ Style/HashSyntax: - 'test/unit/user_revert_test.rb' - 'test/unit/wiki_page_test.rb' +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/HashTransformKeys: + Exclude: + - 'app/views/tickets/show.html.erb' + # Offense count: 6 # This cop supports unsafe autocorrection (--autocorrect-all). Style/HashTransformValues: @@ -2001,7 +2365,7 @@ Style/MapToHash: - 'app/presenters/tag_set_presenter.rb' - 'app/presenters/user_presenter.rb' -# Offense count: 11 +# Offense count: 12 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods, AllowedPatterns. Style/MethodCallWithoutArgsParentheses: @@ -2010,6 +2374,7 @@ Style/MethodCallWithoutArgsParentheses: - 'app/indexes/post_version_index.rb' - 'app/models/post.rb' - 'app/models/post_set.rb' + - 'app/views/sessions/new.html.erb' - 'config/initializers/unicorn.rb' # Offense count: 1 @@ -2062,7 +2427,7 @@ Style/MutableConstant: - 'app/models/user.rb' - 'test/unit/storage_manager_test.rb' -# Offense count: 33 +# Offense count: 34 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: both, prefix, postfix @@ -2090,8 +2455,9 @@ Style/NegatedIf: - 'app/models/post_replacement.rb' - 'app/models/upload.rb' - 'app/models/user_password_reset_nonce.rb' + - 'app/views/posts/partials/show/_options.html.erb' -# Offense count: 4 +# Offense count: 7 # This cop supports safe autocorrection (--autocorrect). Style/NegatedIfElseCondition: Exclude: @@ -2099,6 +2465,9 @@ Style/NegatedIfElseCondition: - 'app/controllers/post_votes_controller.rb' - 'app/models/dmail.rb' - 'app/models/user_feedback.rb' + - 'app/views/posts/show.html.erb' + - 'app/views/tickets/show.html.erb' + - 'app/views/uploads/new.html.erb' # Offense count: 5 # This cop supports safe autocorrection (--autocorrect). @@ -2137,7 +2506,7 @@ Style/NumericLiteralPrefix: Exclude: - 'app/logical/storage_manager/local.rb' -# Offense count: 14 +# Offense count: 17 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinDigits, Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: @@ -2147,10 +2516,21 @@ Style/NumericLiterals: - 'app/logical/elastic_post_query_builder.rb' - 'app/logical/pbkdf2.rb' - 'app/models/tag.rb' + - 'app/views/ads/_leaderboard.html.erb' + - 'app/views/takedowns/new.html.erb' + - 'app/views/upload_whitelists/_secondary_links.html.erb' - 'config/danbooru_default_config.rb' - 'test/functional/application_controller_test.rb' - 'test/unit/tag_test.rb' +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns. +# SupportedStyles: predicate, comparison +Style/NumericPredicate: + Exclude: + - 'app/views/users/_statistics.html.erb' + # Offense count: 8 # Configuration parameters: AllowedMethods. # AllowedMethods: respond_to_missing? @@ -2179,7 +2559,7 @@ Style/ParenthesesAroundCondition: - 'app/controllers/users_controller.rb' - 'app/models/post_flag.rb' -# Offense count: 79 +# Offense count: 86 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: @@ -2204,6 +2584,9 @@ Style/PercentLiteralDelimiters: - 'app/models/user_name_change_request.rb' - 'app/presenters/tag_set_presenter.rb' - 'app/presenters/user_presenter.rb' + - 'app/views/blips/_search.html.erb' + - 'app/views/comments/_search.html.erb' + - 'app/views/uploads/index.html.erb' - 'config/danbooru_default_config.rb' - 'config/initializers/content_security_policy.rb' - 'test/unit/bulk_update_importer_importer_test.rb' @@ -2326,22 +2709,25 @@ Style/RedundantFetchBlock: Exclude: - 'config/puma.rb' -# Offense count: 4 +# Offense count: 5 # This cop supports unsafe autocorrection (--autocorrect-all). Style/RedundantInterpolation: Exclude: - 'app/decorators/post_event_decorator.rb' - 'app/helpers/users_helper.rb' - 'app/jobs/post_video_conversion_job.rb' + - 'app/views/help/index.html.erb' - 'db/fixes/102_generate_missing_post_version_fields.rb' -# Offense count: 5 +# Offense count: 8 # This cop supports safe autocorrection (--autocorrect). Style/RedundantParentheses: Exclude: - 'app/models/forum_post.rb' - 'app/models/post.rb' - 'app/models/tag.rb' + - 'app/views/takedowns/show.html.erb' + - 'app/views/tickets/show.html.erb' # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). @@ -2443,7 +2829,7 @@ Style/RedundantStringEscape: - 'app/models/ticket.rb' - 'test/unit/user_test.rb' -# Offense count: 29 +# Offense count: 31 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, AllowInnerSlashes. # SupportedStyles: slashes, percent_r, mixed @@ -2459,6 +2845,8 @@ Style/RegexpLiteral: - 'app/models/artist.rb' - 'app/models/artist_url.rb' - 'app/models/upload_whitelist.rb' + - 'app/views/takedowns/index.html.erb' + - 'app/views/takedowns/show.html.erb' # Offense count: 9 # This cop supports safe autocorrection (--autocorrect). @@ -2486,7 +2874,7 @@ Style/RescueStandardError: - 'app/models/post_flag.rb' - 'db/fixes/101_migrate_mod_actions.rb' -# Offense count: 37 +# Offense count: 39 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength. # AllowedMethods: present?, blank?, presence, try, try! @@ -2513,6 +2901,8 @@ Style/SafeNavigation: - 'app/models/takedown.rb' - 'app/models/user.rb' - 'app/serializers/post_serializer.rb' + - 'app/views/help/_secondary_links.html.erb' + - 'app/views/post_sets/_secondary_links.html.erb' # Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -2574,7 +2964,7 @@ Style/StderrPuts: Exclude: - 'app/controllers/application_controller.rb' -# Offense count: 53 +# Offense count: 58 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: @@ -2601,13 +2991,17 @@ Style/StringConcatenation: - 'app/models/tag.rb' - 'app/models/tag_alias.rb' - 'app/models/tag_implication.rb' + - 'app/views/edit_histories/show.html.erb' + - 'app/views/moderator/post/posts/confirm_delete.html.erb' + - 'app/views/post_sets/show.html.erb' + - 'app/views/posts/show.html.erb' - 'config/environment.rb' - 'test/factories/pool.rb' - 'test/unit/bulk_update_importer_importer_test.rb' - 'test/unit/bulk_update_request_test.rb' - 'test/unit/post_test.rb' -# Offense count: 934 +# Offense count: 1186 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -2716,6 +3110,58 @@ Style/StringLiterals: - 'app/presenters/post_set_presenters/popular.rb' - 'app/presenters/tag_set_presenter.rb' - 'app/serializers/post_serializer.rb' + - 'app/views/admin/reowner/new.html.erb' + - 'app/views/admin/users/request_password_reset.html.erb' + - 'app/views/artists/_form.html.erb' + - 'app/views/artists/_secondary_links.html.erb' + - 'app/views/bans/_form.html.erb' + - 'app/views/blips/partials/show/_blip.html.erb' + - 'app/views/comments/partials/index/_list.html.erb' + - 'app/views/comments/partials/show/_comment.html.erb' + - 'app/views/dmails/show.html.erb' + - 'app/views/forum_categories/index.html.erb' + - 'app/views/forum_post_votes/_vote.html.erb' + - 'app/views/forum_posts/_forum_post.html.erb' + - 'app/views/help/_form.html.erb' + - 'app/views/help/_secondary_links.html.erb' + - 'app/views/moderator/ip_addrs/_ip_listing.html.erb' + - 'app/views/moderator/ip_addrs/_user_listing.erb' + - 'app/views/moderator/post/queues/_quick_mod.html.erb' + - 'app/views/note_versions/_revert_listing.html.erb' + - 'app/views/pool_versions/_revert_listing.html.erb' + - 'app/views/pools/_secondary_links.html.erb' + - 'app/views/post_replacements/index.html.erb' + - 'app/views/post_sets/_form.html.erb' + - 'app/views/post_sets/_search.html.erb' + - 'app/views/post_sets/_secondary_links.html.erb' + - 'app/views/post_sets/index.html.erb' + - 'app/views/post_sets/post_list.erb' + - 'app/views/post_versions/_listing.html.erb' + - 'app/views/posts/index.html.erb' + - 'app/views/posts/partials/index/_posts.html.erb' + - 'app/views/posts/partials/show/_embedded.html.erb' + - 'app/views/posts/partials/show/_notices.html.erb' + - 'app/views/posts/partials/show/_options.html.erb' + - 'app/views/posts/partials/show/_video.html.erb' + - 'app/views/posts/show.html.erb' + - 'app/views/static/discord.html.erb' + - 'app/views/static/home.html.erb' + - 'app/views/stats/index.html.erb' + - 'app/views/tag_type_versions/index.html.erb' + - 'app/views/takedowns/_editor.html.erb' + - 'app/views/takedowns/_search.html.erb' + - 'app/views/takedowns/_secondary_links.html.erb' + - 'app/views/takedowns/index.html.erb' + - 'app/views/takedowns/new.html.erb' + - 'app/views/tickets/_secondary_links.html.erb' + - 'app/views/tickets/index.html.erb' + - 'app/views/tickets/new.html.erb' + - 'app/views/tickets/show.html.erb' + - 'app/views/uploads/new.html.erb' + - 'app/views/users/_secondary_links.html.erb' + - 'app/views/users/home.html.erb' + - 'app/views/users/new.html.erb' + - 'app/views/wiki_pages/_secondary_links.html.erb' - 'config.ru' - 'config/application.rb' - 'config/danbooru_default_config.rb' @@ -2875,7 +3321,7 @@ Style/StructInheritance: - 'app/logical/moderator/dashboard/queries/upload.rb' - 'app/logical/moderator/dashboard/queries/wiki_page.rb' -# Offense count: 119 +# Offense count: 120 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize. # SupportedStyles: percent, brackets @@ -2930,13 +3376,14 @@ Style/SymbolArray: - 'app/models/user.rb' - 'app/models/user_name_change_request.rb' - 'app/models/wiki_page.rb' + - 'app/views/takedowns/_editor.html.erb' - 'config/initializers/filter_parameter_logging.rb' - 'config/routes.rb' - 'test/factories/user.rb' - 'test/unit/post_event_test.rb' - 'test/unit/storage_manager_test.rb' -# Offense count: 21 +# Offense count: 22 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. # AllowedMethods: define_method, mail, respond_to @@ -2958,6 +3405,7 @@ Style/SymbolProc: - 'app/models/artist_url.rb' - 'app/models/post.rb' - 'app/models/user.rb' + - 'app/views/comments/_index_by_post.html.erb' - 'db/fixes/100_new_iqdb_import.rb' - 'test/factories/post.rb' @@ -3090,7 +3538,7 @@ Style/WhileUntilModifier: Exclude: - 'app/logical/user_deletion.rb' -# Offense count: 31 +# Offense count: 85 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize, WordRegex. # SupportedStyles: percent, brackets @@ -3105,6 +3553,21 @@ Style/WordArray: - 'app/models/post_replacement.rb' - 'app/models/post_set_maintainer.rb' - 'app/models/takedown.rb' + - 'app/views/artist_urls/index.html.erb' + - 'app/views/bulk_update_requests/_search.html.erb' + - 'app/views/notes/_search.html.erb' + - 'app/views/pools/_search.html.erb' + - 'app/views/pools/edit.html.erb' + - 'app/views/pools/new.html.erb' + - 'app/views/post_flags/_search.html.erb' + - 'app/views/post_replacements/_search.html.erb' + - 'app/views/post_sets/maintainers.html.erb' + - 'app/views/post_versions/_search.html.erb' + - 'app/views/tag_relationships/_search.html.erb' + - 'app/views/tags/edit.html.erb' + - 'app/views/takedowns/_editor.html.erb' + - 'app/views/user_feedbacks/_form.html.erb' + - 'app/views/users/edit.html.erb' - 'config/danbooru_default_config.rb' - 'db/fixes/103_fill_new_post_replacement_fields.rb' - 'test/unit/post_test.rb' @@ -3112,7 +3575,7 @@ Style/WordArray: - 'test/unit/tag_alias_test.rb' - 'test/unit/tag_test.rb' -# Offense count: 20 +# Offense count: 22 # This cop supports unsafe autocorrection (--autocorrect-all). Style/ZeroLengthPredicate: Exclude: @@ -3130,3 +3593,5 @@ Style/ZeroLengthPredicate: - 'app/models/post_set.rb' - 'app/models/tag.rb' - 'app/models/tag_alias.rb' + - 'app/views/post_disapprovals/_counts.html.erb' + - 'app/views/post_versions/index.html.erb' diff --git a/Gemfile b/Gemfile index c8222d1eb..2438e6e7f 100644 --- a/Gemfile +++ b/Gemfile @@ -53,6 +53,7 @@ end group :docker do gem "rubocop", require: false + gem "rubocop-erb", require: false gem "rubocop-rails", require: false gem "solargraph", require: false end diff --git a/Gemfile.lock b/Gemfile.lock index e2c8af94d..9a88453ab 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -89,6 +89,13 @@ GEM backport (1.2.0) bcrypt (3.1.18) benchmark (0.2.0) + better_html (2.0.1) + actionview (>= 6.0) + activesupport (>= 6.0) + ast (~> 2.0) + erubi (~> 1.4) + parser (>= 2.4) + smart_properties bootsnap (1.13.0) msgpack (~> 1.2) brpoplpush-redis_script (0.1.2) @@ -306,6 +313,9 @@ GEM unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.26.0) parser (>= 3.2.1.0) + rubocop-erb (0.2.3) + better_html + rubocop (~> 1.45) rubocop-rails (2.17.4) activesupport (>= 4.2.0) rack (>= 1.1) @@ -330,6 +340,7 @@ GEM simple_form (5.1.0) actionpack (>= 5.2) activemodel (>= 5.2) + smart_properties (1.17.0) solargraph (0.47.2) backport (~> 1.2) benchmark @@ -414,6 +425,7 @@ DEPENDENCIES responders retriable rubocop + rubocop-erb rubocop-rails ruby-vips shoulda-context