edshot99/eBooru
1
0
Fork 0
forked from e621ng/e621ng
Code Issues 11 Releases 1 Activity

[Tests] Fix disapproval tests

Browse Source 
Also updates the reason search dropdown
This commit is contained in:
Earlopain 2022-03-16 15:55:24 +01:00
parent dd8aa8199b
commit 2b84f3a4cd
No known key found for this signature in database
GPG Key ID: 6CFB948E15246897
4 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/moderator/post/disapprovals/index.html.erb
View File

@ -7,7 +7,7 @@
<%= f.input :post_id, label: "Post ID", input_html: { value: params[:search][:post_id] } %>
<%= f.input :post_tags_match, label: "Tags", input_html: { value: params[:search][:post_tags_match], data: { autocomplete: "tag-query" } } %>
<%= f.input :message_matches, label: "Message", input_html: { value: params[:search][:message_matches] } %>
<%= f.input :reason, label: "Reason", collection: %w[breaks_rules disinterest poor_quality].map { |x| [x.humanize, x] }, include_blank: true, selected: params[:search][:reason] %>
<%= f.input :reason, label: "Reason", collection: %w[borderline_quality borderline_relevancy other].map { |x| [x.humanize, x] }, include_blank: true, selected: params[:search][:reason] %>
<%= f.input :has_message, label: "Has Message?", collection: %w[Yes No], include_blank: true, selected: params[:search][:has_message] %>
<%= f.input :order, collection: [["ID", "id_desc"], ["Post ID", "post_id_desc"]], selected: params[:search][:order] %>
<%= f.submit "Search" %>

2
test/factories/post_disapproval.rb
View File

@ -1,6 +1,6 @@
FactoryBot.define do
factory(:post_disapproval) do
reason { %w(breaks_rules poor_quality disinterest).sample }
reason { %w[borderline_quality borderline_relevancy other].sample }
message { FFaker::Lorem.sentence }
end
end

3
test/functional/moderator/post/disapprovals_controller_test.rb
View File

@ -5,6 +5,7 @@ module Moderator
class DisapprovalsControllerTest < ActionDispatch::IntegrationTest
context "The moderator post disapprovals controller" do
setup do
@user = create(:user)
@admin = create(:admin_user)
as_user do
@post = create(:post, :is_pending => true)
@ -16,7 +17,7 @@ module Moderator
context "create action" do
should "render" do
assert_difference("PostDisapproval.count", 1) do
post_auth moderator_post_disapprovals_path, @admin, params: { post_disapproval: { post_id: @post.id, reason: "breaks_rules" }, format: "js" }
post_auth moderator_post_disapprovals_path, @admin, params: { post_disapproval: { post_id: @post.id, reason: "borderline_quality" }, format: :json }
end
assert_response :success
end

8
test/unit/post_disapproval_test.rb
View File

@ -21,11 +21,11 @@ class PostDisapprovalTest < ActiveSupport::TestCase
context "#search" do
should "work" do
disapproval1 = FactoryBot.create(:post_disapproval, user: @alice, post: @post_1, reason: "breaks_rules")
disapproval2 = FactoryBot.create(:post_disapproval, user: @alice, post: @post_2, reason: "poor_quality", message: "bad anatomy")
disapproval1 = FactoryBot.create(:post_disapproval, user: @alice, post: @post_1, reason: "borderline_quality")
disapproval2 = FactoryBot.create(:post_disapproval, user: @alice, post: @post_2, reason: "borderline_relevancy", message: "looks human")
assert_equal([disapproval1.id], PostDisapproval.search(reason: "breaks_rules").pluck(:id))
assert_equal([disapproval2.id], PostDisapproval.search(message: "bad anatomy").pluck(:id))
assert_equal([disapproval1.id], PostDisapproval.search(reason: "borderline_quality").pluck(:id))
assert_equal([disapproval2.id], PostDisapproval.search(message: "looks human").pluck(:id))
assert_equal([disapproval2.id, disapproval1.id], PostDisapproval.search(creator_name: "alice").pluck(:id))
end
end