From 62d70163ed30a309ce8d8616532f322183cf7a53 Mon Sep 17 00:00:00 2001
From: Earlopain <earlopain@protonmail.com>
Date: Sat, 30 Oct 2021 12:00:38 +0200
Subject: [PATCH 1/2] [Tickets] Fix layout on index page

---
 app/views/tickets/index.html.erb | 100 +++++++++++++++----------------
 1 file changed, 48 insertions(+), 52 deletions(-)

diff --git a/app/views/tickets/index.html.erb b/app/views/tickets/index.html.erb
index 06e515298..ec62f58eb 100644
--- a/app/views/tickets/index.html.erb
+++ b/app/views/tickets/index.html.erb
@@ -1,62 +1,58 @@
 <div id="c-tickets">
   <div id="a-index">
+    <%= render partial: 'search' %>
 
-  </div>
-</div>
-
-<%= render partial: 'search' %>
-
-<h2>Ticket Center</h2>
-<table class="valign striped">
-	<thead>
-		<tr>
-			<th style="width:5%">ID</th>
-			<% if CurrentUser.is_admin? %>
-			<th style="width:10%">Reporter</th>
-      <th style="width:10%">Claimed By</th>
-			<% end %>
-			<th style="width:15%">Type</th>
-			<th style="width:25%">Subject</th>
-			<th style="width:8%">Status</th>
-			<th style="width:10%">Updated</th>
-			<th style="width:18%">Created</th>
-		</tr>
-	</thead>
-
-	<tbody>
-		<% @tickets.each do |ticket| %>
-			<tr data-link="<%= ticket_path(ticket) %>">
-				<td><%= link_to ticket.id, ticket_path(ticket) %></td>
-				<% if CurrentUser.is_admin? %>
-				<td>
-					<%= link_to_user ticket.creator %>
-				</td>
-        <td>
-          <% if ticket.claimant.nil? %>
-            <span class="redtext">Unclaimed</span>
-          <% else %>
-            <%= link_to_user ticket.claimant %>
+    <h2>Ticket Center</h2>
+    <table class="valign striped">
+      <thead>
+        <tr>
+          <th style="width:5%">ID</th>
+          <% if CurrentUser.is_admin? %>
+            <th style="width:10%">Reporter</th>
+            <th style="width:10%">Claimed By</th>
           <% end %>
-        </td>
-				<% end %>
-				<td><%= link_to ticket.type_title, ticket_path(ticket) %></td>
+          <th style="width:15%">Type</th>
+          <th style="width:25%">Subject</th>
+          <th style="width:8%">Status</th>
+          <th style="width:10%">Updated</th>
+          <th style="width:18%">Created</th>
+        </tr>
+      </thead>
 
-				<% if !ticket.can_see_reason?(CurrentUser.user) %>
-					<td><span style="cursor:help;" class="redtext" title="Due to privacy concerns, this information is confidential">Confidential</span></td>
-				<% else %>
-					<td class="ticket-subject" title="<%= h(truncate(strip_dtext(ticket.reason), length: 200)) %>"><%= link_to h(strip_dtext(truncate(ticket.subject, length: 200))), action: "show", id: ticket.id %></td>
-				<% end %>
+      <tbody>
+        <% @tickets.each do |ticket| %>
+          <tr data-link="<%= ticket_path(ticket) %>">
+            <td><%= link_to ticket.id, ticket_path(ticket) %></td>
+            <% if CurrentUser.is_admin? %>
+              <td><%= link_to_user ticket.creator %></td>
+            <td>
+            <% if ticket.claimant.nil? %>
+              <span class="redtext">Unclaimed</span>
+            <% else %>
+              <%= link_to_user ticket.claimant %>
+            <% end %>
+            </td>
+            <% end %>
+            <td><%= link_to ticket.type_title, ticket_path(ticket) %></td>
 
-				<td class="<%= ticket.status %>-ticket"><%= pretty_ticket_status(ticket) %></td>
-				<td style="cursor:help;" title="<%= ticket.updated_at.strftime("%b %d, %Y %I:%M %p") %>"><%= time_ago_in_words(ticket.updated_at) %> ago</td>
-				<td style="cursor:help;" title="<%= ticket.created_at.strftime("%b %d, %Y %I:%M %p") %>"><%= time_ago_in_words(ticket.created_at) %> ago</td>
-			</tr>
-		<% end %>
-	</tbody>
-</table>
+            <% if !ticket.can_see_reason?(CurrentUser.user) %>
+              <td><span style="cursor:help;" class="redtext" title="Due to privacy concerns, this information is confidential">Confidential</span></td>
+            <% else %>
+              <td class="ticket-subject" title="<%= h(truncate(strip_dtext(ticket.reason), length: 200)) %>"><%= link_to h(strip_dtext(truncate(ticket.subject, length: 200))), action: "show", id: ticket.id %></td>
+            <% end %>
 
-<div id="paginator">
-  <%= numbered_paginator(@tickets) %>
+            <td class="<%= ticket.status %>-ticket"><%= pretty_ticket_status(ticket) %></td>
+            <td style="cursor:help;" title="<%= ticket.updated_at.strftime("%b %d, %Y %I:%M %p") %>"><%= time_ago_in_words(ticket.updated_at) %> ago</td>
+            <td style="cursor:help;" title="<%= ticket.created_at.strftime("%b %d, %Y %I:%M %p") %>"><%= time_ago_in_words(ticket.created_at) %> ago</td>
+          </tr>
+        <% end %>
+      </tbody>
+    </table>
+
+    <div id="paginator">
+      <%= numbered_paginator(@tickets) %>
+    </div>
+  </div>
 </div>
 
 <% render partial: 'secondary_links' %>

From 25ee68658fae7223e59d20f58970694e2f4906ca Mon Sep 17 00:00:00 2001
From: Earlopain <earlopain@protonmail.com>
Date: Sat, 30 Oct 2021 12:23:11 +0200
Subject: [PATCH 2/2] [Tickets] Make the whole subject cell clickable

---
 app/javascript/src/styles/common/tables.scss | 10 ++++++++++
 app/views/tickets/index.html.erb             |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/app/javascript/src/styles/common/tables.scss b/app/javascript/src/styles/common/tables.scss
index f3c937eee..7ddd6f836 100644
--- a/app/javascript/src/styles/common/tables.scss
+++ b/app/javascript/src/styles/common/tables.scss
@@ -13,6 +13,16 @@ table.table {
     tr {
       td {
         padding: $padding-050 $padding-025;
+
+        &.full-width-link {
+          padding: 0;
+
+          > a {
+            width: 100%;
+            display: inline-block;
+            padding: $padding-050 $padding-025;
+          }
+        }
       }
       @include themable {
         background-color: themed("color-section");
diff --git a/app/views/tickets/index.html.erb b/app/views/tickets/index.html.erb
index ec62f58eb..5ac02ffd1 100644
--- a/app/views/tickets/index.html.erb
+++ b/app/views/tickets/index.html.erb
@@ -38,7 +38,7 @@
             <% if !ticket.can_see_reason?(CurrentUser.user) %>
               <td><span style="cursor:help;" class="redtext" title="Due to privacy concerns, this information is confidential">Confidential</span></td>
             <% else %>
-              <td class="ticket-subject" title="<%= h(truncate(strip_dtext(ticket.reason), length: 200)) %>"><%= link_to h(strip_dtext(truncate(ticket.subject, length: 200))), action: "show", id: ticket.id %></td>
+              <td class="ticket-subject full-width-link" title="<%= h(truncate(strip_dtext(ticket.reason), length: 200)) %>"><%= link_to h(strip_dtext(truncate(ticket.subject, length: 200))), action: "show", id: ticket.id %></td>
             <% end %>
 
             <td class="<%= ticket.status %>-ticket"><%= pretty_ticket_status(ticket) %></td>