[Docker] Remove node_modules volume

My intention was to share it between the test/main service (I think).
But since it's using the main one as a base anways it's already there.
This volume overlays on the one from newer builds, hiding js package changes.

public_packs_test is unused as well, remove.

Dockerfile

@@ -10,6 +10,10 @@ RUN git config --global --add safe.directory /app
 ENV LD_PRELOAD=/usr/lib/libjemalloc.so.2
 
 # Install js packages and gems
+# Put node_modules outside the app volume. Having node_modules be a named volume
+# means that on subsequent package changes the named volume will overlay the newly
+# installed packages. Not needed for gems since they already install somewhere else.
+ENV NODE_PATH=/node_modules
 COPY package.json yarn.lock ./
 RUN yarn install
 

docker-compose.yml

@@ -30,7 +30,6 @@ services:
     image: e621
     volumes:
       - .:/app
-      - node_modules:/app/node_modules
       - public_packs:/app/public/packs
       - post_data:/app/public/data
     environment:
@@ -118,7 +117,6 @@ services:
       VIPS_WARNING: "0"
     volumes:
       - .:/app
-      - node_modules:/app/node_modules
     depends_on:
       <<: *common-depends-on
     entrypoint: bundle exec rails test
@@ -150,6 +148,4 @@ volumes:
   elastic_data:
   db_data:
   redis_data:
-  node_modules:
   public_packs:
-  public_packs_test: