eBooru/test/functional/iqdb_queries_controller_test.rb

43 lines
1.5 KiB
Ruby
Raw Permalink Normal View History

# frozen_string_literal: true
require "test_helper"
Raise error on unpermitted params. Fail loudly if we forget to whitelist a param instead of silently ignoring it. misc models: convert to strong params. artist commentaries: convert to strong params. * Disallow changing or setting post_id to a nonexistent post. artists: convert to strong params. * Disallow setting `is_banned` in create/update actions. Changing it this way instead of with the ban/unban actions would leave the artist in a partially banned state. bans: convert to strong params. * Disallow changing the user_id after the ban has been created. comments: convert to strong params. favorite groups: convert to strong params. news updates: convert to strong params. post appeals: convert to strong params. post flags: convert to strong params. * Disallow users from setting the `is_deleted` / `is_resolved` flags. ip bans: convert to strong params. user feedbacks: convert to strong params. * Disallow users from setting `disable_dmail_notification` when creating feedbacks. * Disallow changing the user_id after the feedback has been created. notes: convert to strong params. wiki pages: convert to strong params. * Also fix non-Builders being able to delete wiki pages. saved searches: convert to strong params. pools: convert to strong params. * Disallow setting `post_count` or `is_deleted` in create/update actions. janitor trials: convert to strong params. post disapprovals: convert to strong params. * Factor out quick-mod bar to shared partial. * Fix quick-mod bar to use `Post#is_approvable?` to determine visibility of Approve button. dmail filters: convert to strong params. password resets: convert to strong params. user name change requests: convert to strong params. posts: convert to strong params. users: convert to strong params. * Disallow setting password_hash, last_logged_in_at, last_forum_read_at, has_mail, and dmail_filter_attributes[user_id]. * Remove initialize_default_image_size (dead code). uploads: convert to strong params. * Remove `initialize_status` because status already defaults to pending in the database. tag aliases/implications: convert to strong params. tags: convert to strong params. forum posts: convert to strong params. * Disallow changing the topic_id after creating the post. * Disallow setting is_deleted (destroy/undelete actions should be used instead). * Remove is_sticky / is_locked (nonexistent attributes). forum topics: convert to strong params. * merges https://github.com/evazion/danbooru/tree/wip-rails-5.1 * lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4) * switch to factorybot and change all references Co-authored-by: r888888888 <r888888888@gmail.com> Co-authored-by: evazion <noizave@gmail.com> add diffs
2018-04-02 13:51:26 -04:00
class IqdbQueriesControllerTest < ActionDispatch::IntegrationTest
context "The iqdb controller" do
setup do
IqdbProxy.stubs(:endpoint).returns("http://iqdb:5588")
CloudflareService.stubs(:ips).returns([])
end
2018-06-14 20:03:41 -04:00
context "show action" do
2018-06-23 13:32:39 -04:00
context "with a url parameter" do
should "render a response" do
post = create(:post)
create(:upload_whitelist, pattern: "https://google.com/*")
stub_request(:get, "https://google.com/foo.jpg")
.to_return(body: file_fixture("test.jpg").read)
response = [{ "post_id" => post.id, "score" => 80 }]
stub_request(:post, "#{IqdbProxy.endpoint}/query").to_return_json(body: response)
get iqdb_queries_path, params: { url: "https://google.com/foo.jpg" }
assert_response :success
assert_select("#post_#{post.id}")
2018-06-23 13:32:39 -04:00
end
end
context "with a post_id parameter" do
2023-04-24 08:46:26 -04:00
should "redirect to iqdb" do
post = create(:post)
response = [{ "post_id" => post.id, "score" => 80 }]
stub_request(:post, "#{IqdbProxy.endpoint}/query").to_return_json(body: response)
Post.any_instance.stubs(:preview_file_path).returns(file_fixture("test.jpg"))
2018-06-23 13:32:39 -04:00
get iqdb_queries_path, params: { post_id: post.id }
2018-06-23 13:32:39 -04:00
assert_response :success
assert_select("#post_#{post.id}")
2022-05-26 16:49:43 -04:00
end
2017-04-05 19:48:57 -04:00
end
end
end
end